Template talk:Editor review

Image change

I changed the image, I couldn't bloody stand the other one. Dfrg.msc ^{1 . 2 . Editor Review} 07:45, 1 December 2006 (UTC)

Wording change request

{{editprotected}} Hey there all. Per Wikipedia:Administrators' noticeboard/Incidents#"Under review by Wikipedia"?, the following could probably be changed to avoid confusion in the future:

'''{{{user|This user}}} is currently on [[Wikipedia:Editor review|editor review]]. You may comment on {{{2|his or her}}} edits at [[Wikipedia:Editor review/{{#ifeq:{{BASEPAGENAME}}|Editor review|Example|{{{1|{{BASEPAGENAME}}}}}}}]].'''

could be changed to (or something along those lines):

'''{{{user|This user}}} has asked for Wikipedians to give them feedback at an [[Wikipedia:Editor review|editor review]]. You may comment on {{{2|his or her}}} edits at [[Wikipedia:Editor review/{{#ifeq:{{BASEPAGENAME}}|Editor review|Example|{{{1|{{BASEPAGENAME}}}}}}}]].'''

Thanks, NW (Talk) 17:49, 17 June 2009 (UTC)

 Done I've used your suggested wording, although it takes up quite a bit of extra room. We'll see what people think ... — Martin (MSGJ · talk) 09:15, 18 June 2009 (UTC)

Some modifications to parameters

{{editprotected}} This code could easily be modified to use the gender setting that the user set in his/her preferences:

You may comment on {{gender:{{BASEPAGENAME}} |his |her |their}} edits at

or keep the current switch:

You may comment on {{#if:{{{2|}}}|{{{2|his or her}}}|{{gender:{{BASEPAGENAME}} |his |her |their}}}} edits at

Currently you need to enter your user name as the first parameter if you want to enter your gender. This can be changed with named parameters. The resulting code would be:

{{ombox |image=[[File:Wikipedia Editor Review.svg|66px]] |text={{{user|This user}}} has asked for Wikipedians to give them feedback at an [[Wikipedia:Editor review|editor review]]. You may comment on {{#if:{{{gen|}}}|{{{gen|his or her}}}|{{gender:{{BASEPAGENAME}} |his |her |their}}}} edits at '''[[Wikipedia:Editor review/{{#ifeq:{{BASEPAGENAME}}|Editor review|Example|{{{name|{{BASEPAGENAME}}}}}}}]]'''.</br>{{#switch:{{{class}}} |review needed=[[Category:Wikipedians on Editor review/Backlog|{{BASEPAGENAME}}]][[File:Purple question mark.svg|25px]] This user is still awaiting reviews. Any comment would be greatly appreciated! |review had=[[File:Yes check.svg|25px]] This user already had at least one review, but wouldn't mind having several more reviews. }} }}<includeonly>[[Category:Wikipedians on Editor review|{{{name|{{BASEPAGENAME}}}}}]]</includeonly><noinclude> {{documentation}} </noinclude>

I will have to tinker around with it to see if I can suggest any other improvements. [mad pierrot][t c] 17:21, 27 July 2009 (UTC)

That sounds cool. Something needs to be done, because for those who want to specify gender, currently the use of parameter 2 in two locations does not work for the male variants of those pronouns. If I specify either "him" or "his" for that second parameter, one of the locations it's used will make for incorrect grammar.
-Garrett W. {☎ ✍} 09:24, 1 January 2010 (UTC)

I can have a look at coding this when I get a chance. In the meantime I have reduced the protection level of the template as it seemed excessive given the number of transclusions. — Martin (MSGJ · talk) 12:12, 1 January 2010 (UTC)

Grammar

This user has asked for Wikipedians to give them feedback...

Please change "them" to "his/her." :) —La Pianista ^{♫ ♪ How's my driving?} 06:40, 20 December 2009 (UTC)

Gender specification.

When specifying the gender in the template, the grammar is messed up, as it copies the same word to both places where the parameter takes effect. "This user has asked for Wikipedians to give his feedback at an editor review. You may comment on his edits at..."

Perhaps the second "his or her" needs to be split into a 3rd parameter? The Thing // Talk // Contribs 17:17, 13 July 2010 (UTC)