Template talk:If empty

(Redirected from Template talk:If empty/testcases)
Latest comment: 1 year ago by MSGJ in topic lastk?

Edit request

edit

Please merge {{If empty/sandbox}} into here. I believe User:Jackmcbarn and I have tested it quite thoroughly to ensure backwards compatibility. The only difference now is that this template is no longer limited to nine parameters and that it should run considerably faster. Also, someone may want to protect Module:If empty. —CodeHydro 21:52, 23 December 2014 (UTC)Reply

  Done Jackmcbarn (talk) 21:57, 23 December 2014 (UTC)Reply

Error transclusion issue with the new Lua version

edit

Since Module:If empty went live, all uses of {{Infobox mountain}} are transcluding errors. There is just one {{error}} check in this template, to ensure that the parameter name is given. I verified with {{Infobox mountain/sandbox}} that the old template did not transclude false errors unless the name truly was not given. Wbm1058 (talk) 18:33, 26 December 2014 (UTC)Reply

@Codehydro and Jackmcbarn: any comments? Can either of you fix this? I'm not following what you mean by "fragile, convoluted, hacky way to do it". Thanks, Wbm1058 (talk) 22:47, 26 December 2014 (UTC)Reply

Backcompat

edit

The tracking category is empty except for this template's testcases page (and I suspect it has been for years), so the backcompat code can probably be removed from the module. ディノ千?!☎ Dinoguy1000 02:51, 29 April 2022 (UTC)Reply

Agreed. * Pppery * it has begun... 15:29, 2 May 2022 (UTC)Reply
@Pppery: I've removed the backwards compatibility code from the module's sandbox (which also has a never-deployed bugfix); the testcases page looks fine (other than the undefined parameters case, which is to be expected). If everything looks good to you, it can be deployed and the tracking category tagged for deletion. ディノ千?!☎ Dinoguy1000 06:49, 5 May 2022 (UTC)Reply
Looks good to me. * Pppery * it has begun... 13:38, 5 May 2022 (UTC)Reply
Updated and tracking category deleted. ディノ千?!☎ Dinoguy1000 04:44, 6 May 2022 (UTC)Reply

lastk?

edit

As far as I can tell, in Module:If empty, the variable lastk (defined at line 6 and set at line 11) is never used. Can we remove it, or is there something tricky going on? — hike395 (talk) 10:42, 11 January 2023 (UTC)Reply

Removed in the sandbox version, tests look fine. — hike395 (talk) 10:45, 11 January 2023 (UTC)Reply
Please copy Module:If empty/sandbox to Module:If empty, see above. — hike395 (talk) 06:35, 22 January 2023 (UTC)Reply
  Done — Martin (MSGJ · talk) 18:33, 26 January 2023 (UTC)Reply