Template talk:Jcttop/core

Please move Template:Jcttop/core/sandbox into here to stop breaking articles: Wikipedia talk:Lua/Archive 2#Wikitext tables? --NE2 20:40, 22 January 2014 (UTC)

• Not done: and I don't expect it to be done... We don't use a sandbox module in a stable live template. What you need to do is go to Module talk:Jcttop/core and request that the code in there be updated with the sandbox code. Technical 13 (talk) 21:07, 22 January 2014 (UTC)
  • I'd be willing to do this, but I'd like confirmation from Happy5214 that the code is stable enough so that things won't break further. --Rschen7754 21:09, 22 January 2014 (UTC)
    • The sandbox code was deployed a week ago. Interstate 90 in Wyoming seems to work fine. If there are any other issues, please be sure to let me know. -happy5214 06:24, 23 January 2014 (UTC)

What happened to sub1_ref?

This template used to accept a |sub1_ref= parameter, which the wrapper template {{AUSinttop}} passes through, but I've just noticed now that it's not working. I'm not sure when it stopped working, perhaps during the switch to the lua module? Pinging @Happy5214: - Evad37 [talk] 07:53, 30 December 2014 (UTC)

Why did I not get pinged? I'm just glad I've watchlisted this page. I know I ported |sub1_ref=, and I'm pretty sure it worked initially. (Later...) While typing this, I noticed a small syntax typo Jackmcbarn left when converting the module from Module:HtmlBuilder to mw.html that might be causing this. I've fixed it in the sandbox, so test it to make sure. -happy5214 18:28, 30 December 2014 (UTC)

It's working with the sandbox version. I'll try another ping, because it should be working ... @Happy5214: ... - Evad37 [talk] 08:32, 3 January 2015 (UTC)

I just haven't copied the fix over to the live version. I'll do that now. -happy5214 19:44, 3 January 2015 (UTC)

 Done -happy5214 19:45, 3 January 2015 (UTC)

sub1name order

Could we get something that will allow us to flip the order of sub1 and sub1name (Foo County, Bar, becomes County Foo, Bar). This would be useful for Manitoba and Ireland (if we ever deploy there), among other locations. –Fredddie™ 05:18, 10 March 2015 (UTC)

@Fredddie: I think this is best handled in road data modules. {{jct}} also produces locations that have the same pattern, so these specifications should be collected as road data. Perhaps something like this:

-- Common definitions for USA; can be overridden, e.g., for Louisiana.
USA[" common "] = {
	locations = {
		sub1 = {linksuffix = "County", namesuffix = "County"},
		-- The "usual" areadab, putting disambiguating text in front.
		areas = {
			city = {linksuffix = "(city)", nameprefix = "City of"},
			town = {linksuffix = "(town)", nameprefix = "Town of"},
			village = {linksuffix = "(village)", nameprefix = "Village of"}
		}
	}
}

-- Manitoba?
MB[" common "] = {
	locations = {
		sub1 = {linkprefix = "County", nameprefix = "County"}
	}
}

This way we can customize based on regions while keeping data and code separate. Chinissai (talk) 23:05, 10 May 2016 (UTC)

Interesting. That's definitely in the spirit of the code we wrote when the cores were created, which was to keep the base code agnostic of any one region's nomenclature. –Fredddie™ 00:42, 11 May 2016 (UTC)