Template talk:Performance key
(Redirected from Template talk:Performance key/testcases)
Latest comment: 1 month ago by Fyunck(click) in topic short=yes does not include medals
 | This template does not require a rating on Wikipedia's content assessment scale. It is of interest to the following WikiProjects: | ||||||||||||||
| |||||||||||||||
 | The contents of the Performance key (Grand Slams) page were merged into Template:Performance key on March 23, 2016. For the contribution history and old versions of the redirected page, please see its history. |
|
|
Archives: 1 |
|
This page has archives. Sections older than 180 days may be automatically archived by Lowercase sigmabot III when more than 1 section is present. | |
Recent changes broke spacing
editQwerty284651, can you please test in the sandbox before introducing breaking changes to a live template? The template currently has at least one missing space and at least one extra space. I suggest that you revert your recent changes, copy them into the sandbox, and use the testcases page to ensure that your changes do not cause problems. – Jonesey95 (talk) 15:30, 15 August 2024 (UTC)
- It looks like you are away from Wikipedia for a while, so I have reverted these changes for now to avoid them appearing in the 2,000+ transclusions of this template. – Jonesey95 (talk) 17:36, 15 August 2024 (UTC)
- The issue caused here is related to the question I asked at village pump. I wanted to create a parameter that would only display the rounds when the parameter "rounds only" was invoked in List of Grand Slam and related tennis records#Won a title after saving match points as a legend for the various levels of competition in a tournament above the 2 tables. I experimented with it in the template's sandbox, but I already CSD'd the test page. I think the ";" that caused the bolding issues is also the cultpit for the spacing error caused after I resolved the MOS:DEFLIST. Qwerty284651 (talk) 22:55, 15 August 2024 (UTC)
- Try putting your attempted changes into Template:Performance key/sandbox. Then go to Template:Performance key/testcases to see how the sandbox version is rendered. Add another test case using copy/paste if you need to. – Jonesey95 (talk) 01:06, 16 August 2024 (UTC)
- Will do. Do I need to create a separate sandbox subpage like I did with Template:performance key/sandbox2 for testing or is Template:performance key enough? Qwerty284651 (talk) 17:54, 16 August 2024 (UTC)
- I tested in Template:Performance key/testcases#Test 5 and I don't see the spacing issues you mentioned before. Qwerty284651 (talk) 18:26, 16 August 2024 (UTC)
- You don't need a separate sandbox2 page. Just use /sandbox. In the current testcases, I see invalid spacing in the sandbox version such as "robin stage ." and "loss record ." I think I have fixed that, but now I am noticing "RR|Q#" in one of the column headers. Please visually inspect the differences in each test case carefully, and try to fix any remaining errors in the sandbox code. – Jonesey95 (talk) 18:39, 16 August 2024 (UTC)
- Looks good on my end now. Qwerty284651 (talk) 18:58, 16 August 2024 (UTC)
- It is unclear to me why you edited the live template without thoroughly inspecting each test case. Please slow down; there is no urgency here. I am seeing "(W–L) win–loss record; " at the end of the first test case. I believe that there should be a full stop instead of a semicolon at the end of that text. – Jonesey95 (talk) 19:10, 16 August 2024 (UTC)
- Whenever a param was used and it was not the end of the description text, a semicolon was displayed instead of a full stop and nobody has said a thing. It's been like this for years before I started editing this template. A switch would have to be set to display . instead of ; at the end of each param or combo thereof. Qwerty284651 (talk) 19:14, 16 August 2024 (UTC)
- Also, see other testcases. They too have semicolons. Qwerty284651 (talk) 19:17, 16 August 2024 (UTC)
- Look at the testcases page. The live template (in the left column) appears to be punctuated correctly. The sandbox template (in the right column) is punctuated incorrectly. If you want to add a test case to demonstrate invalid punctuation with some combination of parameters, please do so. Please do not edit the live template until you and I agree that the sandbox is rendering at least as well as the live template. – Jonesey95 (talk) 19:19, 16 August 2024 (UTC)
- How about now? Does it look good? Qwerty284651 (talk) 19:36, 16 August 2024 (UTC)
- Not yet. The "RR|Q#" is back. Also, why is "NH" gone from all of the sandbox cases? Keep persisting. You'll get it. – Jonesey95 (talk) 20:14, 16 August 2024 (UTC)
Done Qwerty284651 (talk) 20:24, 16 August 2024 (UTC)
- I checked the code changes and the testcases, and I do not see any problems with the changes. I have updated the template. – Jonesey95 (talk) 22:43, 16 August 2024 (UTC)
- Not yet. The "RR|Q#" is back. Also, why is "NH" gone from all of the sandbox cases? Keep persisting. You'll get it. – Jonesey95 (talk) 20:14, 16 August 2024 (UTC)
- How about now? Does it look good? Qwerty284651 (talk) 19:36, 16 August 2024 (UTC)
- Look at the testcases page. The live template (in the left column) appears to be punctuated correctly. The sandbox template (in the right column) is punctuated incorrectly. If you want to add a test case to demonstrate invalid punctuation with some combination of parameters, please do so. Please do not edit the live template until you and I agree that the sandbox is rendering at least as well as the live template. – Jonesey95 (talk) 19:19, 16 August 2024 (UTC)
- It is unclear to me why you edited the live template without thoroughly inspecting each test case. Please slow down; there is no urgency here. I am seeing "(W–L) win–loss record; " at the end of the first test case. I believe that there should be a full stop instead of a semicolon at the end of that text. – Jonesey95 (talk) 19:10, 16 August 2024 (UTC)
- Looks good on my end now. Qwerty284651 (talk) 18:58, 16 August 2024 (UTC)
- You don't need a separate sandbox2 page. Just use /sandbox. In the current testcases, I see invalid spacing in the sandbox version such as "robin stage ." and "loss record ." I think I have fixed that, but now I am noticing "RR|Q#" in one of the column headers. Please visually inspect the differences in each test case carefully, and try to fix any remaining errors in the sandbox code. – Jonesey95 (talk) 18:39, 16 August 2024 (UTC)
- I tested in Template:Performance key/testcases#Test 5 and I don't see the spacing issues you mentioned before. Qwerty284651 (talk) 18:26, 16 August 2024 (UTC)
- Will do. Do I need to create a separate sandbox subpage like I did with Template:performance key/sandbox2 for testing or is Template:performance key enough? Qwerty284651 (talk) 17:54, 16 August 2024 (UTC)
- Try putting your attempted changes into Template:Performance key/sandbox. Then go to Template:Performance key/testcases to see how the sandbox version is rendered. Add another test case using copy/paste if you need to. – Jonesey95 (talk) 01:06, 16 August 2024 (UTC)
- The issue caused here is related to the question I asked at village pump. I wanted to create a parameter that would only display the rounds when the parameter "rounds only" was invoked in List of Grand Slam and related tennis records#Won a title after saving match points as a legend for the various levels of competition in a tournament above the 2 tables. I experimented with it in the template's sandbox, but I already CSD'd the test page. I think the ";" that caused the bolding issues is also the cultpit for the spacing error caused after I resolved the MOS:DEFLIST. Qwerty284651 (talk) 22:55, 15 August 2024 (UTC)
short=yes does not include medals
editWhen using short, medal keys are missing,e.g. in this page https://en.wikipedia.org/wiki/Lorenzo_Musetti. Ideally, the template should show all used keys - and only those- — Preceding unsigned comment added by 129.59.122.81 (talk) 18:27, 23 September 2024 (UTC)
Not done The issue was with the article. On full performance charts we should not be using the "short" attribute. Short performance tables do not include the olympics so no fix is needed. Thanks, I corrected Musetti's article. Fyunck(click) (talk) 21:13, 23 September 2024 (UTC)
