Module talk:Bracket

Changes broke rendering of names

Ahecht, recent changes may have broken rendering of names. See this version of my sandbox for an example. The second name is omitted from the rendered code, leaving just six apostrophes. Please make a testcases page so that problems like this are less likely to happen in live articles. – Jonesey95 (talk) 19:26, 19 August 2024 (UTC)

@Jonesey95 If you use {{4TeamBracket-Tennis3}} the second name is also omitted, and nothing I did changed that template (or the underlying Module:Team bracket):

	Semifinals							Final
	1	Vladimir Ivanov Ivan Sozonov	19	21	16r
	4	Kim Astrup	21	15	17

--Ahecht (TALK
PAGE) 19:50, 19 August 2024 (UTC)

Ah, I see it was a more subtle change that you made to the articles, replacing {{nowrap}} with span tags, that broke the article from which I pulled this code. You might want to install the LintHint script or check Page information after your edits; that's how I found these errors. I've been bitten by this span tag trickiness before. I fixed one for you. Please do create a testcases page, however, and either update the documentation or stop introducing this alpha module into articles. – Jonesey95 (talk) 20:34, 19 August 2024 (UTC)

Note: I have fixed the ubl template above with a |1= before the span tag; the actual error can be seen in the edit history of this page. – Jonesey95 (talk) 20:39, 19 August 2024 (UTC)

Thanks. The RegEx list I've been using to clean up pages that exceed the PEIS limit used to have a check to make sure that nowrap wasn't being substed inside a template, but I seem to have removed that check accidentally at some point. I went through all my other edits and cleaned up the other 7 with that error (except the one you got to first), and just removed the nowrap substing regex altogether from my list for sports articles since the bang-for-the-buck is much lower than other changes I'm making.

I originally hadn't made a testcase page because it VERY quickly exceeded the post-expand include size, instead just testing new functions "live" in my sandbox one at a time before introducing them to articles, but I did go ahead and populate Module:Bracket/testcases. You just have to comment out most of the testcases to get it to actually render. --Ahecht (TALK
PAGE) 21:09, 19 August 2024 (UTC)

Ironic on the testcases, given the purpose of this thing. Agreed on leaving nowrap as-is. Flagicon templates seem to be much more intensive than others, especially when they are used so many times. I sometimes just remove them, or at least some of them, if there is part of MOS that applies. – Jonesey95 (talk) 05:24, 20 August 2024 (UTC)

Module marked "alpha" is being used in 129 articles

Why is this module being used in 129 articles when its documentation specifically says not to do so? This is a live article that is currently broken by transclusion of this alpha module. – Jonesey95 (talk) 19:27, 19 August 2024 (UTC)

@Jonesey95 The article wasn't broken by this module. In my attempts to rescue the 100 or so articles that were broken because your edit at Special:Diff/1240306306 bumped them over the WP:PEIS limit, a very small handful ended up with an extra equals sign inside of the {{ubl}} template that I didn't catch when previewing the pages. Those have since been fixed. --Ahecht (TALK
PAGE) 20:04, 19 August 2024 (UTC)

Why is this module being used in 129 articles when its documentation specifically says not to do so? Something doesn't line up. – Jonesey95 (talk) 20:34, 19 August 2024 (UTC)

@Jonesey95 Because I forgot to update the module rating on the documentation page in June after running all my initial tests. --Ahecht (TALK
PAGE) 21:03, 19 August 2024 (UTC)