Not bolding teams by default

edit

Hi, @CRwikiCA:. I don't know if you continue working on this module but as I saw a user changed the results table of 2015–16 ACB season (Spanish basketball league) to the one with the module, I'd like to ask you if it would be better not to show the teams in the table with bolded font by default. It would make easier to recognize a highlighted team if you use the "showteam" parameter. Greetings! Asturkian (talk) 17:42, 21 July 2015 (UTC)Reply

@Asturkian: Below I printed a filled example and an empty example. It is only unclear when the cells are empty in my opinion. In which situation would you highlight a team like this? I implemented the showteam functionality mostly to incorporate it in the table module. CRwikiCA talk 20:29, 21 July 2015 (UTC)Reply
Home \ Away ADO AJX AZ CAM DOR EXC FEY GAE GRO HEE HER NAC PEC PSV TWE UTR VIT WII
ADO Den Haag 1–1 2–3 2–2 2–0 2–2 0–1 1–1 3–0 0–1 1–3 3–2 3–2 2–3 2–0 2–0 1–0 3–2
Ajax 1–0 0–1 3–0 4–0 1–0 0–0 3–1 2–0 4–1 2–1 0–0 0–0 1–3 4–2 3–1 4–1 5–0
AZ 3–1 1–3 2–1 2–0 3–3 1–4 2–0 2–2 0–1 3–1 3–2 1–0 2–4 2–2 0–3 1–0 2–0
Cambuur 3–2 2–4 0–2 4–1 1–1 0–1 1–0 3–0 2–1 1–0 0–1 2–1 1–2 1–1 3–1 0–2 1–2
Dordrecht 0–0 2–1 1–3 0–0 1–0 1–2 2–1 1–1 0–0 2–3 0–1 1–2 1–3 0–4 1–3 2–6 0–4
Excelsior 2–3 0–2 1–4 1–1 1–1 2–5 3–2 1–1 3–0 3–1 0–0 0–5 2–3 2–1 2–2 1–3 2–3
Feyenoord 2–1 0–1 2–2 2–1 2–0 3–2 0–1 4–0 1–1 2–1 3–0 2–0 2–1 3–1 1–2 1–4 1–2
Go Ahead Eagles 1–0 1–2 0–2 1–2 0–0 0–0 0–4 2–3 1–1 1–3 2–0 3–2 0–3 1–3 0–2 0–2 1–0
Groningen 1–1 2–0 2–4 3–2 2–0 1–1 1–1 2–0 1–1 3–1 1–0 0–1 1–1 2–2 2–2 1–1 1–0
Heerenveen 0–0 1–4 5–2 2–2 1–2 2–0 3–1 2–2 3–1 0–1 0–0 4–0 1–0 1–3 3–1 4–1 1–1
Heracles 3–1 0–2 0–3 0–1 1–1 0–3 2–0 1–0 2–2 1–4 6–1 2–0 1–2 1–4 1–1 1–1 1–3
NAC Breda 1–1 2–5 0–1 2–1 2–2 1–1 0–1 1–0 4–5 0–2 1–3 3–1 0–2 1–1 1–5 0–1 0–0
PEC Zwolle 3–1 1–1 1–1 6–1 4–0 1–1 3–0 0–1 2–0 2–2 4–2 4–1 3–1 1–2 2–0 2–1 1–0
PSV 1–0 1–3 3–0 4–0 3–0 3–0 4–3 5–0 2–1 4–1 2–0 6–1 3–1 2–0 3–1 2–0 2–1
Twente 2–2 1–1 0–2 2–1 3–0 1–3 0–0 2–1 1–2 2–0 2–0 1–1 2–0 0–5 3–1 1–2 3–2
Utrecht 0–0 1–1 6–2 1–3 6–1 2–2 0–0 2–3 1–0 1–2 2–4 3–4 0–2 1–5 1–0 3–1 2–1
Vitesse 6–1 1–0 3–1 2–2 3–0 3–1 0–0 2–2 1–1 1–1 3–0 2–2 2–1 0–1 2–2 3–3 2–0
Willem II 1–0 1–1 3–0 1–1 2–1 1–1 2–2 1–0 1–4 2–1 3–0 2–1 0–1 1–3 2–2 1–0 1–4
Updated to match(es) played on 17 May 2015. Source: NUsport
@CRwikiCA: I think the table would look better without bolding the name of all teams, like with the "Template:Fb r" format. It's simply a stetical thing. Bolding teams could be used if you take the table to a team article. But all I'm telling you is only a minor detail. Greetings. Asturkian (talk) 20:42, 21 July 2015 (UTC)Reply
I think I would have to agree with Asturkian. I can not see any reason for why you would add the list of results above to a team article with bolding, but when it is a standalone table,, the team names should not be bolded, unless show_team is used. Qed237 (talk) 20:46, 21 July 2015 (UTC)Reply
At least in the vertical row. In the horizontal one with the short names is not as ugly as in the other one. Asturkian (talk) 20:49, 21 July 2015 (UTC)Reply
Very well, I'll put in on the to-do list. I don't know when I'll get to it though. CRwikiCA talk 15:36, 24 July 2015 (UTC)Reply

I started working on this. the row headers were easy, and the col headers are possible, but will require a bit more work. Frietjes (talk) 19:18, 6 December 2016 (UTC)Reply

coloring the background

edit

Hi @CRwikiCA:,Could you add option to color the cell like in the case of the other template depending on home win, away win, draw? Coderzombie (talk) 13:07, 18 January 2016 (UTC)Reply

@Coderzombie: Since CRwikiCA has taken a step back and dont edit as frequently as before I hope you dont mind if I answer this question. Of course CRwikiCA can also reply later. The colors could probably be added on (and I think they should), but it should be done carefully since this template is also used in standingstables where no colors should be shown. Also it might be worth taking it to WT:FOOTY for discussion if these colors are to be used or not. Qed237 (talk) 13:28, 18 January 2016 (UTC)Reply
@Qed237: : Colors, of course should be completely optional and should be added only as additional parameters, if the need be. Coderzombie (talk) 13:31, 18 January 2016 (UTC)Reply
@Coderzombie: Yes, that sounds very reasonable and although I have not looked at the code I think it is possible. Qed237 (talk) 13:33, 18 January 2016 (UTC)Reply
@Qed237 and Coderzombie:Technically it is possible to add colours, I do not have the time for that now though. Using colours would, however, violate the Manual of Style (MOS:COLOR), because it would not add much information and only make the table look like a Christmas tree. CRwikiCA talk 15:31, 18 January 2016 (UTC)Reply
@CRwikiCA: I see your point but dont think it would "look like a christmas tree" since it is only three colors (win, draw, loss) and it is working on table's like 2015–16 Premier League#Results. We should not use only colors to mark things, but using it as a complement in these tables I think would work. Qed237 (talk) 16:06, 18 January 2016 (UTC)Reply
Personally I don't think colour adds anything at all for these kinds of tables. The eye will see patterns where no patterns exist. Maybe it could work if the teams were order according to their ranking rather than alphabetically, but in the current format it doesn't add value at all in my mind. That being said, technically it wouldn't be particularly hard to colour cells. The hardest part will be to parse the input to get a score comparison out of it (although this could be bypassed by setting a colour code for each result in the module call). CRwikiCA talk 15:40, 19 January 2016 (UTC)Reply

Matches that won't be played

edit

Is there a way to mark in a results table that the match won't be played? I've just converted the tables on 2016–17 Scottish League Cup to the sports template so that the penalty shootout result can be shown clearly (the competition awards an extra point to the winner of this) - however, teams only play single round robin, not double round robin. I couldn't see a way to blank out a game that is not played in this results table. Does one exist? if not, can it be added, as I'm sure this competition isn't the only case of a single round robin group stage. 2.223.172.229 (talk) 21:03, 16 July 2016 (UTC)Reply

The standard in this situation is to use — for those matches. As an example look at Template:2015–16 Svenska Cupen Group 1 table. Qed237 (talk) 23:14, 16 July 2016 (UTC)Reply

Module:Head to head

edit

without knowing about the existence of this module, I created Module:Head to head. I would like to merge that module into this one to avoid having two modules that do basically the same thing. the major missing features, as far as I can tell, are

  1. Module:Head to head doesn't require 'short_ABC' parameters, but can use them if supplied. if there are no 'short_ABC' parameters, it automatically generates one based on the value in corresponding 'team#', changing the link text in 'name_ABC'.
  2. Module:Head to head mimics the colouring generated by the {{Fb r team}} template. we could import that code here, but, of course, make it off by default.
  3. Module:Head to head has a template_name optional parameter to add VTE links.

I was also planning to write a helper function which generates a blank invocation, given only the team# parameters. comments? problems? thank you. Frietjes (talk) 13:32, 3 December 2016 (UTC)Reply

for an example of a helper function, for example, try
{{subst:#invoke:Sports results/blank|main
| team1 = AAA | name_AAA = [[A|Team A]]
| team2 = BBB | name_BBB = [[B|Team B]]
| team3 = CCC | name_CCC = [[C|Team C]]
| team4 = DDD | name_DDD = [[D|Team D]]
| team5 = EEE | name_EEE = [[E|Team E]]
}}
I think this would be useful to have for this module as well. Frietjes (talk) 14:00, 3 December 2016 (UTC)Reply

I agree that they should be merged. There is no need for two modules and we should definately get a working module instead of creting new fb team templates all the time (one of the reasons for creating the module for standings table was to remove use of team templates). Regarding the points above, I see no reason why we could not remove the short_ABC parameters as long as the can be used if required. In general, the less information editors have to put in is better. I think adding the colors, but with off by default is a really good idea. In templates like {{2018 FIFA World Cup qualification – OFC Third Round Group A table}} (see documentation for full table) there is no need to color home and/or away wins, and since Module:Sports table already uses this module it should be turned off by default. However, I think they are still useful when the results are listed alone just like they are now in many league season articles (despite the MOS:ACCESS discussion above). Also the possibility to add vte button is fine as long as it does not collide with Module:Sports table. I have no idea how the helper function would work, so I have no comment about that. Qed237 (talk) 16:26, 3 December 2016 (UTC)Reply

It would be good to implement these ideas. The only thing I do not agree with is the cell colouring. I understand it has been practice for users. But a) it violates the Manual or Style, and b) I have never seen an implementation in which these colours provide any clarity at all. Quite the contrary, colouring seems to take away from the content, because it does not provide any meaningful visual support, rather than looking at a Christmas tree. For example 2010–11 Eredivisie#Results: how does colouring do anything positive here?
I like making the short optional, the less required of the user the better. Adding vte links is always a good idea as well. Generating a blank table with a helper function would make it very user friendly, so that would be great. It might also be worth looking into that for the standings table module. CRwikiCA talk 03:41, 4 December 2016 (UTC)Reply
The colors make it easier to see a teams result. For example if you look at Willem II in your example above, and especailly their away column, you can see that there is not a single red so they have not won away all season. Color makes those things easier to spot. Qed237 (talk) 10:59, 4 December 2016 (UTC)Reply
my objective here is to replace {{fb r team}} with something less complex. if there is some site-wide violation of colouring in {{fb r team}}, we should remove it from that template first. if we add this as an option to this template, we can always turn it off later in the module. for now, I will work on adding (1) and (3). Frietjes (talk) 14:21, 4 December 2016 (UTC)Reply
The fb team templates should be removed so it is a good initiative. My biggest concern going from the old results table to the module is a lot of incorrect dashes. In the old system editors just write goals for home team and away team, and the dash is then inserted automatically. Qed237 (talk) 21:50, 4 December 2016 (UTC)Reply
I do not agree with the colouring helping much in that sense, but if it is beneficial I will not stand against it. One thought would be to change all dashes (i.e.: -, –, —) to a default (or use defined dash) including spacing options. CRwikiCA talk 02:55, 5 December 2016 (UTC)Reply
I had the same thought about dashes. we can automatically change all of them (within the module) to the correct ndash without spacing. I will work on this shortly. Frietjes (talk) 14:00, 5 December 2016 (UTC)Reply
I have completed the merger, the optional colouring is toggled by |matches_style=FBR (i.e., same as the fb result system). the only other thing that I can think of is that we may want to turn off bolding of the headers so that the |showteam= bolding is more distinct. but, that's a minor issue. Frietjes (talk) 14:58, 5 December 2016 (UTC)Reply
Good work! I thought the bolding came with setting it as column headers, but I haven't been too active lately, so I'm not too up-to-date with my know-how. CRwikiCA talk 02:59, 6 December 2016 (UTC)Reply
CRwikiCA, by default all table headings, i.e., <th>...</th>, are bold. in {{fb r header}} they get around this by using <td>...</td> instead of <th>...</th>. this is wrong, since they are table headings. but you can make them unbolded by default by setting font-weight:normal for all the non-showteam rows and column headers. or, for the rows by adding the class "plainrowheaders". Frietjes (talk) 14:51, 6 December 2016 (UTC)Reply
started working on it per the thread above. Frietjes (talk) 19:19, 6 December 2016 (UTC)Reply
Very well, I have no problem allowing those kinds of items as options as long as the accessibility of tables (per MOS) are taken into account. CRwikiCA talk 02:10, 7 December 2016 (UTC)Reply

Blank starter invocation

edit

@CRwikiCA, Qed237, and Drawoh46: you can now generate a blank invocation by typing

{{subst:#invoke:Sports results/blank|main
| team1 = AAA | name_AAA = [[A|Team A]]
| team2 = BBB | name_BBB = [[B|Team B]]
| team3 = CCC | name_CCC = [[C|Team C]]
| team4 = DDD | name_DDD = [[D|Team D]]
| team5 = EEE | name_EEE = [[E|Team E]]
}}

this should also work on a completed invocation to reformat it. in other words, add any missing parameters and remove any unknown ones. Frietjes (talk) 15:03, 6 December 2016 (UTC)Reply

Great work! CRwikiCA talk 02:09, 7 December 2016 (UTC)Reply
Could you add "matches_style=" to the parameters? Great work, btw. Asturkian (talk) 22:39, 8 December 2016 (UTC)Reply
Asturkian, if you add |matches_style= before you substitute the blank module, it will be included after you substitute. I didn't have it added by default since there was some discussion about whether or not colouring is needed. Frietjes (talk) 14:35, 9 December 2016 (UTC)Reply
{{subst:#invoke:Sports results/blank|main
| matches_style = FBR | no_short = y
| team1 = AAA | name_AAA = [[A|Team A]]
| team2 = BBB | name_BBB = [[B|Team B]]
| team3 = CCC | name_CCC = [[C|Team C]]
| team4 = DDD | name_DDD = [[D|Team D]]
| team5 = EEE | name_EEE = [[E|Team E]]
}}
Asturkian, above is what I use. it adds the matches_style and doesn't include the short_XYZ since they can be automatically determined. Frietjes (talk) 14:40, 9 December 2016 (UTC)Reply

Background colors, part 2

edit

Can there be separate colors for overtime wins/losses and forfeit wins/losses? (See an example here.) Also, as there are some sports that don't allow draws, can the note "Colours: Blue = home team win; Yellow = draw; Red = away team win." be edited for cases such as this? And can there be an option for the "color" spelling? –HTD 22:10, 22 December 2016 (UTC)Reply

Surely the footnote would be easy to edit. For the overtimes and colors, maybe adding an option like "|result_AAA_BBB=OT", OTW or OTL would help. In other way, in the 2016–17 EuroLeague article, the yellow is used for games decided in overtime, as the points scored in the extra times do not count for the league table, neither for any head-to-head. Asturkian (talk) 21:29, 21 March 2017 (UTC)Reply
@Asturkian: I've been using a separate template for results tables, and they do have different colors for overtime results. In other leagues, points scored in OT count in standings and stats. See 2016–17 ABL season for an example, where overtime wins and losses have different colors (OTW=darker green, OTL=darker red, although I'd be amenable to lighter shades as this seems to be built in already), with the number of overtime periods being denoted by the number of asterisks. If that can be built in here, that'll be great.
Another option would be having separate colors for forfeited wins and losses. See UAAP Season 79 basketball tournaments#Juniors' tournament for an example.
Also, there are leagues and tournaments where there are no home and away teams, so perhaps making "Home \ Away" editable may help. –HTD 12:27, 26 March 2017 (UTC)Reply

:::Any news about this possible improvement? Asturkian (talk) 15:03, 23 June 2017 (UTC)Reply

I've just added "|matches_style=BR", that indicates in the footer the use of yellow for matches decided after an overtime, like in the 2016–17 EuroLeague. I do not know too much how to work with these codes, so I can not do, at this moment, more than this. Asturkian (talk) 15:10, 23 June 2017 (UTC) And now I just realised this does not do anything. Damn. Asturkian (talk) 15:16, 23 June 2017 (UTC)Reply
@Asturkian: I think you may have accidentally changed the colouring of the table for all transclusions, so I restored the module to the stable version. S.A. Julio (talk) 02:45, 27 June 2017 (UTC)Reply

Is there any user who wants to try the overtimes option and other type of colors and footers? After my last failure, I'm afraid to try new attempts. Asturkian (talk) 14:15, 6 August 2017 (UTC)Reply

Any news?

edit

Hi, are there any news about this module? Specially about how to color the overtimes and how to change the footnote, e.g., for sports where there are not draws.

BTW, I see basketball articles where still there are {{Bs r}} modules, that they are a copy of the {{fb r}} ones and are deprecated. Asturkian (talk) 07:13, 30 September 2017 (UTC)Reply

Possibility of reducing font size

edit

Hi, it would be good to have the possibility of reducing the font size of the table. This would be interesting, e.g., in basketball leagues where there are 16 or more teams. With the normal size, it is probably that the table does not fit in the screen of so much computers. Asturkian (talk) 09:33, 30 December 2017 (UTC)Reply

Overtime note

edit

I see that there are now different colors for games decided in OT. (Yay!) Can there be a US English option for the OT note for the "colour" spelling? –HTD 22:43, 12 March 2018 (UTC)Reply

Changing default background colouring

edit

At 1927–28 KBUs Mesterskabsrække#Results and 1927–28 FBUs Mesterskabsrække#Results two matches were changed/decided administratively afterwards with the score 0-0! but the matches were actually awarded as 2 points wins to Kjøbenhavns Boldklub and Boldklubben 1909 respectively in the overall standings. The situation is not reflected in the results table, where these matches are listed as ties instead of wins. This was previously the most common situation for administratively changed results in Danish football - nowadays administratively decided matches would be changed to a 3-0! win to one of the teams. Is there a possibility to change the automatic background colouring of results using an additional parameter? Froztbyte (talk) 13:43, 22 March 2018 (UTC)Reply

I'd second this. There are matches in some leagues that are forfeited or vacated. Separate colors forfeited/vacated wins/losses should be added. –HTD 14:58, 14 April 2018 (UTC)Reply
Agree. We need the ability to have a background color of grey for match that will not be played.

For example in the 2018–19 Ukrainian Second League both Group competitions with have each team play each other 3 times. The third time they play each other the League will determine in a separate draw - so there will not be a home/away series. In this a blank "grey color" should be used as in the previous template. The idea of using this new module was that it would be seamlessly replace the old method of displaying the results. But in this area of color schematics it still needs some fixing. Brudder Andrusha (talk) 14:38, 27 July 2018 (UTC)Reply

Brudder Andrusha (talk · contribs) Is the suggestion to allow any background colour? CRwikiCA talk 02:06, 28 July 2018 (UTC)Reply
@Brudder Andrusha: You should just be able to type 'null' instead of the score for the matches which don't occur, correct? S.A. Julio (talk) 10:05, 28 July 2018 (UTC)Reply
@S.A. Julio:, @CRwikiCA: Fair enough. Entering null works fine. I think the next best step is to get the documentation with all these different parameters or arguments with this last example that confounded me, even after looking at the code up to scratch. Thanks. Brudder Andrusha (talk) 19:06, 28 July 2018 (UTC)Reply

Home \ Away

edit

Some leagues and several international tournaments do not have clear-cut home and away teams. Can there be an option where column header be changed to "Teams", instead? –HTD 14:57, 14 April 2018 (UTC)Reply

@Frietjes: are you able to do this? Howard the Duck (talk) 23:54, 24 June 2018 (UTC)Reply
Howard the Duck, |team_header=Teams should work now. Frietjes (talk) 12:27, 25 June 2018 (UTC)Reply
Awesome. Thanks! Howard the Duck (talk) 21:11, 25 June 2018 (UTC)Reply
Would it be possible if team_header is used, the footer note changes into " Colours: Blue = left column team win; Red = top row team win."? Howard the Duck (talk) 21:27, 25 June 2018 (UTC)Reply
okay. Frietjes (talk) 00:11, 26 June 2018 (UTC)Reply
@Frietjes and Howard the Duck: To be more general it might be better to allow for a free text footnote, as the |team_header= can have any term. CRwikiCA talk 01:32, 26 June 2018 (UTC)Reply
That would work too. Thanks to all! Howard the Duck (talk) 02:44, 27 June 2018 (UTC)Reply

A-league

edit

I just convert fb r templates to this module [1], but someone suggests changing some in this module per Talk:2018–19 A-League#No results table before converting:

  1. Merge two tables into one table like old one such as 2017–18 A-League#Results format
  2. When games which don't happen (like club against itself and in the second half of the season) are greyed out, not marked with a dash.
  3. change coming to upcoming in a note if some articles are necessary

Pinging Frietjes, thanks Hhkohh (talk) 08:57, 2 November 2018 (UTC)Reply

I already went ahead and changed the note as that was simple to do. The other things I don't know how to do, but they make the table more readable. --SuperJew (talk) 09:03, 2 November 2018 (UTC)Reply
Suggest @SuperJew: If we add |grey=yes in article, table show grey instead of a dash or table show dash in default, thoughts? Hhkohh (talk) 09:11, 2 November 2018 (UTC)Reply
@SuperJew, Hhkohh, and J man708: I see, so we want to support two legs? should be possible, we just need the syntax for this. I am looking at the results for 2017–18 and wondering why WSW played themselves? looks like that was added by Bobly with this edit? in any event, how is this? if it looks acceptable, I can merge it with the main "live" module.
Home \ Away ADE BRI CCM MCY MVC NEW PER SYD WEL WSW ADE BRI CCM MCY MVC NEW PER SYD WEL WSW
Adelaide United 1–1 1–1
Brisbane Roar 1–1 0–0
Central Coast Mariners 1–1 a a
Melbourne City a a
Melbourne Victory 1–2 2–3 a a
Newcastle Jets a
Perth Glory 1–1
Sydney FC a 2–0 a
Wellington Phoenix 2–1
Western Sydney Wanderers a
Updated to match(es) played on 1 November 2018. Source: A-League
Legend: Blue = home team win; Yellow = draw; Red = away team win.
For upcoming matches, an "a" indicates there is an article about the rivalry between the two participants.

— Preceding unsigned comment added by Frietjes (talkcontribs) 13:03, 2 November 2018 (UTC)Reply

Repinging @SuperJew and J man708: due to unsigning Hhkohh (talk) 14:29, 2 November 2018 (UTC)Reply
Frietjes, looks fine to me Hhkohh (talk) 14:30, 2 November 2018 (UTC)Reply
Incidentally, I fixed some of that 2017–18_A-League table. Generally it's only The Cove that say that the Western Sydney Wanderers have been playing with themselves. Matilda Maniac (talk) 14:46, 2 November 2018 (UTC)Reply
Matilda Maniac, great, thank you! Hhkohh, I have merged the optional legs feature with main live module. I slightly enlarged the border between the legs to have a visual separator. the font_size = 88% and solid_cell = grey options appear to provide the best match to what is there already. Frietjes (talk) 13:52, 3 November 2018 (UTC)Reply

Extra column

edit

Is there any way of adding a simple extra column to the right hand end of the table? Possibly separated from the main part of the table with a heavier grey/black vertical line. The reason I ask is, the table at 2020–22 ICC Cricket World Cup Super League#Schedule would look far better if it used this Sports Results template, but at the moment it has a very useful extra column, and I don't know how to replicate this using this template. (The extra column is useful as each of the 13 teams plays 4 others at home, 4 others away, and 4 others not at all, and it's not otherwise obvious which countries won't play each other without laboriously checking the horizontal and vertical columns.) Thanks Mmitchell10 (talk) 11:16, 27 December 2018 (UTC)Reply

possible, but it will take some programming. Frietjes (talk) 16:01, 16 May 2019 (UTC)Reply
There are alternative solutions, so don't worry about it if it's going to be a lot of hassle. Mmitchell10 (talk) 18:57, 16 May 2019 (UTC)Reply

Fixed highest_pos and some other arg handling

edit

I have made some changes to the "highest_pos" parameter and simplified the arg-processing. the "highest_pos" and "lowest_pos" parameters will restrict the range of teams shown for both the rows and the columns. I had originally thought we might want to only restrict the rows, but that wouldn't make sense since you would have all the home games but not all the away games. Frietjes (talk) 16:01, 16 May 2019 (UTC)Reply

'a_note' is a contradiction in terms

edit

Args['a_note'] inserts the text "For upcoming matches, an "a" indicates there is an article about the match." This is a contradiction in terms. "Upcoming" means the match has not taken place; "there is an article about the match" means the match has taken place. In the article I am looking at, 2019–20 Premier League, "a" links to an article about traditional rivalry between the two clubs. I don't know if this is used for individual sports as well. If it is, the text should be changed to "For upcoming matches, an "a" indicates there is an article about the rivalry between the two participants"; if not, "participants" could be changed to "clubs" or "teams", as appropriate. Scolaire (talk) 11:15, 28 July 2019 (UTC)Reply

@Frietjes, Vasconia, and CRwikiCA: between you, you have the most edits to this page. Scolaire (talk) 11:36, 28 July 2019 (UTC)Reply
Scolaire, okay, I will change it as suggested. we can change it to something else if anyone has a better suggestion for the text.Frietjes (talk) 13:22, 28 July 2019 (UTC)Reply

Notelist oddity

edit

Hello, I've recently been cleaning up some sports pages on Category:Pages_with_missing_references_list due to a missing {{notelist}} citation error,

Cite error: There are <ref group=lower-alpha> tags or {{efn}} templates on this page, but the references will not show without a {{reflist}} template or {{notelist}} template.

Despite the error message, there weren't actually any {{efn}} tags or associated <ref> tags on the page. This can happen if there is an {{efn}} tag in a template that is included on the page, so that's what I figured happened.

After receiving a comment on my talk page from @Govvy: regarding one of my edits, I dove a bit deeper.

  • I found that the {{efn}} tag is included on the page via {{:2001–02 FA Premier League|showteam=TOT}}
  • I investigated 2001–02 FA Premier League and found that the page uses Lua scripts to build the table.
  • I investigated Module:Sports results, the Lua script used to build the table, and it looks like the script is not properly building the {{notelist}} in HTML. The script is building the list as <div class="reflist"> when it should be <div class="reflist" style="list-style-type: lower-alpha;">.
  • I'm assuming the incorrectly generated {{notelist}} is the root cause of the issue and is why the page appeared on Category:Pages_with_missing_references_list and resulted in the need for the {{notelist}} being added to the bottom of the page (instead of after the table where it belongs) in the first place.

Let me know your thoughts and if I can do anything to help. — TheJJJunk (say hello) 13:56, 26 October 2019 (UTC)Reply

User:TheJJJunk, the code was properly building the notelist (if you look in the code, you will see that it's calling {{notelist}} which does the correct thing), but not adding it when there were no references to show. this, of course, is a completely sane thing to do since you shouldn't add {{notelist}} if there are no notes. unfortunately, the newly added Module:Sports table/argcheck "observes" input parameters even when they are not used and this creates "ghost references" (see {{killMarkers}} for examples of ghost references). for now, I have added the ability to disable the tracking, but I will work on a more robust solution later. By the way, this is actually related to Module:sports table and not to Module:sports results, but the two modules are closely related, so this is probably as good a place as any to discuss it. Frietjes (talk) 15:21, 26 October 2019 (UTC)Reply
@Frietjes: Thanks for the reply and for your work on the module. If pages related to this do appear in Category:Pages with missing references list, in your opinion, what is the proper action? To add the 'missing' {{notelist}} to the page, to make a change to the module usage on the page, to reach out back here (or Module:sports table), or otherwise? — TheJJJunk (say hello) 15:37, 26 October 2019 (UTC)Reply
User:TheJJJunk, if it's ghost references due to the sports table module being partially transcluded, then I would suggest this change until I have a chance to fix the problem properly. once I have a fix, I will re-enable the tracking. thank you. Frietjes (talk) 13:47, 27 October 2019 (UTC)Reply
@Frietjes: Sounds good, will do. Thanks. — TheJJJunk (say hello) 19:22, 27 October 2019 (UTC)Reply

Possible to hide "(extra match) home team"?

edit

I am the type of person who doesn't like when football articles are without a result table. Since MLS has a strange game schedule (according to me), I had to get creative to solve the problem with the results table (on SVWP). Would it be possible to hide "home matches" for the "extra match X" team? It does not matter if it is not possible, it is better to ask than not to ask.

Example of result table how I solved it, from SVWP (MLS 2015)
Home \ Away CHI COL CLB DAL DCU HOU LAX MON NEW NYC NYR ORL PHI POR RSL SJE SEA SKC TOR VAN EM1 EM2 EM3
Chicago Fire 0–1 0–1 2–0 0–1 3–0 2–2 1–0 3–2 2–3 1–0 1–2 1–0 3–2 0–1 0–1 3–1 1–2
Colorado Rapids 1–2 1–1 1–1 2–1 1–3 0–1 0–2 0–0 1–2 3–1 1–1 1–3 2–1 1–0 1–1 2–1 1–2
Columbus Crew 2–2 0–3 5–0 1–1 1–2 2–1 2–2 1–2 3–0 4–1 1–2 3–2 3–2 2–0 2–1 3–1 3–3
Dallas 0–4 2–1 2–0 2–1 3–0 2–1 0–0 4–1 2–0 1–0 0–0 3–1 3–2 2–0 1–2 4–1 2–1
DC United 3–1 2–0 1–1 1–0 1–0 2–1 2–1 2–2 2–1 2–1 6–4 0–2 1–1 1–2 3–2 1–2 4–0
Houston Dynamo 1–1 0–0 1–0 1–4 3–0 3–0 4–2 0–1 3–1 1–3 0–1 1–1 4–4 2–0 2–1 1–0 3–2
Los Angeles Galaxy 2–0 1–1 3–2 1–1 0–0 5–1 5–1 5–0 1–0 5–2 1–0 2–1 4–0 0–1 1–0 3–1 2–5
Montréal Impact   4–3 3–0 2–1 0–1 3–0 1–2 1–1 2–2 0–1 1–2 4–1 1–0 2–1 2–1 2–0 2–1 2–0
New England Revolution 2–0 0–0 1–1 2–0 2–2 0–0 1–0 2–1 3–0 1–1 4–0 2–1 1–1 1–2 3–1 2–1 0–1
New York City 2–2 1–2 3–1 1–1 3–1 2–0 1–3 5–3 1–1 0–1 3–2 1–3 0–1 4–4 2–3 2–0 1–3
New York Red Bulls 3–2 1–1 2–1 2–0 1–1 2–1 4–1 2–1 2–5 0–2 1–0 2–0 3–0 1–2 2–0 3–0 4–1
Orlando City 1–1 2–0 2–2 0–2 0–1 4–0 2–1 2–2 1–1 0–2 0–0 3–1 0–2 0–1 1–0 5–2 2–1
Philadelphia Union 3–3 0–0 3–0 0–2 1–0 2–0 2–2 1–2 2–1 1–3 1–0 3–0 1–0 0–1 1–2 0–1 1–2
Portland Timbers 1–0 4–1 3–1 1–0 2–0 2–2 2–0 0–2 0–2 0–0 1–0 4–1 0–0 0–0 1–1 2–2 0–1
Real Salt Lake 0–0 2–2 0–1 2–0 0–0 2–0 1–1 3–3 0–1 1–1 2–0 2–1 2–1 0–1 2–1 3–0 0–1
San Jose Earthquakes 2–1 1–0 2–0 0–0 0–2 3–1 1–1 1–1 1–2 0–0 0–1 1–1 1–0 1–0 1–0 1–0 1–1
Seattle Sounders 1–0 3–0 1–0 1–0 1–1 3–0 2–1 4–0 1–0 3–1 2–3 0–0 2–1 0–3 0–2 0–1 2–1
Sporting Kansas City 1–0 2–0 4–0 1–1 2–1 2–1 4–2 1–1 3–2 0–0 0–0 0–5 1–0 4–3 3–1 1–1 0–2
Toronto   3–2 3–1 0–2 0–0 1–2 3–1 1–3 0–2 2–1 4–1 2–1 1–0 3–1 1–3 5–0 2–1 3–1
Vancouver Whitecaps   2–0 2–2 1–0 1–2 3–0 2–0 1–2 3–0 2–1 2–1 3–1 0–2 0–1 1–3 4–0 0–3 0–0

DenSportgladeSkåningen (talk) 10:46, 11 May 2020 (UTC)Reply

DenSportgladeSkåningen, how is that? note that I commented out the large chunk of nulls at the end of your example. Frietjes (talk) 15:28, 11 May 2020 (UTC)Reply
DenSportgladeSkåningen, now updated. on a related note, when we restrict using |highest_pos= and |lowest_pos=, or using |showteam= with |show_limit= it does also restrict the columns, which is a bit strange since not all the matches for that particular team are shown. but, I don't know of a good way to show the missing away matches in that case. Frietjes (talk) 15:41, 11 May 2020 (UTC)Reply
Frietjes That's perfect! Thank you! On svwp we do not use this module very much, we usually use our own result table. But it is nowhere near as practical as this one, after all, both tables have their advantages. DenSportgladeSkåningen (talk) 16:23, 11 May 2020 (UTC)Reply

"Matches with background in a lighter colour were decided after overtime."

edit

Can there be an option for U.S. spelling of "color", or use a different word altogether? Howard the Duck (talk) 13:48, 6 July 2020 (UTC)Reply

Howard the Duck, probably the best thing to do would be to make a proper legend as we do with Module:Sports rbr table#Example 4: Team combined table with a legend. this would avoid describing the colours by name. Frietjes (talk) 16:16, 6 July 2020 (UTC)Reply
I can go with that, as long as people won't customize the hell out of it and have shades for non-important outcomes. I love how simple the current "explanation" is and that you can't edit it. Howard the Duck (talk) 16:36, 6 July 2020 (UTC)Reply
okay, I will work on it, but for now, I adjusted the wording. Frietjes (talk) 17:24, 6 July 2020 (UTC)Reply
BSR tests
Test Main Sandbox
default
Home \ Away AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = home team win; Red = away team win.
Home \ Away AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = home team win; Red = away team win.
OT
Home \ Away AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = home team win; Red = away team win.
Matches with lighter background shading were decided after overtime.
Home \ Away AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = home team win; Red = away team win.
Matches with lighter background shading were decided after overtime.
header
Team AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = left column team win; Red = top row team win.
Team AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = left column team win; Red = top row team win.
OT + header
Team AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = left column team win; Red = top row team win.
Matches with lighter background shading were decided after overtime.
Team AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = left column team win; Red = top row team win.
Matches with lighter background shading were decided after overtime.
FBR tests
Test Main Sandbox
default
Home \ Away AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = home team win; Yellow = draw; Red = away team win.
Home \ Away AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = home team win; Yellow = draw; Red = away team win.
OT
Home \ Away AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = home team win; Yellow = draw; Red = away team win.
Matches with lighter background shading were decided after overtime.
Home \ Away AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = home team win; Yellow = draw; Red = away team win.
Matches with lighter background shading were decided after overtime.
header
Team AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = left column team win; Yellow = draw; Red = top row team win.
Team AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = left column team win; Yellow = draw; Red = top row team win.
OT + header
Team AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = left column team win; Yellow = draw; Red = top row team win.
Matches with lighter background shading were decided after overtime.
Team AAA BBB
A team 114–41
B team 86–99
Source: [citation needed]
Legend: Blue = left column team win; Yellow = draw; Red = top row team win.
Matches with lighter background shading were decided after overtime.

Howard the Duck, above are examples using a standard color legend. I am not sure if the shading difference for OT is obvious enough for this to be useful, which is probably why many pages with OT matches also have an additional OT or * after the score. Frietjes (talk) 18:03, 6 July 2020 (UTC)Reply

Yes, we were using asterisks to denote overtime in Philippine basketball articles (but apparently basketball articles elsewhere never did this until recently), but the old system had darker shades for games that needed OT, since that's not possible in the new system we used lighter shades, still with asterisks, and used blue instead of green. I would prefer just replacing "colour" with "shading" though so we don't have to deal with an actual legend at the bottom, considering we don't use legends such as this in other usages of this module. Howard the Duck (talk) 18:20, 6 July 2020 (UTC)Reply

Remove support for Template:h:title

edit

I just see the converted table in NCAA Season 93 volleyball tournaments#Game results overuses Template:h:title. FWIW, usage of hover text is discouraged per MOS:NOSYMBOLS, unless it is used for abbreviations. – McVahl (talk) 03:03, 7 July 2020 (UTC)Reply

Sports results

edit

Hi, I wanted to use the module (without having the full ranking table) on some individual sports , I have two questions/requests, is it possible to make the Team column left to right? (it doesn't look good using flagIOCathlete template) and also making the column width optional ? the match column width is optional, so I think there is no problem with this too.

  MAS SIN SUR
  Lee Chong Wei (MAS) 2–0 2–0
  Derek Wong (SIN) 0–2 2–1
  Soren Opti (SUR) 0–2 1–2
Source: [citation needed]

Mohsen1248 (talk) 11:58, 6 August 2020 (UTC)Reply

Split table

edit

Hi, I noticed this module is compatible with the split parameter from module:Sports table; however, there is currently no way to make the same effect when using this module alone. Would it be possible to add that parameter to this module too? I believe it would be useful in competitions like the 2021 Major League Soccer season, where teams are divided in conferences and only play a certain amount of matches outside their conference. I also think it would be nice to have an additional vertical split on the corresponding collumn to make the division evident both horizontally and vertically. Here is an example of a sports table with show matches and split2

Pos Team Pld W D L GF GA GD Pts AAA BBB CCC DDD EEE
1 AAA 0 0 0 0 0 0 0 0
2 BBB 0 0 0 0 0 0 0 0
3 CCC 0 0 0 0 0 0 0 0
4 DDD 0 0 0 0 0 0 0 0
5 EEE 0 0 0 0 0 0 0 0
Updated to match(es) played on unknown. Source: [citation needed]

However same behaviour can't be reproduced for this module:

Home \ Away FDT BBB CCC DDD EEE
FDT
BBB
CCC
DDD
EEE
Updated to match(es) played on unknown. Source: [citation needed]

A.Caseiro (talk) 19:46, 28 May 2021 (UTC)Reply

Template-protected edit request on 26 March 2022 - Conflicting notes fix

edit

First Request

edit

Error fix for issues with conflicting notes if 2 legs had different notes for the same 2 teams. Patch is visible on the sandbox page, see the difference there.

You can see the current existing error at 2021–22 West of Scotland Football League (Section 4.3), and a current comparison at User:Aidan9382/SafeEnvironmentTesting (This exact revision for future reference) Aidan9382 (talk) 08:30, 26 March 2022 (UTC)Reply

  Done * Pppery * it has begun... 21:31, 26 March 2022 (UTC)Reply
@Pppery Something bhas gone very wrong, I'm seeing hundred and hundreds of pages with cite errors. LCU ActivelyDisinterested transmission °co-ords° 22:06, 26 March 2022 (UTC)Reply
  Reverted Oddly, it worked and didn't produce a reference error on the example presented here. I'll leave it for Aidan9382 to debug. * Pppery * it has begun... 22:09, 26 March 2022 (UTC)Reply
Huh, sorry about that, it had seemed fine for me. Sorry if that caused any trouble. Ill get working on a second fix and make sure it works fully this time. Thanks. (@ActivelyDisinterested: Sidenote: could you link me one of the articles that gained a citation error? Im testing random articles i can find by putting them under the sandbox version, but im not seeing errors appear) Aidan9382 (talk) 06:28, 27 March 2022 (UTC)Reply
It appeared to be every article using the module (particular those using notes), the number just kept going up. They were being added to the Pages with broken reference names category. Error messages weren't being generated, so I made a dummy edit on 1891–92 Irish League and they appeared (gone now). I could find some more by trawling my browser history LCU ActivelyDisinterested transmission °co-ords° 12:04, 27 March 2022 (UTC)Reply
Sick, that one caused the errors! ill start debugging it, appreciate the help. Aidan9382 (talk) 12:48, 27 March 2022 (UTC)Reply

Second Request

edit

Ive done a fix of the fix - it was an issue with the fact i didnt also fix the referencing of the notes ahead, which means any page which borrowed notes from another match probably had this error (bit stupid on my end, i know). It seems to be foolproof now, so im gonna re-open the request, but feel free to give this one a bit more scrutiny after the last one. The change is once again on the sandbox page. Ive also put it against more than just 1 test case now, see this revision of my test page. Aidan9382 (talk) 13:08, 27 March 2022 (UTC)Reply

  Done. To editors * Pppery *, Aidan9382 and ActivelyDisinterested: in case further testing is needed. P.I. Ellsworth - ed. put'r there 03:05, 11 April 2022 (UTC)Reply
Note on the update: It seems to have worked, ive seen very few pages get filed into Category:Pages with broken reference names, though i am still seeing a small selection of pages getting filed in (E.g. 1942–43 Serie B). Seems to be an issue with cross-referencing a team name note with a match note. Im not sure if the main module needs reverting for this, since about only 8 pages as far as im concerned had this bug, but idk. Im going to look into a fix for it (This one feels like its gonna be hacky to fix). Thanks. Aidan9382 (talk) 05:37, 11 April 2022 (UTC)Reply
Cite errors looks good. The issue with 1942–43 Serie B (& similarly 1934–35 Serie B)), comes from the use of a default note. "note_PAL=" is meant to populate everywhere "note=PAL" is used, instead it's adding a note to "name_PAL". That makes more sense when you're looking at the wikitext. - LCU ActivelyDisinterested transmissions °co-ords° 09:32, 11 April 2022 (UTC)Reply
Yeah i see what you mean. Ive been thinking about how to do a fix for this, but the problem is the way these are connected feels just really scuffed, and im not seeing an elegant fix within this. Ill keep looking, though im not sure im gonna be looking at a solution too soon (especially with the weird connections of team_note, match_note, and note_id, and why all these options exist. I didnt code this originally so im just trynna figure it out on the fly) Aidan9382 (talk) 11:42, 11 April 2022 (UTC)Reply
Good luck. It appears the whole notes section was added after its original creation. So it may be that someone else had to create an inelegant work around, that you're now trying to work around. - LCU ActivelyDisinterested transmissions °co-ords° 13:06, 11 April 2022 (UTC)Reply
I dont want this to lead to a spiralling mess, so i might just try grasp the basic concept and actually recode this, as it feels significantly awkward. Hopefully that shouldnt take me too long to do once i get work started. Thanks for the encouragement. Aidan9382 (talk) 13:10, 11 April 2022 (UTC)Reply
In relation to the new edit request below, i was a bit stupid and didnt realise the bug was caused by an explicit reference of a player note from a match note. My dumbass thought it was automatic for whatever reason. Ive only done slight edits as needed instead, as an elegant fix was actually possible. (Ive also made the notes more clearer incase anyone else comes across them). Aidan9382 (talk) 14:36, 11 April 2022 (UTC)Reply

Template-protected edit request on 11 April 2022 - Bug fix for referencing player note from match note

edit

Since this fix request is about a different subject to the 2 above, im going to put it in a different section. This new edit is related to an issue when a note defined for a player is referenced from a match (See 1934–35 Serie B for an example). The change is on the sandbox page of this module. For an example of the fix in action, check this revision of my testing page. Thanks. Aidan9382 (talk) 14:34, 11 April 2022 (UTC)Reply

  Done. P.I. Ellsworth - ed. put'r there 00:58, 12 April 2022 (UTC)Reply
Appreciate the quick response. Seems to have fixed all the existing issues, not seeing any more now. Aidan9382 (talk) 05:45, 12 April 2022 (UTC)Reply
It's my pleasure! Appreciate your staying on top of this! P.I. Ellsworth - ed. put'r there 05:34, 13 April 2022 (UTC)Reply

Overtime issue

edit

Hi guys, I have been using this table for the BBL Championship but I don't understand why the overtime games are doubling up. How do you fix this issue?

Example is the first Cheshire-Bristol game was decided in overtime, but their second match wasn't in overtime.

Home \ Away BRI CAL CHE LEI LON MAN NEW PLY SHE SUR
Bristol Flyers 71–93 78–73 91–85 75–71 79–78 86–76 87–77 68–55 78–60
89–79 14 Apr 91–84 2 Apr 81–86 81–75 17 Mar 72–76 21 Apr
Caledonia Gladiators 76–88 117–96 89–81 60–84 92–83 81–77 91–76 77–60 88–70
7 Apr 83–78 92–66 23 Apr 2 Apr 28 Mar 96–80 77–71 16 Apr
Cheshire Phoenix 74–81 78–61 91–105 74–89 103–99 80–77 71–78 49–62 90–61
82–87 77–73 23 Apr 65–86 78–74 82–70 101–82 2 Apr 5 Mar
Leicester Riders 91–73 100–67 89–85 75–81 102–89 89–79 28 Mar 71–58 77–72
31 Mar 17 Mar 100–82 77–102 104–84 9 Apr 14 Apr 21 Apr 99–77
London Lions 95–60 95–87 75–60 89–78 91–83 23 Mar 87–63 75–63 88–62
82–64 99–67 89–79 7 Apr 95–71 16 Apr 21 Apr 19 Mar 31 Mar
Manchester Giants 95–103 95–94 104–80 82–89 76–87 99–97 92–79 105–102 106–93
15 Mar 73–91 7 Apr 16 Apr 9 Apr 19 Mar 31 Mar 70–65 97–92
Newcastle Eagles 89–78 94–87 67–75 87–91 72–85 64–84 108–96 84–70 74–79
66–68 14 Apr 31 Mar 92–85 17 Mar 92–97 79–95 7 Apr 79–72
Plymouth City Patriots 70–96 93–85 19 Mar 79–101 79–88 103–96 98–93 69–88 91–68
93–108 9 Apr 16 Apr 2 Apr 51–102 77–87 23 Apr 68–63 90–83
Sheffield Sharks 73–91 70–74 73–88 72–86 73–86 83–92 66–59 64–71 92–74
23 Apr 82–72 9 Apr 27 Jan 87–81 14 Apr 87–62 82–77 17 Mar
Surrey Scorchers 85–93 99–92 81–96 67–86 64–83 85–86 86–88 95–105 54–60
78–73 18 Mar 66–76 81–90 67–88 23 Apr 2 Apr 8 Apr 67–70
Updated to match(es) played on 12 March 2023. Source: BBL.org.uk
Legend: Blue = home team win; Red = away team win.
Matches with lighter background shading were decided after overtime.

Alextigers (talk) 01:14, 13 March 2023 (UTC)Reply

Alextigers Seem like the line result_extra = Args['result_'..team_code_ii..'_'..team_code_jj] or '' would need to insert an actual number to the match. It also seems the documentation of the multirow features is missing. Unfortunately, I don't have the time to work on this. CRwikiCA talk 01:26, 13 March 2023 (UTC)Reply

Template-protected edit request on 12 July 2023

edit

Description of suggested change: "First match(es) will be played on..."

Diff: For future competitions, there is an option to use the |start_date= parameter to list when the first match will take place. While the exact day may often be known, occasionally only the month has been confirmed. However, if only the month and the year are listed in this parameter, the wording becomes awkward, for example: First match(es) will be played on August 2023. Is there any way if only the month and year are listed in this parameter, that the wording is adjusted to "First match(es) will be played in [month] [year]"? Many thanks, Santiago Claudio (talk) 08:18, 12 July 2023 (UTC)Reply

  Completed – should now read "First match(es) will be played: [month] [year]" and will also work for any date format. P.I. Ellsworth , ed. put'er there 00:33, 19 July 2023 (UTC)Reply

Adding different background color to multirowlegs match2, match3 etc.

edit

result_aaa_bbb = will only change the color for the first leg. IncredibleSE (talk) 15:31, 11 August 2023 (UTC)Reply

Edit request 9 March 2024

edit

Description of suggested change: I've tried incorporating the results module into the table at 2024 Six Nations Championship, including the FBR colour scheme to show which team won; however, it's not adding the legend for the colours as it would when the results table is added independently. Can someone please look into this? – PeeJay 16:22, 9 March 2024 (UTC)Reply

  Not done: it's not clear what changes you want to be made. Please mention the specific changes in a "change X to Y" format and provide a reliable source if appropriate. disabling as this request is not yet ready to fly — Martin (MSGJ · talk) 19:26, 18 March 2024 (UTC)Reply

Improved variant with Freeze Columns option

edit

Could this table be improved by adding some optional parameter setting to freeze the first column having team names?

Such an option will be useful in articles like 2023–24_EFL_Championship, 2023–24_EFL_League_One where this template is used.

Currently the team names are not visible when we scroll the table to the right extreme.
Anish Viswa 09:43, 22 April 2024 (UTC)Reply

Edit request 20 September 2024

edit

I edited 2024–25 Indian Super League to fix lint errors, and I noticed that the §Attendances by match table has a legend at the end with actual colors, viz:

Legend:   Highest   Lowest

And in contrast, the §League table second table has a legend at the end where the colors are named but not shown, viz:

Legend: Blue = home team win; Yellow = draw; Red = away team win.

This is so lame.

Description of suggested change:

The legend for the second table, which is generated by Module:Sports results, should show the colors, not name them. —Anomalocaris (talk) 09:16, 20 September 2024 (UTC)Reply

  Not done: please make your requested changes to the module's sandbox first; see WP:TESTCASES. --Ahecht (TALK
PAGE
)
14:55, 27 September 2024 (UTC)Reply

Edit request 8 October 2024

edit

Description of suggested change: Please transfer the Module:Sports results/sandbox code to the live module; it contains fixes to eliminate unnecessary uses of background: transparent as the "default" table cell styling. Setting background: transparent, particularly without setting a foreground text color, leads to invisible text in dark mode. (See mw:Recommendations for night mode compatibility on Wikimedia wikis#Avoid_using_background:_none_or_background:_transparent.)

Viewing the Module:Sports results/testcases wikitext page in dark mode will show that the live module rendering contains a large number of cells with invisible text, whereas the sandbox code renders with all text readable. FeRDNYC (talk) 14:50, 8 October 2024 (UTC)Reply

  Done Thanks FeRDNYC! --Ahecht (TALK
PAGE
)
21:03, 10 October 2024 (UTC)Reply

Possible dark-mode fixes for Module:Sports results/Chess

edit

Along similar lines to my edit request above, I have what I believe are fixes for dark-mode issues with the rendering of Chess match results, specifically (as those are handled specially) in Module:Sports results/Chess/sandbox. The problem is, there's no way I can figure out to test those changes, because that module is a helper that's only called from Module:Sports table, and only when it's loaded in place of Module:Sports results because the outer module was invoked with {{#invoke:Sports table|main|style=Chess| ... }}.

Module:Sports table recognizes the |style= parameter value by exact string equality when choosing the results output module:

local p_matches = match_table and 
    (style_def == 'Chess' and require('Module:Sports results/'..style_def) or require('Module:Sports results'))

So passing |style=Chess/sandbox won't work to activate Module:Sports results/Chess/sandbox in place of the live version — it'll actually cause Module:Sports results to be used instead.

This isn't an edit request, because I have no real way of knowing whether Module:Sports results/Chess/sandbox fixes the dark-mode issues with Module:Sports results/Chess, or even if it works at all, in either skin. I think it does, but I haven't verified it and I'm not really sure how to. Ideas for how the sandbox code can be evaluated vs. the live module, to determine whether it does what it's supposed to, would be very welcome. Right now, these modules are making a mess of things in dark mode. FeRDNYC (talk) 00:58, 9 October 2024 (UTC)Reply

Actually, Module:Sports results/Chess doesn't require an edit request, as it's not protected. And now that I've hacked together a test case for my Module:Sports results/Chess/sandbox code (see Module:Sports table/testcases wikitext#Chess) and confirmed that it fixes the dark-mode issues, I'll make those changes live. FeRDNYC (talk) 06:19, 15 October 2024 (UTC)Reply