Template talk:Detect singular/Archive 1
 | This is an archive of past discussions about Template:Detect singular. Do not edit the contents of this page. If you wish to start a new discussion or revive an old one, please do so on the current talk page. |
| Archive 1 |
Protected edit request on 22 March 2019
 | This edit request to Template:Detect singular has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Please remove the line <noinclude>{{pp-template|small=yes}}</noinclude> - protection templates are automatically handled by the documentation page. Thanks, --DannyS712 (talk) 07:10, 22 March 2019 (UTC)
Done — JJMC89 (T·C) 07:17, 22 March 2019 (UTC)
Protected edit request on 28 June 2021
| | This edit request to Template:Detect singular has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Please copy the changes from Template:Detect singular/sandbox. The changes in the sandbox add a |no_comma= parameter which allows disabling that specific check. The existing testcases at Template:Detect singular/testcases all produce the same results and I've added two new tests with the new parameter which both pass. Gonnym (talk) 09:53, 28 June 2021 (UTC)
- I'm not very keen on semantics of
|no_comma=yesand I note that|no_comma=noproduces possible unexpected results. Have you considered a more explicit|comma=noto exclude commas? — Martin (MSGJ · talk) 14:53, 1 July 2021 (UTC)- @MSGJ I don't really have any strong preference for the name of the parameter. If you want it to be that, I have no problem. (the reason for the name was to eliminate the need to handle a "no" response which would probably use the yesno module and make the code just longer for no real added value) Gonnym (talk) 14:56, 1 July 2021 (UTC)
- Okay, I see what you mean. Well I have strong feelings either. I'll implement now if you update the docs? — Martin (MSGJ · talk) 14:58, 1 July 2021 (UTC)
- Doc updated. Gonnym (talk) 15:07, 1 July 2021 (UTC)
- Okay, I see what you mean. Well I have strong feelings either. I'll implement now if you update the docs? — Martin (MSGJ · talk) 14:58, 1 July 2021 (UTC)
- @MSGJ I don't really have any strong preference for the name of the parameter. If you want it to be that, I have no problem. (the reason for the name was to eliminate the need to handle a "no" response which would probably use the yesno module and make the code just longer for no real added value) Gonnym (talk) 14:56, 1 July 2021 (UTC)
Protected edit request on 18 July 2021
| | This edit request to Template:Detect singular has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Please copy the changes from Template:Detect singular/sandbox. The changes in the sandbox add a |bullets= parameter which allows bulleted lists to be tested. These are used for example in the |guests= parameter of Template:Infobox television episode. The existing testcases at Template:Detect singular/testcases all produce the same results and I've added a new test with the new parameter which passes. Gonnym (talk) 09:25, 18 July 2021 (UTC)
- @MSGJ could you take a look at this? Gonnym (talk) 06:31, 5 August 2021 (UTC)
Done, sorry for the delay. Please document the new feature — Martin (MSGJ · talk) 06:44, 18 August 2021 (UTC)
- Added. Thanks! Gonnym (talk) 08:42, 18 August 2021 (UTC)
- @Gonnym and MSGJ: What could be the cons of the template checking for bullets by default, as it does with commas? Maybe it's worth implementing? --Flipping Switches (talk) 07:57, 18 August 2021 (UTC)
- Seeing as how this template is used over 700k times, there was just too much variables for me to think of. This might be worth making default, but that's one type of research I don't really wish to do. Gonnym (talk) 08:32, 18 August 2021 (UTC)