Template talk:Happy New Year fireworks

There is no actual mention of "2015", so...

...perhaps this template can function as a general "New Year" template. It has seen use by many, so I just thought I should say. Dustin (talk) 22:54, 31 December 2014 (UTC)

Images too big for box

I've posted it to several user's talk pages, and the images still go over the box. Northamerica1000? --AmaryllisGardener ^talk 18:59, 1 January 2015 (UTC)

I have tested it in several browsers, and when the template is substituted everything I've seen has been spot-on, with the images matching the box size just right. Are you using a customized skin or viewing Wikipedia differently than default? NorthAmerica¹⁰⁰⁰ 20:27, 1 January 2015 (UTC)

I'm using Vector on Chrome with Windows 8. I'm in the middle of reviewing a GA right now, but in a little bit I'll try getting a screenshot. --AmaryllisGardener ^talk 20:44, 1 January 2015 (UTC)

@Northamerica1000: See commons:File:Screenshot HNY.png. --AmaryllisGardener ^talk 21:09, 1 January 2015 (UTC)

Well, it's almost certain that the undersizing is due to the skin you're using. When using Chrome or IE and Wikipedia's default interface, the template displays correctly. NorthAmerica¹⁰⁰⁰ 21:11, 1 January 2015 (UTC)

IDK, I'm using the default skin (Vector) and when I open IE and look at it (I'm not logged in on IE), I see the same thing. Weird. --AmaryllisGardener ^talk 21:23, 1 January 2015 (UTC)

I think I misunderstood; I assumed vector was a custom skin...(see Wikipedia:Vector, now I see). NorthAmerica¹⁰⁰⁰ 21:43, 1 January 2015 (UTC)

• Same here. Images hang over on the template page, when testing in a sandbox, and on my talk page. [1] Also makes the next header wonky. It's fixed by the clear template {{-}} czar ⨹ 05:28, 3 January 2015 (UTC)

The present formatting of the template appears to be working correctly for the vast majority of users after it is substituted onto user pages. With the spacing added using {{-}}, after substitution, it creates white space (example link). The addition of spacing to the template page to make it look uniform on the page creates white space errors on user pages when the template is substituted on them. As such, I'd prefer for the template to have a slightly skewed layout on the template page, rather than on hundreds of user pages. NorthAmerica¹⁰⁰⁰ 09:21, 3 January 2015 (UTC)

Added note to usage section

Added:

• Note: After being substituted on user pages, the images render properly, rather than as overextended as they appear on this page.

–NorthAmerica¹⁰⁰⁰ 09:31, 3 January 2015 (UTC)

HTML comment in a Section header and the archiving bot

When the template is subst-ed to a user talk page it generates a section header line with an inline HTML comment, like this:

== Happy New Year, Cassiopeia! ==<!-- From template:Happy New Year fireworks -->

(see Special:Diff/997494399).

However, some users use the ClueBot III for archiving their talk page—and the bot has some problems with parsing and then handling section headers with a comment added. As a result it breakes the talk page structure a bit in the part it did not archive:

= Happy New Year, Cassiopeia! ==<!-- From template:Happy New Year fireworks -->

– it stripped a leading 'equals' character (see Special:Diff/998594996, note the sections' nesting in TOC and appearance of now-superfluous trailing '=' in titles).

I have modified the talk page by splitting vulnerable lines (Two-commit diff), which finally resolved the recurring problem – the subsequent archiving did not break those headers (Special:Diff/998774532).

I've fixed the problem on several users' talk pages manually, but that does not prevent it from recurring. Can we prevent it from re-appearing by separating the HTML comment from the section header line in the template's code? I suppose it needs just moving a closing braces pair from this:

{{SAFESUBST:<noinclude/>#ifeq:{{SAFESUBST:<noinclude/>yesno|{{{heading|yes}}}}}|yes|== Happy New Year, {{SAFESUBST:<noinclude />BASEPAGENAME}}! ==

}}<!-- From template:Happy New Year fireworks -->

to this:

{{SAFESUBST:<noinclude/>#ifeq:{{SAFESUBST:<noinclude/>yesno|{{{heading|yes}}}}}|yes|== Happy New Year, {{SAFESUBST:<noinclude />BASEPAGENAME}}! ==}}

<!-- From template:Happy New Year fireworks -->

At worst, it would add one empty line above the contents inserted. Any comments? --CiaPan (talk) 18:36, 8 January 2021 (UTC)

PS.
Of course, it can be also fixed by appropriate fix in the bot. I have notified the bot team:

User talk:ClueBot Commons/Archives/2021/January#A bug? Bot removed an equal sign from section titles

but it may not happen promptly, and I think simplifying the template code is a good idea anyway. :) CiaPan (talk)