Template talk:Infobox valley

Latest comment: 2 years ago by Trappist the monk in topic native name parameters

Floor elevation

edit

Is the code for "floor elevation" supposed to be commented out? Not like it would work anyway, the documentation says the parameter is named "Floor elevation" while the actual code looks for "Floor Elevation". --Pascal666 21:14, 20 February 2010 (UTC)Reply

template name

edit

Shouldn't this be {{Infobox valley}} instead of {{Infobox Valley}}? --Stepheng3 (talk) 17:52, 17 April 2010 (UTC)Reply

Yes, it should. —hike395 (talk) 18:07, 17 April 2010 (UTC)Reply

Geobox

edit

I have proposed that we delete {{geobox}}. That may effect this templates. You are invited to particiapte in the Geobox deletion dicussion. Andy Mabbett (Pigsonthewing); Talk to Andy; Andy's edits 23:00, 3 January 2012 (UTC)Reply

Request to remove call to Invoke:Coordinates.dms2dec

edit

Hi. I have a minor technical request. I've noticed that some Geographical Infobox templates have been removing calls to Invoke:Coordinates.dms2dec. For example:

I propose a similar removal here. The following pages (as of the 2014-09-03 dump) call Infobox_valley without specifying the lat / long parameters:

Pages calling Template:Infobox_valley without lat / long parameters
Puente_Romano_(Mérida) Mammoth_Hot_Springs Valle_Grana Valle_Germanasca
Forests_of_Mara_and_Mondrem Sawmill_Geyser Valle_dei_Mòcheni Mikea_Forest
Orco_Valley Xiong'er_Volcanic_Belt Cape_Espiritu_Santo Lanzo_Valleys
Cervo_Valley Sessera_Valley Strona_di_Mosso_Valley Maira_Valley
Varaita_Valley Valle_Stura_di_Demonte Chiusella_Valley Puyehue_Hot_Springs

This results in some benign script errors (note they do not show on the page).

In keeping with Infobox_park and Infobox_mountain_range, I believe this template should also remove the lat / long calls. I've modified the sandbox page accordingly. Note that I replaced the Coordinates.dms2dec code with the lat / long block that is used later in the template for Infobox_coord.

Let me know if you need more info. Thanks. gnosygnu 02:32, 23 September 2014 (UTC)Reply

looks good, so done! Frietjes (talk) 13:52, 23 September 2014 (UTC)Reply
Thanks gnosygnu 04:36, 24 September 2014 (UTC)Reply
@Gnosygnu: should probably change template:infobox forest as well? Frietjes (talk) 14:24, 23 September 2014 (UTC)Reply
@Frietjes: Sounds good. I made the same change to the sandbox page there. Let me know if there is anything else (or if I should go ahead and apply). Thanks! gnosygnu 04:36, 24 September 2014 (UTC)Reply
@Gnosygnu: looks good. I would say go ahead and make the changes there as well. Frietjes (talk) 13:59, 24 September 2014 (UTC)Reply
@Frietjes: Cool. Thanks for the confirmation. I realized I never updated the Template_talk:Infobox_forest page, and left a note there now. I'll commit the change sometime on Friday, and leave a final note here when done. Thanks again. gnosygnu 02:50, 25 September 2014 (UTC)Reply
As per the earlier comment, I updated the page now gnosygnu 16:56, 27 September 2014 (UTC)Reply

A few missing parameters

edit

So I'm looking at converting the pages that use {{geobox}} for a valley over to use this template ([1]). I noticed a few params missing and wanted to see if they are worth adding? Population, Density, Timezone and Website are the ones I've spotted. Now it may be that those are just deprecated and don't really belong on a valley... But wanted to check. Anyone have thoughts? --16:32, 19 October 2018 (UTC)

Also missing information about highest and lowest elevations. --Zackmann (Talk to me/What I been doing) 20:14, 19 October 2018 (UTC)Reply
@Zackmann08: Thanks for doing the conversion! The nice thing about {{Infobox valley}} is that it only has parameters that are sensible for a valley. We should be careful about importing parameters from {{Geobox}}, which has the union of all parameters across all geographic regions. Here's what I think:
  • |lowest_elevation= in Geobox is already covered by |elevation=, |elevation_ft=, etc., which are the elevation of the valley floor.
  • |highest_elevation= in Geobox isn't very well-defined. To identify a single highest point, you would need to know the boundary of the valley (because the highest point would probably be on the boundary). Very few valleys have definitions that are verifiable by reliable sources: allowing highest_elevation is just asking for editors to do original research. I would oppose such a parameter.
  • |population= and |population_density= in Geobox seem good: they should be verifiable in sources.
  • |website= and |timezone= don't seem to be important enough information to appear in an infobox for a valley: I would suggest leaving them out.
If you need any help in converting the infoboxes, let me know. I converted geobox mountain range to {{Infobox mountain range}} using AWB a while back. —hike395 (talk) 08:15, 20 October 2018 (UTC)Reply
@Hike395: much appreciated! The fun one is going to be river. I've opened up a TFD here if you'd care to comment! --Zackmann (Talk to me/What I been doing) 08:19, 20 October 2018 (UTC)Reply

Template-protected edit request on 22 March 2019

edit

Please remove the line <noinclude>{{pp-template|small=yes}}</noinclude> - protection templates are automatically handled by the documentation page. Thanks, --DannyS712 (talk) 06:31, 22 March 2019 (UTC)Reply

  Done — JJMC89(T·C) 06:49, 22 March 2019 (UTC)Reply

Font size

edit

It appears that this template uses a slightly bigger font size than generally used for infoboxes. Below image is using custom CSS, with the default sans-serif font the issue might be less noticeable but nonetheless still visible.

File:Temporary image to illustrate an issue with infobox landform.png

It appears that this 'style attribute', which is not present for other infoboxes, overrides the default 88% font-size.

style attribute {
    width: 25em;
    font-size: 95%;
}
.infobox {
    border: 1px solid #a2a9b1;
    border-spacing: 3px;
    background-color: #f8f9fa;
    color: black;
    margin: 0.5em 0 0.5em 1em;
    padding: 0.2em;
    float: right;
    clear: right;
    font-size: 88%;
    line-height: 1.5em;
    width: 22em;
}

This bodystyle property should be empty as it is with other similar templates:

| bodystyle   = line-height: normal; font-size:95%; border-spacing: 2px;

Unless there is a reason for this template not to meet the default style, it would be great if this can be fixed. Pieceofmetalwork (talk) 16:54, 11 July 2021 (UTC)Reply

  Done --- I explicitly set the line-height to be 1.5em, because it's 1.65 on mobile, and 1.5 looks better to me. Other than that, I removed all of the other formatting. — hike395 (talk) 04:08, 12 July 2021 (UTC)Reply

native name parameters

edit

I have started a discussion at Wikipedia talk:WikiProject Infoboxes § native name parameters, you participation would be appreciated.

Trappist the monk (talk) 22:29, 27 December 2021 (UTC)Reply

As a result of the above referenced discussion, I have modified this template and fixed most of the attendant errors. Some errors I have not fixed. Articles with native name errors are listed in Category:Native name checker template errors. In a day or so, I will move on to another infobox template so if you are able to fix the errors listed in the category, now is the time because errors associated with {{infobox valley}} are the only errors listed.
Trappist the monk (talk) 16:05, 7 January 2022 (UTC)Reply
@Trappist the monk: I fixed the remaining errors, thanks for building this infrastructure --- seems easy to use. A couple of suggestions/comments:
  • The checker seems to be confused by references, see, e.g. a previous version of San Juan Valley.
  • Would it make sense to let Infoboxes handle the logic instead of forcing editors to do it? Namely, infoboxes could have parameters |native_name=, |native_name###=, |language_code=, |language_code###= and if only native_name and language_code is used, then the infobox could call {{native_name}}, while if the numbered parameters are used, the infobox could call {{native name list}}. This might be easier for editors. It also has an advantage that if the list is invoked, then the label could be automatically set to Native names. Right now, the infobox doesn't know whether to use singular or plural.
hike395 (talk) 17:48, 7 January 2022 (UTC)Reply
{{native name checker}} expects the value assigned to |native_name= to be wholly wrapped in <div class="plainlist">...</div> markup. In your example, the <ref>...</ref> and {{rp}} are both outside of the markup created by {{native name list}}. It is for this reason that {{native name list}} has |postfixn= so that references (or other important stuff) can be attached directly to a list item. Per WP:INFOBOXREF, your subsequent edit is the preferred solution (though perhaps the non-English text in the lead should be marked up with {{lang}}). But, were it important, one can write:
{{native name list |tag1=es|name1=Canada de San Benito |paren1=omit|tag2=es|name2=Llano De San Juan |postfix2=<ref name=Gudde>{{cite book|last=Gudde|first=Erwin G|title=California Place Names: A Geographical Dictionary|location=Berkeley, California|publisher=University of California Press|year=1949}}</ref>{{rp|290,307}}}}
  • Canada de San Benito
  • Llano De San Juan (Spanish)[1]: 290, 307 
which given to {{native name checker}} is acceptable:
{{native name checker|{{native name list |tag1=es|name1=Canada de San Benito |paren1=omit|tag2=es|name2=Llano De San Juan |postfix2=<ref name=Gudde>{{cite book|last=Gudde|first=Erwin G|title=California Place Names: A Geographical Dictionary|location=Berkeley, California|publisher=University of California Press|year=1949}}</ref>{{rp|290,307}}}}}}
  • Canada de San Benito
  • Llano De San Juan (Spanish)[1]: 290, 307 

References

  1. ^ a b Gudde, Erwin G (1949). California Place Names: A Geographical Dictionary. Berkeley, California: University of California Press.
I thought about doing what you suggest but decided against it because to do so takes away editor flexibility. Bringing the logic into the infobox will constrain what editors can do. As it is now, editors can use any of {{native name}}, {{lang}}, {{lang-??}}, {{transl}}, and for lists, {{native name list}}, {{plainlist}}, {{unbulleted list}}. Certainly, if I am wrong in this assessment, we can revisit.
Trappist the monk (talk) 18:35, 7 January 2022 (UTC)Reply