Template talk:Leave feedback

Latest comment: 3 years ago by Sdkb in topic Unwanted line break in box format

Plainlinks?

edit

Shall we make it a plain link? — Martin (MSGJ · talk) 16:32, 11 November 2009 (UTC)Reply

Made this change to the sandbox now. — Martin (MSGJ · talk) 03:30, 12 November 2009 (UTC)Reply

Stability

edit

Not stable yet? What's the problem? Something about {{urlencode}}? Rd232 talk 02:25, 12 November 2009 (UTC)Reply

Think there are a few issues to be sorted out which we may want to change and which may affect existing uses. So it's better if we sort these out before widely implementing. — Martin (MSGJ · talk) 03:27, 12 November 2009 (UTC)Reply

/feedback

edit

I'm aware that my edit may have changed some existing uses of this template, but I do think that if {{{page}}} is specified, it should define the exact page and not add /feedback automatically. For example, it might be preferred that the feedback comes directly to the talk page rather than a subpage. — Martin (MSGJ · talk) 16:57, 11 November 2009 (UTC)Reply

I've undone myself for now. Still thinking about the best way to do this. — Martin (MSGJ · talk) 17:09, 11 November 2009 (UTC)Reply
I'm thinking on making standard feedback pages as subpages of Wikipedia:Feedback (we can thus document and centralize the practice on that page), the default feedback page for {{{page}}} is then Wikipedia:Feedback/{{{page}}}; and we can also add a feedbackpage parameter to override. Cenarium (talk) 00:46, 12 November 2009 (UTC)Reply
That might be a good idea, although I can see a possible scenario of feedback pages building up without anyone looking at them which would be bad. I think for a lot of low-traffic pages, it might be better just to use the main talk page. — Martin (MSGJ · talk) 03:25, 12 November 2009 (UTC)Reply
Right. Then we should go with no default feedbackpage, or default talk ? Cenarium (talk) 03:46, 12 November 2009 (UTC)Reply
Hmm, I'd be inclined to require the page parameter to be input, i.e. no default. — Martin (MSGJ · talk) 11:50, 12 November 2009 (UTC)Reply

I don't want to use talk pages for this, even on low-traffic pages. There are other ways to ensure feedback is looked at reasonably often, eg Special:RecentChangesLinked/Category:Feedback_pages. Also low-traffic, on Help/Wikipedia pages, doesn't necessarily mean few watchers - so perhaps an additional template placed on the talk page can signal the existence of feedback (ideally with the date of the most recent post...). Rd232 talk 12:00, 12 November 2009 (UTC)Reply

I think you're right that in most cases a /feedback page will be preferable. But I think we should not presume to know what is best for every case, so I think the template should make any page possible. — Martin (MSGJ · talk) 22:31, 12 November 2009 (UTC)Reply
Sure, yes, there may be exceptions. Rd232 talk 22:39, 12 November 2009 (UTC)Reply

Section title

edit

Would be nice to enable custom section links. This would allow pages to have separate sections for feedback on each day. Otherwise you're going to have a million different sections with the same name, which is no good for TOCs. — Martin (MSGJ · talk) 17:15, 11 November 2009 (UTC)Reply

Agree, the template should be as general as possible. We may use feedback pages in a variety of cases. Cenarium (talk) 00:46, 12 November 2009 (UTC)Reply
Ah, I thought you meant something else initially. Sections are now added in the form Feedback ({{date}}) in the sandbox template. I made some other adjustments. Cenarium (talk) 01:58, 12 November 2009 (UTC)Reply
Great. I've thought of another idea ...
==Feedback from {{subst:REVISIONUSER}}==
... would it work? — Martin (MSGJ · talk) 11:49, 12 November 2009 (UTC)Reply
I've found a way to make both working, it'll just leave funny edit summaries. Combining both, I added
Feedback from {{subst:REVISIONUSER}} ({{subst:#time:j F Y}})
url-encoded in the link, and
Feedback from {{REVISIONUSER}} ({{subst:#time:j F Y}})
as default for the box. Cenarium (talk) 01:17, 15 November 2009 (UTC)Reply
edit

Hope you don't mind but I've moved Template:Feedback link to this subtemplate because I think it will be better this way. One reason is that {{{page}}} needs to be pushed through {{FULLPAGENAMEE}} to remove spaces. This would add a lot of extra code on, and would be better passed from the main template. So we could have a "plain" option on the main template does the same thing that {{leave feedback}} did. Also I've merged the two separate talk pages. — Martin (MSGJ · talk) 03:37, 12 November 2009 (UTC)Reply

Feedback editintro and preload

edit

Since we're going to use specific several if not many editintros and preloads, I moved the template:feedback page/editintro and template:feedback page/preload subpages to template:feedback editintro and template:feedback preload; not subpages yet as templates would need simultaneous updating; so that we can see clearly the custom editintros and preloads, and simplify names a bit. Cenarium (talk) 03:52, 12 November 2009 (UTC)Reply

Umm, bit confused. You say you moved the subpages, but then you say "not subpages yet"! — Martin (MSGJ · talk) 22:30, 12 November 2009 (UTC)Reply
The sub-subpages like Template:Feedback page/editintro/Wikipedia:Help desk, because we'd need to update the templates or use transition code then move them. Cenarium (talk) 03:45, 14 November 2009 (UTC)Reply

format parameter

edit

Instead of |link=yes and |section=yes, etc. would it be better to use |format=link and |format=section? This makes it clearer that only one option may be used. — Martin (MSGJ · talk) 11:54, 12 November 2009 (UTC)Reply

I've done this now, and intend to change the existing uses if you guys are happy with it. Cenarium: can I ask what behaviour do you expect on Help:Edit summary where you added {{Leave feedback|coord=yes|section=yes}}? — Martin (MSGJ · talk) 22:29, 12 November 2009 (UTC)Reply
That we see both the section and the coord link, but we can use the template twice anyway if we want, so there's no problem. Cenarium (talk) 03:47, 14 November 2009 (UTC)Reply
Okay, I have changed this syntax now, and also added a |format=box option. — Martin (MSGJ · talk) 16:11, 14 November 2009 (UTC)Reply

Recent changes

edit

I've made recent changes allowing to specify feedback page, put the link in plain or not (default), and changed the root page for preload and editintro as noted above. I've used the template in a few more visible pages, so we should be more careful now. Though it's not necessarily stable enough yet to be widespread used. Cenarium (talk) 03:48, 15 November 2009 (UTC)Reply

edit

Perhaps linking the user's username in the heading would aid people in finding out more information (easily) about those users, as it doesn't appear that they are informed about signing their "feedback." I made a test edit in the sandbox here and it seemed to work fine. Killiondude (talk) 07:27, 11 June 2010 (UTC)Reply

Hidden parameters

edit

These paramenters need to be added to the help:

  • page
  • feedbackpage
  • text
  • plain

Lionel (talk) 11:36, 14 October 2011 (UTC)Reply

Bug in format=box

edit

When "box" is selected the parameters e.g. "text" don't work. This is due to "Please note that variables, templates, parser functions and template parameters are not supported in InputBox parameters" from [1]. To use parameters you have to use #tag:inputbox per [2]. I'm going to fix this. – Lionel (talk) 11:39, 14 October 2011 (UTC)Reply

  DoneLionel (talk) 12:32, 14 October 2011 (UTC)Reply

The subst:REVISIONUSER was removed accidentally, right? Helder 13:26, 14 October 2011 (UTC)Reply
Yea, it was.– Lionel (talk) 18:54, 14 October 2011 (UTC)Reply

Section titles in Feedback page

edit

Can we wikilink the userpage in the automatically generated section title? I.e. the section created on the .../Feedback pages. E.g. "Feedback from Lionelt (14 October 2011)". – Lionel (talk) 10:14, 16 October 2011 (UTC)Reply

Like this? Helder 15:21, 26 October 2011 (UTC)Reply
Yea, that's it. Should it be piped so that "User:" is obscured? – Lionel (talk) 20:34, 26 October 2011 (UTC)Reply

Template-protected edit request on 5 May 2020

edit

Please adopt the sandbox version, which adds a link to the user's page in the preloaded title. {{u|Sdkb}}talk 05:10, 5 May 2020 (UTC)Reply

  Done — Martin (MSGJ · talk) 07:44, 5 May 2020 (UTC)Reply

Unwanted line break in box format

edit

For |format=box, this seems to be inserting an unwanted line break. Does anyone know how we'd fix that? {{u|Sdkb}}talk 05:20, 25 November 2020 (UTC)Reply