Template talk:Marriage

(Redirected from Template talk:Marriage/sandbox2/testcases)
Latest comment: 2 months ago by Pedantical in topic Contributions welcome on Lua Module

Template-protected edit request on 23 October 2023

edit

Context:

I've looked over some past conversations about use of the values 'separated' and 'annulled' being included in the template and abbreviated in a way that is generally understood (in this case, both "sep" and "ann" are commonly used abbreviations in genealogy and relationship records). Adding these two additional "standard" choices will allow for editors to reduce the amount of nested abbreviations into the end parameter (not that it's a bad thing; just common enough usage where it feels appropriate to add into documented usage for editors).


Change to be made:

I have added the necessary lines of text to the switch case to the primary /sandbox page.

You can copy all the contents except the first line reference to the sandbox's Template Styles CSS page.

Thanks!!

Pedantical (talk) 17:07, 23 October 2023 (UTC)Reply

  Done * Pppery * it has begun... 00:10, 27 October 2023 (UTC)Reply
Problem here, which I believe has been discussed before: separation does not end a marriage—only divorce, death, and annulment does. "Separated" should not be included as an option. —Joeyconnick (talk) 19:49, 11 February 2024 (UTC)Reply

Non-breaking spaces causing issues on mobile

edit

The excessive use of "&nbsp" characters is messing up how this template appears on mobile, and causes infoboxes to look weird. For example, see Anya Taylor-Joy on mobile; this template's "&nbsp" usage is causing its text to be aligned further left than it should be. At this point, I'm doing no more than pointing out this issue, but ... I think the resolution here may possibly be to remove all "&nbsp" between the spouse surname and the left bracket of the date range. Steel1943 (talk) 20:54, 3 November 2023 (UTC)Reply

Hey there! Thanks for pointing that out. I’ll see what I can do clean that up. The formatting is something that I’d like to tackle as well, and this lines up nicely with my hope to get the template less dependent on styling where isn’t strictly necessary. Pedantical (talk) 23:53, 3 November 2023 (UTC)Reply
@Pedantical: any update on this? This issue is still there. Another example is Avi Shlaim; his wife's name is misaligned with rest of the infobox entries on the right-hand side. Brusquedandelion (talk) 05:41, 10 April 2024 (UTC)Reply

Error messages with death date?

edit

In the article Joaquín Torres-García, the template listed his spouse as "Manolita Piña (m. 1908, died 1949)". This was in error as she died in 1994, not 1949. I tried to update her death date to 1994 but that resulted in an error message that the date 1994 was after his death date. I then instead tried keeping the 1949 date but replacing the "died" with "his death", but that reached a different error message that "his death" is deprecated and should be replaced by "died"! Obviously using "his death" would be accurate here whilst "died" would imply that his spouse had died in 1949. So then I tried just removing the reason parameter entirely and having the marriage end date be in 1949 with his death, but doing that resulted in the wording "Manolita Piña (1908⁠–⁠1949)", not mentioning that 1908 was the year of marriage at all and thereby implying that his wife had been born in 1908 and died in 1949!

I was left with no choice but to just remove the template completely and manually record that he married his wife in 1908 and she died in 1994. I feel like those two error messages should be removed, as either recording the spouse's death date or that the marriage ended with the subject's death would be accurate ways of conveying the information, but the template as-is gives no good option for using it. Chessrat (talk, contributions) 11:46, 26 January 2024 (UTC)Reply

@Chessrat: This is by design. Note the text, "If the marriage ended with the death of the article's subject, do not provide a date." on the template page. Since the article's subject died first, you do not provide the spouse's death year. They were married at death is the fact that holds. --Engineerchange (talk) 12:14, 26 January 2024 (UTC)Reply
@Engineerchange Aha, thank you. I had noticed the "If the marriage ended due to death of article's subject, do not provide a reason." further up in the description, but did not notice the "do not provide a date" further down. Chessrat (talk, contributions) 13:02, 26 January 2024 (UTC)Reply

Error message

edit

This template seems to generate the red error message "Expression error: Unexpected < operator". – Editør (talk) 11:43, 8 June 2024 (UTC)Reply

@Editør: can you provide an example of this issue occurring? ‑‑Neveselbert (talk · contribs · email) 20:22, 8 June 2024 (UTC)Reply
The issue appears to be resolved. – Editør (talk) 20:47, 8 June 2024 (UTC)Reply

Contributions welcome on Lua Module

edit

I’ve created the very beginnings of a Lua module to use as a drop-in replacement of the existing logic within Template:Marriage and I’ve started up a thread over on Module_talk:Marriage to get a discussion around the implementation going over in that corner.

I’d love any input folks have on the implementation details — the code currently in the module is not reflective of the final module and doesn’t yet match the original Template:Marriage logic exactly yet.

So if you see something that isn’t what you expect, go ahead and add a new test case for what should be expected and create a discussion thread for that particular case.

Please keep the Lua module related discussions over in the Module Talk page and not here under the Template Talk page.

thanks!

Pedantical (talk) 13:08, 16 September 2024 (UTC)Reply