Template talk:Party color cell

Latest comment: 2 years ago by DaxServer in topic Propose to drop pipe (|) at the beginning

Propose to drop pipe (|) at the beginning

edit

The problem I see with the template I see is that it also takes over the table formatting onto itself. More info at Help:Basic table markup.

The current implementation results in

{| class="wikitable"
! Header cell 1
! Header cell 2
|-
{{Party color cell|party name}}                     <!-- No single | at the start -->
| Content cell
|-
| Content cell | {{Party color cell|party name}}    <!-- No double || between table cells -->
|-
| Content cell || Content cell
|}

instead of

{| class="wikitable"
! Header cell 1
! Header cell 2
|-
| {{Party color cell|party name}}                    <!-- Standard table formatting with | at the start -->
| Content cell
|-
| Content cell || {{Party color cell|party name}}    <!-- Standard table formatting with || between table cells -->
|-
| Content cell || Content cell
|}

This forces the editor to remove the table formatting | , which IMHO, shouldn't. Any editor trying to use this will end up with confusion, altho one might dig into the template and understand what's really happening. But in the long run, this results in great deal of maintenance issues and one shall avoid exactly that with a template.

This is a breaking change, and the current usages shall be updated, preferably by a bot. — DaxServer (talk) 16:28, 5 January 2022 (UTC)Reply

Ping @Gonnym from Template talk:NZ parlbox § Changing from text on color (shading) to two cell styleDaxServer (talk) 16:29, 5 January 2022 (UTC)Reply
The family of templates of political parties and election tables is pretty much a wild-west in terms of design. As I wasn't the one who created this template, I do not know what rational was behind this. That said, I do lean in favor of the change (pending any important piece of information that will arise in this discussion). As Dax said, this change will need a bot in order to minimize the amount of time tables will be broken. Gonnym (talk) 16:37, 5 January 2022 (UTC)Reply
@Primefac pinging you in case you have any relevant input and also to ask if this is something your bot can help if the change passes. Gonnym (talk) 10:07, 6 January 2022 (UTC)Reply
I think this rationale is pretty much inscrutable, and I would be happy to lend my bot to the task if there isn't any significant opposition over the next few days. Primefac (talk) 19:50, 6 January 2022 (UTC)Reply
  In progress. Primefac (talk) 16:45, 8 January 2022 (UTC)Reply
  Done. Primefac (talk) 21:10, 8 January 2022 (UTC)Reply
Thanks Primefac! — DaxServer (talk) 22:47, 8 January 2022 (UTC)Reply