User:Davidgothberg/Test51

Floating editnotices

This page shows the problem with right-floating editnotices, and any other right-floating system notices.

To see the problem edit this page and look at the edit preview. If you don't see the preview right away then click [Show preview]. Above the edit preview there is a right-floating editnotice which interferes with the edit preview. Any left-floating box also has this problem.

Also try to do add some text to this page, and then click [Show changes], and you will see some major ugliness in some browsers (at least in Firefox 2.0).

We should of course avoid using right-floating editnotices and system messages. But I have seen this problem on user pages every now and then. And it is so easy for us to harden the preview that we might just as well do it. We have already done the same fix for category pages since it was much needed there.

All we need to do is to change this code in MediaWiki:Common.css:

/* Prevent boxes from overlapping the category listings */
#mw-subcategories, #mw-pages, #mw-category-media {
    clear: both;
}

To this:

/* Prevent floating boxes from overlapping the category listings, 
   the edit previews and the edit [Show changes] view */
#mw-subcategories, #mw-pages, #mw-category-media, 
#wikiPreview, #wikiDiff {
    clear: both;
}

There are other ways we can partially fix this, like hardening the editnotice loader for user pages, but that doesn't fix it for the editnotices and system messages that we admins create. Of course, admins shouldn't do that kind of mistake. But it is anyway much easier for us and more robust to simply harden the preview.

For my own reference, link to the editnotice on this page: MediaWiki:Editnotice-2-Davidgothberg-Test51.

--David Göthberg (talk) 12:21, 27 March 2009 (UTC)