User talk:AzaToth/Archives/2014/June
Latest comment: 10 years ago by APerson in topic Request to be made a contributor on the GitHub twinkle repository
 | This is an archive of past discussions about User:AzaToth. Do not edit the contents of this page. If you wish to start a new discussion or revive an old one, please do so on the current talk page. |
Request to be made a contributor on the GitHub twinkle repository
Hi! I would like to be made a contributor on the GitHub repository for twinkle so I can tag new issues and edit more efficiently without having to go through the pull request system. I've already made one merged pull request. APerson (talk!) 01:45, 24 June 2014 (UTC)
- @This, that and the other and Amalthea: What do you think? →AzaToth 16:23, 24 June 2014 (UTC)
- Hmm. I don't think I've ever seen you contribute to Twinkle before, APerson? At least I can't find anything in the WT:TW archives. To be honest I'd rather see some more complex pull requests from you first: I don't usually test changes before putting them live since currently I know I can rely on and trust all committers (TTTatO in particular), and I'd really like to keep it that way.
But then again I hardly make any meaningful contributions to Twinkle these days so my opinion doesn't really count. :)
Amalthea 18:45, 24 June 2014 (UTC)- APerson hasn't yet made a substantial contribution. I would say the same as Amalthea: "To be honest I'd rather see some more complex pull requests from you first". Hence, I wouldn't support this request right now. APerson, if you're keen, keep at it; there are a lot of open bugs and feature requests that could do with some work, both in the GitHub issue tracker and at WT:TW. Try having a go at fixing some of those and submitting some pull requests. To be a contributor to the repository, you would want to be at the point of submitting pull requests that we can merge straight away, or with only minor stylistic fixes. — This, that and the other (talk) 10:18, 25 June 2014 (UTC)
- Thank you both for your feedback! APerson (talk!) 14:50, 25 June 2014 (UTC)
- APerson hasn't yet made a substantial contribution. I would say the same as Amalthea: "To be honest I'd rather see some more complex pull requests from you first". Hence, I wouldn't support this request right now. APerson, if you're keen, keep at it; there are a lot of open bugs and feature requests that could do with some work, both in the GitHub issue tracker and at WT:TW. Try having a go at fixing some of those and submitting some pull requests. To be a contributor to the repository, you would want to be at the point of submitting pull requests that we can merge straight away, or with only minor stylistic fixes. — This, that and the other (talk) 10:18, 25 June 2014 (UTC)
- Hmm. I don't think I've ever seen you contribute to Twinkle before, APerson? At least I can't find anything in the WT:TW archives. To be honest I'd rather see some more complex pull requests from you first: I don't usually test changes before putting them live since currently I know I can rely on and trust all committers (TTTatO in particular), and I'd really like to keep it that way.