User talk:Novem Linguae/Scripts/GANReviewTool

Not appearing on my ipad

Hello,

First time I tried to use this script which was very useful. It worked fine on Windows Edge but I am just letting you know that it did not show up on Safari on my ipad even though I cleared the cache.

Thanks Chidgk1 (talk) 14:18, 16 January 2023 (UTC)

Works fine for me on Samsung Phone and Chrome. You do need to click the "read as Wiki page" on the bottom for it to show though. Lee Vilenski ^{(talk • contribs)} 14:24, 16 January 2023 (UTC)

I don't own any Apple stuff so I have no way to test and reproduce this one. If others also have problems on Safari, please post in this section so we can gather information. Thanks. –Novem Linguae (talk) 17:04, 16 January 2023 (UTC)

Can I do any more testing? If so what info should I send you? Chidgk1 (talk) 16:24, 17 January 2023 (UTC)

Hmm. One of my theories was that mobile skins such as Minerva were not loading common.js. But I tested that just now and it does load it. What skin are you using? Also, are you getting any WP:CONSOLEERRORs? Also, does it happen on multiple GAN pages or just one? –Novem Linguae (talk) 17:08, 17 January 2023 (UTC)

Vector (2022) but I only have one Wikipedia user-id which I use mostly on ipad nowadays but it is the same user-id on Windows (thus same skin I presume) which worked.

It was not a GAN but a GAR. I have not got another one - is there one somewhere I could test on to check whether there are console errors? Chidgk1 (talk) 06:06, 18 January 2023 (UTC)

Try Wikipedia:Good article reassessment/Edmonton/1 on your ipad and let me know if it doesn't load. Are you logged into your Chidgk1 account on your ipad? –Novem Linguae (talk) 06:10, 18 January 2023 (UTC)

It doesn’t load. Yes logged into Chidgk1 on ipad. I turned on “Web Inspector” but I don’t have a Mac. I am not familiar with javascript. Do you know what console command https://developer.apple.com/library/archive/documentation/AppleApplications/Conceptual/Safari_Developer_Guide/Console/Console.html#//apple_ref/doc/uid/TP40007874-CH6-SW1 I should use to see console errors?

Perhaps easier to try another browser on ipad to narrow down problem? If so which browser would you like me try? Chidgk1 (talk) 06:24, 18 January 2023 (UTC)

Shouldn't need to type anything. Should just open devtools, click on the "console" tab, and then read the messages. I have no idea how to do this stuff on a phone or tablet, but that's how it works on desktop, and I'm guessing it's similar on phone or tablet. Can try googling for "how to open devtools in safari on ipad" or something.

You can try any browser you'd like where you are able to reproduce the issue. But I'd recommend focusing on safari since that is confirmed to have the issue. –Novem Linguae (talk) 07:02, 18 January 2023 (UTC)

I don’t have a Mac so as far as I know I cannot use devtools on my ipad. Safari is no longer maintained for Windows. However as it seems that individual GAR is no longer possible I guess I will just leave the GARs I open for other people to close Chidgk1 (talk) 11:14, 28 March 2023 (UTC)

Didn't load

any ideas why the script didn't load for Talk:Magic: The Gathering rules/GA1? I tried on a few browsers and didn't get anywhere. Lee Vilenski ^{(talk • contribs)} 14:27, 23 March 2023 (UTC)

Bet you it's the colon. CMD (talk) 16:26, 23 March 2023 (UTC)

 Fixed. Yes, it was the colon. Thanks for reporting. –Novem Linguae (talk) 16:46, 23 March 2023 (UTC)

Changes to WP:GA subpage headings

Hey Chipmunkdavis and Epicgenius. Was wondering if you can edit summary ping me in the future when you make changes to the WP:GA subpage headings? Add, delete, rename, change levels? GANReviewTool has them hard coded in its code, and I have to change the code to keep them from throwing errors. Later I will probably write a bot to do this, but for now I will do it manually. –Novem Linguae (talk) 17:09, 23 March 2023 (UTC)

@Novem Linguae, thanks for the heads up. Sorry about that, I did not realize that your script had hard-coded GA subpage headings - in fact, I thought your script automatically detected whether the headers had been changed. Our changes are related to this discussion on my talk page; Chipmunkdavis pointed out that there were so many GAs about buildings in Manhattan that they merited their own subsection, and I agreed. – Epicgenius (talk) 17:43, 23 March 2023 (UTC)

All good! I need to find time to write a bot to run daily and write the current headings to a subpage that is read by GANReviewTool. That would be a good long term fix. I don't think I can have the script itself do it because it'd have to check all 10ish GA subpages each time it loads, which is not efficient. But then again, maybe this isn't such a bad idea... hmm... –Novem Linguae (talk) 19:05, 23 March 2023 (UTC)

Apologies, throughout on various discussions it had never emerged that the level 4-6 subheadings had any interaction with scripts or bots. What exactly does GANReviewTool use them for? CMD (talk) 00:59, 24 March 2023 (UTC)

No worries. The script lets users pick the heading from a combo box when passing an article. What they pick is the subsection it gets added to. –Novem Linguae (talk) 05:05, 24 March 2023 (UTC)

That makes sense, I see the list. There have been a few discussions about the various categorisations amplified by the big GA review process. The New York building split actually came out of a couple of much older discussions noting how stuffed that subsection was and how it was hard to place things, but it wasn't actioned for a long time (probably because it was quite a significant amount of work!). There has also been discussion about oversplitting, and I've made a few tweaks on that end. Among navigation benefits, I see now that it would actually help make it easier to find things in that long dropdown your script creates. If you find time to create something dynamic, let me know, until then if there are changes to be made I'll do it in a batch and provide new code. CMD (talk) 07:29, 24 March 2023 (UTC)

Good plan. Thanks! –Novem Linguae (talk) 08:59, 24 March 2023 (UTC)

I thought of a way to fetch the list every time that only uses 2 API queries.  Fixed. No need to inform me anymore when making changes :) –Novem Linguae (talk) 19:56, 25 March 2023 (UTC)

Error when promoting Gale–Shapley algorithm

Tracked in github.com
Issue #198

I just promoted Gale–Shapley algorithm to GA with the script. Doesn't seem added to the log. It raised an error, and I had to add it to the Wikipedia:Good_articles/Social_sciences_and_society#Economics list manually. Using Firefox on Windows 10. —Femke 🐦 (talk) 19:53, 14 January 2024 (UTC)

@Femke. Happy new year :) Thanks for the report. Do you recall the error code? Was it http? –Novem Linguae (talk) 05:50, 15 January 2024 (UTC)

It think it was yes. Thanks for looking into it :). —Femke 🐦 (talk) 17:16, 15 January 2024 (UTC)

The http error means that there was some kind of Internet connection problem. However this is the most common error type in my GANReviewTool logs. I should probably write a patch that detects that error then retries a bunch of times, so as not to abort the process. Will add to my todo list :) –Novem Linguae (talk) 23:57, 15 January 2024 (UTC)

Possible bug in the GANReviewTool

Tracked in github.com
Issue #209

Just realized per your talk page edit notice I should really post this here, so: see here; it added a status parameter rather than updating the existing one. Mike Christie (talk - contribs - library) 10:47, 6 March 2024 (UTC)

@Mike Christie. Feel free to add a ping. Wish i could ping myself, but it doesn't work. –Novem Linguae (talk) 16:05, 6 March 2024 (UTC)

Novem Linguae: pinging as requested. Mike Christie (talk - contribs - library) 17:00, 6 March 2024 (UTC)

@Mike Christie. This is a nested template bug. The proper fix would involve switching from my custom regexes to the Parsoid API so I can parse wikicode properly without reinventing the wheel. A lot of work, but I'll look into it. –Novem Linguae (talk) 02:32, 29 March 2024 (UTC)

Archive tags

Would it be possible to add "(not required)" to the checkbox that prompts the reviewer whether to place the Archive top/bottom templates when closing out of a review? I think it's helpful to clarify for convenience that it's not part of the GA instructions. czar 22:11, 21 April 2024 (UTC)

I like the current behavior. Talk page watchers, feel free to leave a comment on this if you want. Will change it if there's a consensus. –Novem Linguae (talk) 04:52, 23 April 2024 (UTC)

Feature suggestion

Tracked in github.com
Issue #215

Hello, thank you for creating this script! If you are interested, I think it would be helpful if this script created a userpage and logged all the GANs a user has reviewed (like this). Let me know your thoughts. — GMH Melbourne (talk) 06:05, 30 May 2024 (UTC)

Sure, good idea. I don't have time to work on it, but I made a ticket. –Novem Linguae (talk) 08:18, 30 May 2024 (UTC)

@GMH Melbourne: These stats are already collected by Mike Christie/ChristeBot. See your stats. Is this what you were looking for? Best, CMD (talk) 08:27, 30 May 2024 (UTC)

Log

The sections for the 2024 log suddenly stopped at April for some reason, so all May and June reviews have been placed under that section. I've added sections for May and June. Vacant0 (talk) 12:54, 24 June 2024 (UTC)

@Vacant0. Adding month headings automatically would require 30-60 minutes of coding, and I am lazy, so I have been doing it manually :) Thank you for helping with this. –Novem Linguae (talk) 19:43, 24 June 2024 (UTC)

No problem! Vacant0 (talk) 19:47, 24 June 2024 (UTC)