Wikipedia:Bots/Requests for approval/DannyS712 bot 54
- The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was Approved.
Operator: DannyS712 (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)
Time filed: 18:39, Tuesday, July 30, 2019 (UTC)
Automatic, Supervised, or Manual: automatic
Programming language(s): AWB
Source code available: AWB
Function overview: Fix lint errors in User:Oddbodz's signature that currently exist
Links to relevant discussions (where appropriate): Wikipedia:Village pump (technical)#Signature with unclosed font colours
Edit period(s): One time run
Estimated number of pages affected: <1000
Exclusion compliant (Yes/No): No
Already has a bot flag (Yes/No): Yes
Function details: Replace
[[User:Oddbodz|<font color="0C6E89"><font face=Helvetica>'''Oddbodz'''</font>]] - <small>([[User talk:Oddbodz|<font color="green"><font face=Helvetica>'''Talk'''</font>]]) ([[Special:Contributions/Oddbodz|<font color="orange"><font face=Helvetica>'''Contribs'''</font>]])</small><font color="black">
with
[[User:Oddbodz|<font color="0C6E89"><font face=Helvetica>'''Oddbodz'''</font></font>]] - <small>([[User talk:Oddbodz|<font color="green"><font face=Helvetica>'''Talk'''</font></font>]]) ([[Special:Contributions/Oddbodz|<font color="orange"><font face=Helvetica>'''Contribs'''</font></font>]])</small>
to fix the lint errors
Discussion
edit- Pining @Xaosflux, DuncanHill, Pppery, and Oddbodz who were part of the linked discussion (or the user whose signature is being fixed) --DannyS712 (talk) 18:41, 30 July 2019 (UTC)[reply]
- Since you have to touch it anyway, can you make it any smaller (e.g. combine elements?) — xaosflux Talk 18:43, 30 July 2019 (UTC)[reply]
- The font elements could probably be combined, or even replaced with spans since the tag is depreciated, but since the user is inactive and thus hasn't commented, I wanted to be as unobtrusive and make as small edits as possible, since this is another user's signature DannyS712 (talk) 18:47, 30 July 2019 (UTC)[reply]
- Can you check that new change doesn't maintain or create any new lint errors (e.g. mistnested tags) - rather not see this get touched twice. — xaosflux Talk 19:19, 30 July 2019 (UTC)[reply]
- @Xaosflux: do you mean elsewhere on the page or within the signature? Either way, the use of
font
results in an "Obsolete HTML tags" lint error, but otherwise this shouldn't cause any issues DannyS712 (talk) 19:22, 30 July 2019 (UTC)[reply]- Plus, there are already 11 million obsolete HTML tag errors, so that doesn't seem to be a big concern DannyS712 (talk) 19:26, 30 July 2019 (UTC)[reply]
- I just meant in this snippet - mostly that a new linter error won't be introduced - that obsolete html tags one - not touching it :D — xaosflux Talk 19:38, 30 July 2019 (UTC)\[reply]
- Plus, there are already 11 million obsolete HTML tag errors, so that doesn't seem to be a big concern DannyS712 (talk) 19:26, 30 July 2019 (UTC)[reply]
- @Xaosflux: do you mean elsewhere on the page or within the signature? Either way, the use of
- Can you check that new change doesn't maintain or create any new lint errors (e.g. mistnested tags) - rather not see this get touched twice. — xaosflux Talk 19:19, 30 July 2019 (UTC)[reply]
- The font elements could probably be combined, or even replaced with spans since the tag is depreciated, but since the user is inactive and thus hasn't commented, I wanted to be as unobtrusive and make as small edits as possible, since this is another user's signature DannyS712 (talk) 18:47, 30 July 2019 (UTC)[reply]
- Since you have to touch it anyway, can you make it any smaller (e.g. combine elements?) — xaosflux Talk 18:43, 30 July 2019 (UTC)[reply]
- Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. — xaosflux Talk 19:38, 30 July 2019 (UTC)[reply]
- Be sure to mark "minor" to prevent the newtalk trigger in user_talk: ns. — xaosflux Talk 19:38, 30 July 2019 (UTC)[reply]
- @Xaosflux: Trial complete. - 50 edits made (all marked as minor, thanks for the reminder). I checked the first few manually, and verified each edit on AWB, and didn't see any issues. Thanks, --DannyS712 (talk) 21:26, 30 July 2019 (UTC)[reply]
- Actually 1 issue I found: typo in the summary, I wrote "is" instead of "in" - will correct for the rest of the edits DannyS712 (talk) 21:26, 30 July 2019 (UTC)[reply]
- @Xaosflux: Trial complete. - 50 edits made (all marked as minor, thanks for the reminder). I checked the first few manually, and verified each edit on AWB, and didn't see any issues. Thanks, --DannyS712 (talk) 21:26, 30 July 2019 (UTC)[reply]
- Be sure to mark "minor" to prevent the newtalk trigger in user_talk: ns. — xaosflux Talk 19:38, 30 July 2019 (UTC)[reply]
- Approved. task approved for one time run. — xaosflux Talk 13:00, 7 August 2019 (UTC)[reply]
- The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.