Wikipedia:Bots/Requests for approval/MusikBot 2

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was

Approved.

MusikBot 2

Operator: MusikAnimal (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 16:35, Tuesday, July 7, 2015 (UTC)

Automatic, Supervised, or Manual: Automatic

Programming language(s): Ruby

Source code available: GitHub

Function overview: Takes over the archiving task of WP:PERM pages, previously the responsibility of KingpinBot. Bot operator Kingpin13 is aware and in support of this as are the regular PERM admins

Links to relevant discussions (where appropriate): [1]

Edit period(s): Continuous

Estimated number of pages affected: 8, and most likely to be 9 (if we merge in mass message sender into PERM)

Exclusion compliant (Yes/No): No

Already has a bot flag (Yes/No): Yes

Function details: MusikBot has for a while been clerking the PERM pages, and that trial is now complete and awaiting review (see Wikipedia:Bots/Requests for approval/MusikBot). In the meantime I have developed the archiving task to be bundled in with the other tasks. Every task is mutually exclusive to others, and can be turned off/on as needed. The bot already scrapes the pages every 10 minutes so it will archive on-the-fly, rather than once daily as KingpinBot did. The logic is otherwise exactly the same, just implemented differently. Some additions:

The edit summary will state how many open requests there are left, or will say "list is clear"
Updates the {{admin backlog}} to {{no admin backlog}} or vice versa, as needed
Comments when a request has been marked as {{done}} but the user does not have the said permission

This new archiving task is badly needed... KingpinBot (all due respect to the operator) has been increasingly less reliable. Currently we are quite backed up — MusikAnimal ^talk 16:35, 7 July 2015 (UTC)[reply]

((BAGAssistanceNeeded)) Requesting immediate attention as the requests for permission pages badly need to be archived. Patrolling admins are finding it difficult to pick out open remaining requests ([2]). During this first run I can run the script locally, stepping through the code, to ensure nothing goes awry given how many requests there are — MusikAnimal ^talk 20:53, 7 July 2015 (UTC)[reply]

Discussion

Approved for trial (7 days). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Magioladitis (talk) 22:54, 7 July 2015 (UTC)[reply]

Trial complete. Alright! After 7 days, I think I'm convinced the bot is stable except for the AWB registration page. That did work but then I realized I wasn't archiving bot requests (although there haven't been any). The AWB page requires special handling as it is structured vastly different from the other PERM pages. I have it fully working on testwiki, I believe, but I'll need an extended trail to prove it works in production.

As for the other PERM pages, they've been spot-on. When I first ran the script all the pages were backed up, so I manually ran it page by page. I saw that when a level 2 heading was not on its own line, the bot malfunctioned (skipped several requests). I think most bots would have too, actually... as it's the headings that makes it possible to parse the page request by request. To rememdy this for MusikBot, I implemented an initial check that would report the error, and it will refrain from attempting to process the page until the error is fixed. The report shows exactly what line caused the error. Here's an example on testwiki: [3] I don't want to have the bot automatically fix the error as this scenario may come about when the page structure has been tampered with, and the bot could potentially make matters worse, so it will instead wait for a human to fix it.

Anyway, aside from that little mishap we've had no issues for the core PERM pages. Here's some diffs:

Rollback: [4][5]
Pending changes reviewer: [6][7]

To reduce edit count and server strain, the bot consolidates edits to archive pages when applicable: [8]

Diffs showing how the bot updates the {{admin backlog}} template: [9][10]

Let me know if you have any questions. Again, if you feel it is necessary, please allow for an extended trial to exemplify handling of the AWB registration page. Thanks! — MusikAnimal ^talk 21:52, 14 July 2015 (UTC)[reply]

Approved for extended trial (10 days). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Let's run the bot for another 10 days! -- Magioladitis (talk) 08:51, 15 July 2015 (UTC)[reply]

Trial complete. Alright! As aforementioned, the bot only had issues archiving the request for AWB access page, since it is formatted very differently from the other PERM pages. I'm happy to report it's now working as intended, and there have been no issues during the extended trial. Diffs: [11][12][13]. Notice how the bot handles other tasks in the same edit. Finally, there have been no AWB bot requests so I can't show you a diff of MusikBot archiving such a request in production, but its ability to handle this scenario can be demonstrated on testwiki here. All in all I think I can definitively say the bot is stable. — MusikAnimal ^talk 18:36, 25 July 2015 (UTC)[reply]

Approved. ·addshore· ^{talk to me!} 12:48, 28 July 2015 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.