Wikipedia:Bots/Requests for approval/PkbwcgsBot 18
- The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was Approved.
Operator: Pkbwcgs (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)
Time filed: 20:57, Monday, December 31, 2018 (UTC)
Function overview: The bot will fix middle priority lint error "Misnested tags"
Automatic, Supervised, or Manual: Automatic
Programming language(s): WPCleaner
Source code available: WPCleaner
Links to relevant discussions (where appropriate):
Edit period(s): Twice a week
Estimated number of pages affected: Over 1.5 million but 500 will be done per run
Namespace(s): All namespaces
Exclusion compliant (Yes/No): No because lint error fixing is uncontroversial and will not cause any problems.
Function details: The bot is going to fix middle-priority lint error misnested tags. It will move the incorrectly nested tag to the correct location. An example is shown below:
<font face="cursive">[[User:Example</font>]]
will become:
<font face="cursive">[[User:Example]]</font>
Discussion
edit- @Pkbwcgs: if you want to run a linter cleanup on 1.5 million pages, you will need to be a bit more specific about your conditions, do you have a list of conditions you will be targeting? Also, if making over a million edits for linter purposes you really shouldn't be leaving other linter errors behind unless there is a priority reason (e.g. in you example below, you are leaving the deprecated font tag in place instead of also fixing it). — xaosflux Talk 21:06, 31 December 2018 (UTC)[reply]
- @Xaosflux: I am not planning to do a million edits at all. It is only 1,000 edits a week (500 per session). I got another task in the running which is task 17 and that fixing "Tidy bug affecting font tags wrapping links" lint error. When I target "Misnested tags", I will also add in "Tidy bug affecting font tags wrapping links" and "Missing end tag" so that it can fixed if found as well in the edit without leaving it behind. That's what I did in this edit. Pkbwcgs (talk) 21:17, 31 December 2018 (UTC)[reply]
- Am I interpreting your statement correctly that you are essentially running multiple bot runs at the same time, so you could in theory trigger tasks 17, 18, and 13 all on one page (in one edit)? Will the order matter? For example, Xaosflux mentioned the fact that you're fixing the "order" issue without fixing the "font" issue - will it matter if it gets fixed in that order or "font" then "order"? Primefac (talk) 18:28, 2 January 2019 (UTC)[reply]
- @Primefac: Well, task 17 will run on pages that contain "Tidy bug affecting font tags wrapping links" but if there is "Misnested tags" or "Missing end tag", it will also fix those two errors on the same page. Task 18 is "Misnested tags" but if the page contains "Tidy bug affecting font tags wrapping links" or "Missing end tag" then it will also fix those on the same page. Task 13 is a completely different task and is not linked with lint errors. Pkbwcgs (talk) 19:11, 2 January 2019 (UTC)[reply]
- Am I interpreting your statement correctly that you are essentially running multiple bot runs at the same time, so you could in theory trigger tasks 17, 18, and 13 all on one page (in one edit)? Will the order matter? For example, Xaosflux mentioned the fact that you're fixing the "order" issue without fixing the "font" issue - will it matter if it gets fixed in that order or "font" then "order"? Primefac (talk) 18:28, 2 January 2019 (UTC)[reply]
- @Xaosflux: I am not planning to do a million edits at all. It is only 1,000 edits a week (500 per session). I got another task in the running which is task 17 and that fixing "Tidy bug affecting font tags wrapping links" lint error. When I target "Misnested tags", I will also add in "Tidy bug affecting font tags wrapping links" and "Missing end tag" so that it can fixed if found as well in the edit without leaving it behind. That's what I did in this edit. Pkbwcgs (talk) 21:17, 31 December 2018 (UTC)[reply]
- Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Primefac (talk) 00:04, 14 January 2019 (UTC)[reply]
- @Primefac: Trial complete. I have followed exactly what I have said and fixed any extra lint errors that are left on the talk page as well as "misnested tags" so that there are no more lint errors on the talk page. My edits are located here. Pkbwcgs (talk) 16:34, 14 January 2019 (UTC)[reply]
- {{BAGAssistanceNeeded}} It has been two weeks since the trial was completed. Pkbwcgs (talk) 18:44, 28 January 2019 (UTC)[reply]
- @Primefac: Trial complete. I have followed exactly what I have said and fixed any extra lint errors that are left on the talk page as well as "misnested tags" so that there are no more lint errors on the talk page. My edits are located here. Pkbwcgs (talk) 16:34, 14 January 2019 (UTC)[reply]
- Approved. Sorry for the delay. --TheSandDoctor Talk 18:17, 29 January 2019 (UTC)[reply]
- The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.