Wikipedia:Bots/Requests for approval/PkbwcgsBot 23

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was

Approved.

PkbwcgsBot 23

Operator: Pkbwcgs (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 18:18, Monday, January 28, 2019 (UTC)

Function overview: The bot will fix pages with Template:RomanianSoccer with deprecated parameters. The pages with deprecated parameters are located at Category:RomanianSoccer template with deprecated parameters.

Automatic, Supervised, or Manual: Supervised

Programming language(s): AWB

Source code available: AWB

Links to relevant discussions (where appropriate):

Edit period(s): One-time run

Estimated number of pages affected: 739

Namespace(s): Mainspace

Exclusion compliant (Yes/No): Yes

Function details: The bot will fix deprecated parameters in Template:RomanianSoccer. An example edit is located here. The bot is going to change the old_id parameter to id if id is not defined in the template. For example, * {{RomanianSoccer|old_id=a/achim_sebastian}} is wrong because old_id has no accompanying id parameter. This was change in my later edit to * {{RomanianSoccer|id=a/achim_sebastian}} which is correct. It is quite clear at Template:RomanianSoccer's documentation "The "old_id" parameter may contain an ID such as a/augustin_ionel, which is the ID portion of http://www.romaniansoccer.ro/players/a/augustin_ionel.shtml or http://www.statisticsfootball.com/players/a/augustin_ionel.shtml. This parameter is optional if the "id" parameter (or unnamed parameter "1") is used." Update: The "a/" before the name of the player with change to "97/" in the template as stated at Template:RomanianSoccer#Examples and the name will be reversed so "achim_sebastian" will become "sebastian-achim" so this task will also update the links. However, there may need to be some regex to have those changes.

Discussion

I got the URL updates wrong so I will stick with fixing the deprecated parameters. Pkbwcgs (talk) 18:43, 28 January 2019 (UTC)[reply]

Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete.. Pkbwcgs, please link to this BRFA in the edit summaries. This was actually a task that I was thinking of taking on with DFB a couple months ago but ultimately did not have the time, so I thank you for taking this on. --TheSandDoctor ^Talk 06:11, 29 January 2019 (UTC)[reply]

{{OperatorAssistanceNeeded}} was the trial completed? — xaosflux ^Talk 18:50, 12 March 2019 (UTC)[reply]

@Xaosflux: Not yet. I will go forward with the trial soon. Pkbwcgs (talk) 19:05, 12 March 2019 (UTC)[reply]

Trial complete. The edits are here. The trial went well and correctly. Pkbwcgs (talk) 08:42, 12 April 2019 (UTC)[reply]

Approved. task approved. — xaosflux ^Talk 15:13, 14 April 2019 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.