Wikipedia:Bots/Requests for approval/Redirectbot

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was

Denied.

Redirectbot

Operator: Philroc (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 21:54, Wednesday, October 21, 2015 (UTC)

Automatic, Supervised, or Manual: Automatic

Programming language(s): C#

Source code available: http://www.mediafire.com/view/jxpgd7ha5h2fq50/Redirectbot.cs

Function overview: Redirects to lists, from the thins they are lists of

Links to relevant discussions (where appropriate): Wikipedia:Bot requests#Redirects to lists, from the things they are lists of

Edit period(s): Continuous

Estimated number of pages affected: ~13000

Exclusion compliant (Yes/No):No

Already has a bot flag (Yes/No): No

Function details: Breakdown of this bot's task: 1. The bot will look through Special:AllPages for articles titled "List of *" 2. When it finds an article, it will check to see if an article which is named what is in the wildcard exists 3a. If it does exist, the bot will do nothing. 3b. If it doesn't exist, the bot will create it with the text "#REDIRECT [[(name of list)]]" 4. Repeat

And you don't need exclusion compliance when you're just making redirects.

Discussion

Thanks for working on this.

There was a bit of discussion on Wikipedia:Bots/Requests for approval/MoohanBOT 8 about excluding certain types of articles that start with "List of", like List of arcade video games: O. Since you're just going through Special:AllPages, we don't have an easy way to do that. I suggest creating a separate list (possibly based on the list from the previous BRFA?) and working from that instead.

At the very least, the bot should be adding {{R from list topic}} to the pages it creates. I'm not sure I agree with adding {{R with possibilities}} or a special category as mentioned in the previous BRFA. Also, you may wish to use {{redr}} as a wrapper. Dunno if that matters.

A couple other possible issues, based on reviewing the code:

if (title.Contains("List of") {
This will trigger for a page like European List of Notified Chemical Substances, which probably isn't what you had in mind.
if (pagetemp[1] != 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 0) {
I don't think this check is necessary. I don't know C#, but I assume foo.ToUpper == foo if foo is a number. Also, you probably should be changing the case of pagetemp[0] instead; pagetemp[1] is the second character.

Thanks. — Earwig ^talk 23:27, 21 October 2015 (UTC)[reply]

Grrr, guess I'll just have to use regexes :( And no, foo.ToUpper does not equal foo. Phil roc^{My contribs} 23:39, 21 October 2015 (UTC)[reply]

According to http://www.dotnetperls.com/toupper, shouldn't it? — Earwig ^talk 23:43, 21 October 2015 (UTC)[reply]

You revealed your bot's password publicly. Don't do that. I changed it and sent you an email. — Earwig ^talk 23:41, 21 October 2015 (UTC)[reply]

@The Earwig: I have made a regex that combats both words before "List of" and singleton letters, will put the new source up in the afternoon. Phil roc^{My contribs} 12:19, 22 October 2015 (UTC)[reply]

WAIT, NO I HAVEN'T :_( Phil roc^{My contribs} 12:21, 22 October 2015 (UTC)[reply]

OK, now I have. Whew! As I said, will put the new source up in the afternoon. Phil roc^{My contribs} 12:29, 22 October 2015 (UTC)[reply]

@The Earwig: The new source is up, check the source code link again. Redirectbot (talk) 20:46, 22 October 2015 (UTC)[reply]

@The Earwig: Wait, i'm logged in as my bot. As said before, the source is up, check the source code page again. Phil roc^{My contribs} 20:50, 22 October 2015 (UTC)[reply]

(←) Denied. Look, I was giving you the benefit of the doubt earlier, but since you have (1) posted the bot's password online publicly again after I told you not to, (2) disregarded my clear instruction in the email to Please change [your bot's password now that I have access to it], and (3) somehow don't see a problem with any of this, I have lost my confidence that you will operate this bot responsibly. No judgement regarding the task itself or you as an editor. Please reevaluate your account security practices. — Earwig ^talk 22:59, 22 October 2015 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.