Wikipedia:Bots/Requests for approval/WOSlinkerBot 22

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at Wikipedia:Bots/Noticeboard. The result of the discussion was

Approved.

WOSlinkerBot 22

New to bots on Wikipedia? Read these primers!

Approval process – How this discussion works
Overview/Policy – What bots are/What they can (or can't) do
Dictionary – Explains bot-related jargon

Operator: WOSlinker (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 16:41, Wednesday, March 30, 2022 (UTC)

Function overview: Fix pages with the Old behaviour of link-wrapping font tags lint issue.

Automatic, Supervised, or Manual: Automatic

Programming language(s): Javascript

Source code available: At User:WOSlinkerBot/linttask22.js

Links to relevant discussions (where appropriate):

Edit period(s): one time run

Estimated number of pages affected: currently 90,000 of those lint errors, but multiple errors per page so guessing about 30,000

Namespace(s): wikipedia & talk pages

Exclusion compliant (Yes/No): No

Function details: Similar to previous tasks, such as task 21, fixing lint issues. This task will be fxing the Old behaviour of link-wrapping font tags lint issues. While fixing though pages, some additions will be made to the javascript code as additional combinations of the font tag and wikilinks are found.

Discussion

Shouldn't this actually be a supervised task? There are lots of different cases involved that would make it difficult as an automatic task. I tested User:WOSlinkerBot/linttask22.js against a variety of cases here. It had one false positive of replacing <font color="#AFFFF">[[User:abc|abc]]</font> with [[User:abc|<span style="color:#AFFFF;">abc</span>]]. You can add more regexes to catch the ones it skipped. ಮಲ್ನಾಡಾಚ್ ಕೊಂಕ್ಣೊ (talk) 18:41, 30 March 2022 (UTC)[reply]

I support this task, of course, but I think Malnadach is correct. I think instead of \#[a-f0-9]*, the bot op may need to specify only three or six characters in the font color. It should probably skip any other number of characters. I also recommend a supervised task with inspection, or at least starting with known signatures, as collected here. – Jonesey95 (talk) 19:27, 30 March 2022 (UTC)[reply]

I've changed the \#[a-f0-9]* to 3 and 6 fixed length versions. -- WOSlinker (talk) 21:47, 30 March 2022 (UTC)[reply]

Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Primefac (talk) 13:20, 23 April 2022 (UTC)[reply]

Trial complete. 50 edits here. -- WOSlinker (talk) 20:00, 27 April 2022 (UTC)[reply]

Approved. Primefac (talk) 15:01, 7 May 2022 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at Wikipedia:Bots/Noticeboard.