Wikipedia:Bots/Requests for approval/WikiCleanerBot 4

The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was

Approved.

WikiCleanerBot 4

Operator: NicoV (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 10:09, Thursday, May 9, 2019 (UTC)

Function overview: To fix some extra pipe characters inside external links

Automatic, Supervised, or Manual: Automatic, except for the first launch which will be supervised

Programming language(s): Java (Wikipedia:WPCleaner)

Source code available: On Github (and especially algorithm 543)

Links to relevant discussions (where appropriate): Wikipedia:Bots/Requests for approval/WikiCleanerBot 3

Edit period(s): Twice a month, after the dump analysis that I already perform, see Wikipedia:Bots/Requests for approval/WikiCleanerBot.

Estimated number of pages affected: Around 1000 (max estimation) for the first complete run (pages with such problems are listed in Wikipedia:CHECKWIKI/WPC 543 dump‎, which currently contains a list of 940 pages), and probably no more than a few dozen after that on each run.

Namespace(s): Main namespace

Exclusion compliant (Yes/No): No, no obvious need (unless trial and run shows that it's necessary)

Function details: Following discussion on Wikipedia:Bots/Requests for approval/WikiCleanerBot 3, I've added a check in WPCleaner to report problems with pipes inside external links (like [https://www.sports-reference.com/cfb/schools/virginia-military-institute/1918.html| VMI] with the extra pipe after .html) in Wikipedia:CHECKWIKI/WPC 543 dump‎, and developed code to automatically fix the most simple cases (pipe at the end of the external link target). I ran this automatic fixing on frwiki, this diff gives a good idea of what could be fixed for obvious errors (on frwiki, it went down from 1302 pages to 56).

The function will analyze each page in Wikipedia:CHECKWIKI/WPC 543 dump‎ (updated after each dump analysis by WPCleaner), and fix the simple cases (first version will only fix trailing pipe, and I don't know yet if I will try to develop other cases).

Discussion

{{BAG assistance needed}} Any feedback on this request? As this task already ran on frwiki, I'm pretty confident it should work directly (or with minor tweaking) on enwiki. --NicoV ^{(Talk on frwiki)} 09:44, 22 May 2019 (UTC)[reply]

Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Primefac (talk) 23:16, 23 May 2019 (UTC)[reply]
- Thank you Primefac. Trial complete. The 50 edits can be found here, I saw no problems. --NicoV ^{(Talk on frwiki)} 08:37, 24 May 2019 (UTC)[reply]
Approved. edits looked good, is not cosmetic as it changes link usability for readers. — xaosflux ^Talk 04:49, 27 May 2019 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.