Orphaned caption problem

edit

There's a problem when {Div col} contains a [File:...] item providing a caption (as is usual) that I noticed in this article version (since worked around). At certain window sizes (in Chrome at least) the caption gets separated from the image itself. In the two-column version of that page (using "|right" placement), the caption can be widely separated from the image by intervening text flowing to the left of the caption and the right of the image. There are workarounds, but an editor has to know that the problem could occur even if their window width doesn't happen to show any problem. So, it seems like at a minimum the documentation for this template should call out the problem and potential solutions, or, better, the software should automatically avoid this problem with the [File:...] mechanism, either inside that mechanism or in this template mechanism. - R. S. Shaw (talk) 21:45, 17 June 2024 (UTC)Reply

I am able to reproduce this display problem in Brave for Mac (Vector 2022, desktop view). This bug was reported in 2018 as T193163, and it appears to be a bug in Chromium. I have added a note to the documentation. – Jonesey95 (talk) 22:15, 17 June 2024 (UTC)Reply

Should take "width" and not just "colwidth"

edit
<includeonly><templatestyles src="Div col/styles.css"/><!--
--><div class="div-col {{#ifeq:{{{small|}}}|yes|div-col-small}} {{#ifeq:{{{rules|}}}|yes|div-col-rules}} {{{class|}}}" <!--
-->{{#if:{{{colwidth|{{{width|}}}}}}{{{gap|}}}{{{style|}}}|<!--
-->style="{{#if:{{{colwidth|{{{width|}}}}}}|column-width: {{{colwidth|{{{width}}}}}};}}{{#if:{{{gap|}}}|column-gap: {{{gap}}};}}{{#if:{{{style|}}}|{{{style}}}}}"<!--
-->}}><!--
-->{{#if:{{{content|}}}|{{{content}}}</div>}}<!-- Inventory how many pages use small=yes 
-->{{#ifeq:{{{small|}}}|yes|[[Category:Pages using div col with small parameter]]}}<!--
--></includeonly>{{#invoke:Check for unknown parameters|check|unknown={{main other|[[Category:Pages using div col with unknown parameters|_VALUE_{{PAGENAME}}]]}}|preview=Page using [[Template:Div col]] with unknown parameter "_VALUE_"; use colwidth= to specify column size |ignoreblank=y | class | colwidth | content | gap | rules | small | style }}<noinclude>
{{Documentation}}
</noinclude>

See what I did? There's a {{{width|}}} in this version so that it can work with that param or "colwidth". This shouldn't break anything, but seeing as this is on 400,000 pages I want to run this by someone else for a sanity check first. Is this going to bust anything? jp×g🗯️ 21:02, 7 July 2024 (UTC)Reply

I think you also need to add width as an option for the "Check for unknown parameters" part as well. -- WOSlinker (talk) 21:36, 7 July 2024 (UTC)Reply
With any widely used template it is usually wise to put new code into the /sandbox version of the template and then create a few test cases on the /testcases page to show that it works without breaking anything. Something as simple as a missing or extra pipe character is easy to put into suggested code, but it will turn up problems on a well constructed testcases page. – Jonesey95 (talk) 00:48, 8 July 2024 (UTC)Reply
Well, the change is trivial, so I guess you're asking if you have consensus for it...? I'm not in favor of adding aliases for parameters in templates already widely used as this parameter is. Izno (talk) 11:09, 12 July 2024 (UTC)Reply
And actually, a better reason not to use that name is that one might want in some future to make the container have a smaller width rather than set the column width, the name for which would probably best be width. Colwidth alone seems fine. Izno (talk) 11:11, 12 July 2024 (UTC)Reply
  Not done for now: please establish a consensus for this alteration before using the {{Edit template-protected}} template. I agree with Izno that |width= could be confusing and might be useful later for an overall width of the column set. Generally we try to reduce the number of aliases for parameters, not increase them. – Jonesey95 (talk) 14:34, 12 July 2024 (UTC)Reply

Dynamic column width instead of fixed width

edit

Is it possible for the column width to be specified as a percentage of the available table or page width? For example, {{Graphic novel list}} renders whitespace in |ChapterListCol2= if it doesn't span the same number of rows as |ChapterListCol1=; see List of Monogatari novels for several examples of this whitespace. I have previewed listing the chapters using |colwidth=50% and |colwidth=40%, but it rendered the columns at 30em. — Jkudlick ⚓ (talk) 01:45, 21 August 2024 (UTC)Reply

Percentage is not an absolute or relative length unit. Try |colwidth=40vw or a similar number between 10 and 50. That says "columns should be 40% of their container's width". Test it by making your window wider and less wide. It works on the template's testcases page. – Jonesey95 (talk) 04:17, 21 August 2024 (UTC)Reply
Thank you. Perhaps the variable width should be added to the documentation? — Jkudlick ⚓ (talk) 19:48, 23 August 2024 (UTC)Reply

Template-protected edit request on 19 September 2024

edit

Please inclde these names under Notable teachers

  • Graham Hair, composition
  • Bozidar Kos, composition
  • Trevor Pearce, composition
  • Greg Schiemer, composition and electronic music
  • Michael Smetanin, composition
  • Richard Vella, composition
  • Martin Wesley-Smith, composition and electronic music
  • Gillian Whitehead, composition Greg Schiemer (talk) 12:41, 19 September 2024 (UTC)Reply
  Not done: this is the talk page for discussing improvements to the template {{Div col}}. Please make your request at the talk page for the article concerned. Sohom (talk) 13:08, 19 September 2024 (UTC)Reply