Template talk:NBA player statistics legend

Latest comment: 1 year ago by Paine Ellsworth in topic Template-protected edit request on 7 October 2022

Alignment

edit

Text within the bordered cells should be centered using the text-align:center; property. This effect should not be guesstimated by an arbitrary number of spaces. As the said spaces and text are rendered in a (usually non-fixed-width) font chosen by the client, the current design may on some screens appear far from centered. ―cobaltcigs 14:06, 22 October 2011 (UTC)Reply

Edit request on 23 February 2013

edit

Why on Earth is the template protected? In any case, "field-goal" and "free-throw" should not have hyphens in them. — X96lee15 (talk) 22:23, 23 February 2013 (UTC)Reply

  Done -- WOSlinker (talk) 22:24, 26 February 2013 (UTC)Reply

Edit request on 27 March 2020

edit

I am requesting for a new row to be added to the template, which would show the fields for NBA championship, leading the league, and an NBA record. We currently have a separate table for that and it just takes unnecessary space on basketball personnel's pages. An example is located at User:Sabbatino/sandbox. – Sabbatino (talk) 14:21, 27 March 2020 (UTC)Reply

To editor Sabbatino:   done, looks good, so let's see how it holds up. Also note the new /doc and /sandbox pages. P.I. Ellsworth  ed. put'r there 03:43, 28 March 2020 (UTC)Reply
@Sabbatino and Paine Ellsworth: I saw these changes in some articles. One downside I can see is that these new items in the key won't apply to 90% of the bios. Perhaps we should make it configurable to display only an item is used in a given bio? Reagrds.—Bagumba (talk) 09:59, 28 March 2020 (UTC)Reply
@Bagumba: Good idea. If it is possible then the template should contain the following (or similar) parameters – |leader=y (leader of a statistic in the given season), |record=y (NBA record), |champion=y (NBA championship). If a player does not meet these parameters then the parameters could be left blank. – Sabbatino (talk) 13:22, 28 March 2020 (UTC)Reply
Sounds good.—Bagumba (talk) 13:42, 28 March 2020 (UTC)Reply
@Paine Ellsworth: Is it possible to insert the proposed parameters? – Sabbatino (talk) 14:34, 28 March 2020 (UTC)Reply
  Not sure.   Investigating... been awhile since I've worked on tables, so please be patient. P.I. Ellsworth  ed. put'r there 16:18, 28 March 2020 (UTC)Reply
To editors Sabbatino and Bagumba: the new code is now in the live template and has been tested in Chrome, Firefox and Internet Explorer browsers. In addition to the updated documentation page, another example can be found in the updated John Paxson article. Let me know if you see any need for fixes. P.I. Ellsworth  ed. put'r there 18:36, 28 March 2020 (UTC)Reply
@Paine Ellsworth: Thanks! However, there seems to be a problem when only the championship parameter is used. For example, Byron Scott#NBA career statistics. The other two parameters show their fields correctly. – Sabbatino (talk) 19:51, 28 March 2020 (UTC)Reply
To editor Sabbatino:   Investigating... P.I. Ellsworth  ed. put'r there 07:25, 29 March 2020 (UTC)Reply
To editors Sabbatino and Bagumba: Evidently, trying to override the CSS styling of that table class is above my pay grade. Best I can do is to make the other parameters' boxes the same height as illustrated at the test cases page. If that is acceptable, then let me know and I'll make the edit to the live template. P.I. Ellsworth  ed. put'r there 10:58, 29 March 2020 (UTC)Reply
@Paine Ellsworth: I have some thoughts. Firstly, does changing the symbol from "†" to "†" (I mean the {{dagger}} template) fix the problem? If not then maybe the wording should be changed from "Won an NBA championship" to "NBA champion". – Sabbatino (talk) 15:15, 29 March 2020 (UTC)Reply
@Paine Ellsworth: I think the problem was that each item was on a different row, which caused extra newlines when only champion=y. I think it's resolved now.—Bagumba (talk) 15:22, 29 March 2020 (UTC)Reply
@Bagumba: It is solved indeed. Thanks! – Sabbatino (talk) 16:15, 29 March 2020 (UTC)Reply
To editor Bagumba: looks good! I still learn something new every day. P.I. Ellsworth  ed. put'r there 18:17, 29 March 2020 (UTC)Reply
@Paine Ellsworth: You did the heavy lifting. I'm a hack when it comes to templates, but have observed that newlines are often more functionally problematic than good (readability be damned). Cheers.—Bagumba (talk) 23:52, 29 March 2020 (UTC)Reply
Thank you for that, Bagumba! Don't sell yourself short, though, because you did some things there that I would never have thought to do. I'll be studying it for awhile. P.I. Ellsworth  ed. put'r there 09:37, 30 March 2020 (UTC)Reply

Template-protected edit request on 7 October 2022

edit

Replace first line with {| class="toccolours" style="white-space: nowrap;{{#ifeq:{{{align|}}}|center|margin:1em auto;|}}". This adds support for align=center param to center align the table. Tested in sandbox and verified in testcases page. ಮಲ್ನಾಡಾಚ್ ಕೊಂಕ್ಣೊ (talk) 06:30, 7 October 2022 (UTC)Reply

  Completed. P.I. Ellsworth , ed. put'r there 10:16, 7 October 2022 (UTC)Reply