Wikipedia:Bots/Requests for approval/AnomieBOT 34
- The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was
Approved.
Automatic or Manually assisted: Automatic, unsupervised
Programming language(s): Perl
Source code available: User:AnomieBOT/source/tasks/BAGBot.pm
Function overview: Update WP:BAG/Status and notify operators when {{OperatorAssistanceNeeded}} is added to their active BRFAs.
Edit period(s): Continuous
Estimated number of pages affected: 1, plus the relevant BRFA and user talk page whenever {{OperatorAssistanceNeeded}} is used.
Exclusion compliant (Y/N): Yes, including optout
Already has a bot flag (Y/N): Yes
Function details: This bot will perform various BAG-related maintenance tasks formerly done by User:BAGBot:
- Update WP:BAG/Status
- Notify users when {{OperatorAssistanceNeeded}} is used.
Discussion
editPossible items for discussion:
- Sorting of the table. Right now, it's being done by the order on WP:BRFA, but if some other order would make more sense let me know.
- Right now, it depends on the structure (headings and the Header and Approved templates) of WP:BRFA not changing. I guess BAGBot used some sort of comments, but I have no idea what the deal might have been with that.
- The text of the user notification I have chosen says "Someone has placed {{OperatorAssistanceNeeded}} on [[$page]]. Please visit that page to reply to the requests. Thanks! ~~~~ To opt out of these notifications, place {{bots|optout=operatorassistanceneeded}} anywhere on this page.", with a section title of "BAGBot: Your bot request $name".
Anomie⚔ 03:24, 28 October 2009 (UTC)[reply]
- I can't see any issues with this bot. BAGBot is missing in action, bot operator experienced coder and responsive to user input, the bot will be watched by a number of experienced operators who can point out any problems. IMO, this would be an appropriate bot to fast forward, once its operator is satisfied issues are dealt with. --IP69.226.103.13 (talk) 08:34, 28 October 2009 (UTC)[reply]
- In the notification text, could we have a message more like "Someone has marked [[$page]] as needing your input", which, IMO, makes more sense. Also, out of interest, how does the bot identify changes? Will it patrol RC (like BAGBot), or the relevant categories/pages (as Mr.Z-man's bot was going to)? Also, will the bot be notifying users when the BRfA is approved/denied? BAGBot used to do this, but I'm not sure it's needed/wanted, as I expressed here. I could ask for input from other BAG members regarding this. - Kingpin13 (talk) 13:45, 29 October 2009 (UTC)[reply]
- I like your suggested wording, change made and uploaded (or will be shortly). Changes are identified by the following process:
- First, retrieve the latest revids for WP:Bot Approvals Group and WP:Bots/Requests for approval.
- If the revid for WP:BAG is different from the saved revid for that page, download and parse the wikitext to update the list of current BAG members.
- If the revid for WP:BRFA is different from the saved revid for that page, download and parse the wikitext to update the list of current BRFAs (by looking at transclusions of {{BRFA}} in the four relevant sections).
- Load the latest revision ids, user, and timestamp for all the active BRFA pages, as well as the lists of templates and categories used. For each one:
- If the last revid changed, update the saved data for that BRFA to reflect the new latest edit. If the user for the last revid is a BAG member, update the saved data to reflect the new latest BAG edit. Otherwise, load the revision ids, user, and timestamp for revisions since the old latest edit and check if any of them are BAG edits.
- Look at the categories and templates to determine the status of the BRFA and whether either of the attention templates are used. Also, note BRFAs where operator assistance is requested.
- Once all BRFA data is updated, construct the new table. Post it if it differs from the current table.
- Go through the list of "operator assistance needed" BRFAs, load the content to determine the identity of the operator, notify them, and then edit the BRFA page to mark the "assistance needed" templates.
- In the normal case when nothing has changed, that would be just 3 API queries each time around. No plans at this time to monitor the RC feed; if I did, it would just change the logic from "do the above every 5 minutes" to "do the above on startup, and then whenever any of the relevant pages are edited". As for notifying of BRFA approval and such, I certainly could if that feature is still wanted (I personally don't care either way). Anomie⚔ 17:20, 29 October 2009 (UTC)[reply]
- All sounds good. Let's not have the user notification of dis/approval for now, if other BAG members want it it can always be added on at a later point. One more idea; Where the bot operator is a BAG member, do we want them to show up in the "Last BAG edit" section? I'm thinking maybe not, since when they are the op they're not acting as a BAG member. Also, would you say the code is ready for a trial? - Kingpin13 (talk) 08:02, 31 October 2009 (UTC)[reply]
- That's a good question on whether a BAG member should be listed as a BAG edit on their own BRFA; the only difficulty there is that it would require extra queries. If it's wanted, I can always add it later. Code is certainly ready for a trial. Anomie⚔ 13:34, 31 October 2009 (UTC)[reply]
- I think that's useful for editors monitored the bots also, if it's feasible. --IP69.226.103.13 (talk) 20:21, 31 October 2009 (UTC)[reply]
Approved for trial (5 days). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Apologies for my own inactivity around WP:BRFA at the moment; any other BAG member, please feel free to comment on the trial and approve as necessary. - Jarry1250 [Humorous? Discuss.] 17:37, 7 November 2009 (UTC)[reply]
- Running now, trial set to complete at 2009-11-14 03:40:48 UTC. Anomie⚔ 04:29, 9 November 2009 (UTC)[reply]
- All sounds good. Let's not have the user notification of dis/approval for now, if other BAG members want it it can always be added on at a later point. One more idea; Where the bot operator is a BAG member, do we want them to show up in the "Last BAG edit" section? I'm thinking maybe not, since when they are the op they're not acting as a BAG member. Also, would you say the code is ready for a trial? - Kingpin13 (talk) 08:02, 31 October 2009 (UTC)[reply]
- I like your suggested wording, change made and uploaded (or will be shortly). Changes are identified by the following process:
- In the notification text, could we have a message more like "Someone has marked [[$page]] as needing your input", which, IMO, makes more sense. Also, out of interest, how does the bot identify changes? Will it patrol RC (like BAGBot), or the relevant categories/pages (as Mr.Z-man's bot was going to)? Also, will the bot be notifying users when the BRfA is approved/denied? BAGBot used to do this, but I'm not sure it's needed/wanted, as I expressed here. I could ask for input from other BAG members regarding this. - Kingpin13 (talk) 13:45, 29 October 2009 (UTC)[reply]
Trial complete. Anomie⚔ 05:22, 14 November 2009 (UTC)[reply]
- No issues, BAG members can check this one out and stay on top of it. --IP69.226.103.13 (talk) 08:42, 14 November 2009 (UTC)[reply]
- Now that I've had time to check the bot's log file, besides the numerous edits to WP:BAG/Status the bot did two notifications for {{OperatorAssistanceNeeded}} during the trial period: [1][2][3][4] Anomie⚔ 00:22, 15 November 2009 (UTC)[reply]
Approved. Having watched over this bot while it was in trial, I couldn't spot any issues. I'm not so bothered about the small changes I suggested. If it's decided that we do want them, then we can implement them then. Meanwhile, the bot as it is shouldn't cause any controversy :). - Kingpin13 (talk) 19:22, 17 November 2009 (UTC)[reply]
- The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.