Template talk:Infobox NFL biography/Archive 18
![]() | This is an archive of past discussions. Do not edit the contents of this page. If you wish to start a new discussion or revive an old one, please do so on the current talk page. |
Archive 15 | Archive 16 | Archive 17 | Archive 18 |
Pro Football Hall of Fame
The URL has changed to the http://www.profootballhof.com/players/kevin-greene format from the http://www.profootballhof.com/hof/member.aspx?PlayerId=1985 format. CrashUnderride 14:43, 7 August 2016 (UTC)
- That 1985 points to Jackie Smith. However, http://www.profootballhof.com/hof/member.aspx?PlayerId=71 at Dan Fouts works OK. Are we sure Green's ID was correct before. It's ok if there are multiple aliases to the same url, as long as the HOF site maintains backwards compatibility.—Bagumba (talk)17:15, 7 August 2016 (UTC)
- I guess the bigger issue is new inductees. If I look at http://www.profootballhof.com/heroes-of-the-game/alphabetically/, they are all of the name format, not the ID. Seems like we can add a new parameter that supports the new format, and otherwise look for the old param for legacy ones. Or maybe someone can write a script that resolves the id to the name format, so everything is normalized.—Bagumba (talk) 17:23, 7 August 2016 (UTC)
- Template:Profootballhof should also be updated accordingly. Jweiss11 (talk) 02:18, 8 August 2016 (UTC)
- I guess the bigger issue is new inductees. If I look at http://www.profootballhof.com/heroes-of-the-game/alphabetically/, they are all of the name format, not the ID. Seems like we can add a new parameter that supports the new format, and otherwise look for the old param for legacy ones. Or maybe someone can write a script that resolves the id to the name format, so everything is normalized.—Bagumba (talk) 17:23, 7 August 2016 (UTC)
So it seems like Green's 1985 id was never correct looking at this archived HOF webpage from Feb 2016[1]. And looking at articles from this year's inductees, it seems like some just made up id's, since it appears everyone this year is use the url with their name in it. Thus, I think we can have a new parameter for the new format, and previous inductees can leave their urls intact with the old parameter.—Bagumba (talk) 02:37, 8 August 2016 (UTC)
- Something like the nfl and nflnew ones. Such as hof and hofnew. Heh, "hofnew" sounds like some a Batman villain. lol CrashUnderride 05:15, 8 August 2016 (UTC)
Template-protected edit request on 3 September 2016
This edit request to Template:Infobox NFL biography has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Would it be possible to also add a link to the person's CBSSports profile? Such as in Template:Infobox gridiron football person. Dat GuyTalkContribs 08:17, 3 September 2016 (UTC)
- Not done: please establish a consensus for this alteration before using the
{{edit template-protected}}
template. Once you've established a consensus for this at WP:NFL or any appropriate forum, please make sure that you have tested it in a sandbox, and then give the exact code you want added and where to add it. TrueCRaysball | #RaysUp 09:48, 3 September 2016 (UTC)
Template-protected edit request on 23 September 2016
This edit request to Template:Infobox NFL biography has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
In the data17
parameter: | data17 = {{#if:{{{draftyear|}}}|[[{{{draftyear}}} NFL draft|{{{draftyear}}}]] / Round: {{{draftround}}}{{#if:{{{draftpick|}}}| / Pick: {{{draftpick}}}}}}}
, please change "NFL draft" to "NFL Draft" so that it bypasses the redirect after "Draft" was capitalized for all articles (e.g. 2016 NFL Draft instead of 2016 NFL draft). Also, please change label17
to read "NFL Draft" instead of "NFL draft".
—MRD2014 (talk) (contribs) 01:15, 23 September 2016 (UTC)
- Done — JJMC89 (T·C) 02:17, 23 September 2016 (UTC)
Tracking categories...
I am working on cleaning up some of the deprecations and I noticed that this template has a TON of tracking categories. Can someone who is more familiar with this template help me understand why? For example, why do we need to track Category:NFL player with currentposition parameter? Is that parameter deprecated? If so that category should be renamed... Not necessarily objecting to the categories, just trying to understand. --Zackmann08 (Talk to me/What I been doing) 20:53, 23 November 2016 (UTC)
- Currentposition is deprecated. Once, the cat is empty, we can delete it. WikiOriginal-9 (talk) 21:02, 23 November 2016 (UTC)
- @Deejayk: it looks like you created at least one of the deprecation categories... (Category:NFL player with deprecated height or weight parameter). Why is height/weight deprecated? Looks like it is still in use in the template... Additionally with regards to Category:NFL player using deprecated currentteam parameter why is
{{{currentteam}}}
deprecated? Plenty of other params in the template use one word params without underscore,{{{pastteams}}}
,{{{pastcoaching}}}
, etc. etc. I don't see any reason to deprecate the param. Just support both. --Zackmann08 (Talk to me/What I been doing) 21:04, 23 November 2016 (UTC)- @WikiOriginal-9: what is
{{{Currentposition}}}
deprecated in favor of? What should be replacing it? There should be some more details put in the description of the category which should also be added to Category:Deprecated parameters. --Zackmann08 (Talk to me/What I been doing) 21:06, 23 November 2016 (UTC)- @WikiOriginal-9: Sorry just re-read my response and I sounded a bit preachy. Didn't mean that... I'm trying to attack these deprecations and just want to make sure I'm hitting the right things! Looks like
{{{currentposition}}}
is deprecated in favor of{{{position}}}
. Can you confirm? --Zackmann08 (Talk to me/What I been doing) 21:09, 23 November 2016 (UTC)
- @WikiOriginal-9: Sorry just re-read my response and I sounded a bit preachy. Didn't mean that... I'm trying to attack these deprecations and just want to make sure I'm hitting the right things! Looks like
- @WikiOriginal-9: what is
- @Deejayk: it looks like you created at least one of the deprecation categories... (Category:NFL player with deprecated height or weight parameter). Why is height/weight deprecated? Looks like it is still in use in the template... Additionally with regards to Category:NFL player using deprecated currentteam parameter why is
- Yes, that seems to be the case with the position parameter. Currentteam has been replaced by current_team. The syntax of the height and weight parameters were also changed. Not sure why some have underscores and others don't. WikiOriginal-9 (talk) 21:42, 23 November 2016 (UTC)
- @WikiOriginal-9: well if we are going to correct this, lets correct them all. I'm in the process of writing a bot to clean all these up. How about we open up an WP:RFC and come to a consensus. I say make all the parameters in the template underscored for consistency. Thoughts? --Zackmann08 (Talk to me/What I been doing) 00:39, 24 November 2016 (UTC)
- That sounds good. It looks like the underscores were added when Infobox NFL coach was being merged. See this edit summary: "add alternate parameter current_team with the intention of adopting this as the default (replacing currentteam) in order to simplify merger with Template:Infobox NFL coach". WikiOriginal-9 (talk) 01:20, 24 November 2016 (UTC)
- @WikiOriginal-9: well if we are going to correct this, lets correct them all. I'm in the process of writing a bot to clean all these up. How about we open up an WP:RFC and come to a consensus. I say make all the parameters in the template underscored for consistency. Thoughts? --Zackmann08 (Talk to me/What I been doing) 00:39, 24 November 2016 (UTC)
RFC regarding parameters
So I am in the process of cleaning up deprecated parameters from templates. This template has a number of them. During a discussion about these parameters (see above) it came to light that some parameters in the template are all one word (for example {{{foobar}}}
) while others have an underscore (such as {{{foo_bar}}}
. The question on the table is regarding making all the template parameters consistent. I will gladly be responsible for changing the transclusions (it will be done with a bot), updating the template and the template documentation, etc. I just want to make sure that a consensus is reached! For simplicity sake, the question on the table for support or oppose is:
- Should all multi-word parameters in the template (such as
{{{expansiondraftyear}}}
) be formatted to use underscores (i.e.{{{expansion_draft_year}}}
.
Obviously all comments comments are welcome! Not just support/oppose. Looking forward to hearing all input! Also if there are additional parameters that are deprecated and should be removed, let's be sure to get that well documented so I can hit them all when I run my bot. --Zackmann08 (Talk to me/What I been doing) 06:18, 25 November 2016 (UTC)
- @Deejayk, Dirtlawyer1, Bagumba, Frietjes, BU Rob13, and JJMC89: as recent contributors to the template, please be sure to read this as well as the section below about deprecated parameters. --Zackmann08 (Talk to me/What I been doing) 00:30, 26 November 2016 (UTC)
Deprecated params
Can we get some clarification on what params are deprecated. This is the list I have. Where applicable the new param is listed. If not listed the param should be removed entirely.
{{{debutteam}}}
{{{debutyear}}}
{{{finalteam}}}
{{{finalyear}}}
{{{coachdebutteam}}}
{{{coachdebutyear}}}
{{{coachfinalteam}}}
{{{coachfinalyear}}}
{{{heightft|}}}
→{{{height_ft}}}
{{{heightin|}}}
→{{{height_in}}}
{{{weight|}}}
→{{{weight_lbs}}}
{{{weight_lb|}}}
→{{{weight_lbs}}}
(Gone){{{dbf}}}
(NOT deprecated, and no longer tracking){{{pastcoaching}}}
(NOT deprecated, and no longer tracking){{{pastexecutive}}}
(NOT deprecated, and no longer tracking){{{pastadmin}}}
{{{currentteam}}}
→{{{current_team}}}
{{{currentnumber}}}
→{{{number}}}
{{{currentposition}}}
→{{{position}}}
{{{currentpositionplain}}}
→{{{position}}}
There are a ton of tracking categories that don't give any explanation as to why they are tracking things. Would appreciate some help here. --Zackmann08 (Talk to me/What I been doing) 00:28, 26 November 2016 (UTC)
- @Zackmann08: Hey. Frankly, the documentation of this template is shit. That's mostly my fault. I tend to add tracking categories like mad and not document them very well, although many of these deprecated parameters predate me. The debut/final team parameters should be removed from articles gradually. They aren't supported by the template at all anymore. I noted the replacement parameters for height and weight above, which were changed to bring this in line with similar templates, I believe.
{{{dbf}}}
should be removed; it is no longer supported. The three "past" parameters are just tracked because sometimes it's worth looking at only articles of coaches, admins, or executives. They aren't actually deprecated. ~ Rob13Talk 00:53, 26 November 2016 (UTC)- "currentposition" and "currentpositionplain" are both depreciated in favor of "position". WikiOriginal-9 (talk) 01:26, 26 November 2016 (UTC)
- @BU Rob13 and WikiOriginal-9: thank you so much! Really appreciate you both chiming in. BU Rob13 One tip/request, in the future when adding a deprecation category, would be fantastic to have that made clear in the name of the category to separate from just plain old tracking categories. As mentioned in the section above, I'm planning to write a bot to clean all this up. Just want to make sure I know what needs to be cleaned up. --Zackmann08 (Talk to me/What I been doing) 04:09, 26 November 2016 (UTC)
- I edited your list above if you don't mind. WikiOriginal-9 (talk) 05:00, 26 November 2016 (UTC)
- @Zackmann08: Exactly what will you propose having your bot do? WP:COSMETICBOT has kept me from cleaning this up myself, although I have written a script that cleans all this up that I've kind of added as a tag-along whenever I'm doing other maintenance tasks involving this infobox. You likely will not get approval for a bot that just cleans up these deprecated parameters. (Also, these categories actually aren't mine. All of this deprecation pre-dates my time on the site. I'm more responsible for the abundance of essentially undocumented accessibility tracking categories.) ~ Rob13Talk 05:42, 26 November 2016 (UTC)
- @WikiOriginal-9: not at all! Please do!
- @BU Rob13: just FYI I've already gotten approval for multiple bots to clean out deprecated parameters. Now they are in the trial stages, not having been fully tested, but they were not denied due to WP:COSMETICBOT. In any case, I think we can all agree that cleaning up the documentation and unifying the parameters would be great. We can still support the old params but unifying them to all use underscore would be a great start. For now, don't worry about the bot. Whether or not I can get a bot working, it would be fantastic to just improve the documentation and clean up the code. --Zackmann08 (Talk to me/What I been doing) 06:10, 26 November 2016 (UTC)
- @Zackmann08: Exactly what will you propose having your bot do? WP:COSMETICBOT has kept me from cleaning this up myself, although I have written a script that cleans all this up that I've kind of added as a tag-along whenever I'm doing other maintenance tasks involving this infobox. You likely will not get approval for a bot that just cleans up these deprecated parameters. (Also, these categories actually aren't mine. All of this deprecation pre-dates my time on the site. I'm more responsible for the abundance of essentially undocumented accessibility tracking categories.) ~ Rob13Talk 05:42, 26 November 2016 (UTC)
- I edited your list above if you don't mind. WikiOriginal-9 (talk) 05:00, 26 November 2016 (UTC)
- @BU Rob13 and WikiOriginal-9: thank you so much! Really appreciate you both chiming in. BU Rob13 One tip/request, in the future when adding a deprecation category, would be fantastic to have that made clear in the name of the category to separate from just plain old tracking categories. As mentioned in the section above, I'm planning to write a bot to clean all this up. Just want to make sure I know what needs to be cleaned up. --Zackmann08 (Talk to me/What I been doing) 04:09, 26 November 2016 (UTC)
- "currentposition" and "currentpositionplain" are both depreciated in favor of "position". WikiOriginal-9 (talk) 01:26, 26 November 2016 (UTC)
Removing tracking cats
Ok so I'm BOLDly calling BS on the need for the past tracking categories... And here's why... They're doing the opposite of what they're described to do and no one has fixed them so clearly they're not being used!!!
<!-- -->{{#if:{{{pastcoaching|}}}||[[Category:NFL player with pastcoaching parameter]] }}<!-- -->{{#if:{{{pastexecutive|}}}||[[Category:NFL player with pastexecutive parameter]] }}<!-- -->{{#if:{{{pastadmin|}}}||[[Category:NFL player with pastadmin parameter]] }}<!--
These mean that pages WITHOUT {{{pastcoaching}}}
will be put in Category:NFL player with pastcoaching parameter.... Same for the other two. SO clearly no one is really using these tracking categories. --Zackmann08 (Talk to me/What I been doing) 06:41, 6 December 2016 (UTC)
- @Zackmann08: For maintenance tasks, it's useful to know who's using those parameters. I would object to the categories going away entirely. If they were being coded improperly, that may actually explain some past difficulties I've had in using them, and they should be corrected. ~ Rob13Talk 23:12, 9 December 2016 (UTC)
Template-protected edit request on 9 December 2016
This edit request to Template:Infobox NFL biography has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Replace "No." in header1 with No. Grapesoda22 22:06, 9 December 2016 (UTC) Grapesoda22 22:06, 9 December 2016 (UTC)
- Done ~ Rob13Talk 23:11, 9 December 2016 (UTC)
- I object to this. It looks silly, and helps very few people. Just because we can doesn't mean we should. Lizard (talk) 23:51, 9 December 2016 (UTC)
- To be honest I don't think its totally necessary either, but more and more pages and templates here on Wikipedia are doing it. This Infobox isn't uniform the old way it was anymore. Grapesoda22 00:50, 10 December 2016 (UTC)
- I object to this. It looks silly, and helps very few people. Just because we can doesn't mean we should. Lizard (talk) 23:51, 9 December 2016 (UTC)
- This is awful. Please revert and reach consensus on whether this should be adopted. UW Dawgs (talk) 13:44, 10 December 2016 (UTC)
- Agreed. "No." is a common abbreviation for "Number", so the tooltip is unnecessary. Furthermore, it's contrary to WP:ACCESS. – PeeJay 16:50, 10 December 2016 (UTC)
- @PeeJay2K3: I am neutral on the matter, but I do want to point out that WP:ACCESS states Do not use techniques that require interaction to provide information, such as tooltips or any other "hover" text. Abbreviations are exempt from these requirements, so the {{abbr}} template may be used to indicate the long form of a word. --Zackmann08 (Talk to me/What I been doing) 18:47, 10 December 2016 (UTC)
- That makes sense, but I think that applies more to the use of tooltips to indicate that W, L and T stand for Wins, Losses and Ties in standings tables. For stuff like "No.", it's really not necessary. – PeeJay 19:13, 10 December 2016 (UTC)
- We might as well just spell out "Number" instead. There's enough room on that line. Lizard (talk) 19:38, 10 December 2016 (UTC)
- Or possibly use the # sign, but I'm not sure if other English regions always associate that with "number". Both NFL.com and team roster profile pages list it like this however. ~ Dissident93 (talk) 23:05, 10 December 2016 (UTC)
- MOS:POUND specifically says not to. Lizard (talk) 23:18, 10 December 2016 (UTC)
- Or possibly use the # sign, but I'm not sure if other English regions always associate that with "number". Both NFL.com and team roster profile pages list it like this however. ~ Dissident93 (talk) 23:05, 10 December 2016 (UTC)
- We might as well just spell out "Number" instead. There's enough room on that line. Lizard (talk) 19:38, 10 December 2016 (UTC)
- That makes sense, but I think that applies more to the use of tooltips to indicate that W, L and T stand for Wins, Losses and Ties in standings tables. For stuff like "No.", it's really not necessary. – PeeJay 19:13, 10 December 2016 (UTC)
- @PeeJay2K3: I am neutral on the matter, but I do want to point out that WP:ACCESS states Do not use techniques that require interaction to provide information, such as tooltips or any other "hover" text. Abbreviations are exempt from these requirements, so the {{abbr}} template may be used to indicate the long form of a word. --Zackmann08 (Talk to me/What I been doing) 18:47, 10 December 2016 (UTC)
- Agreed. "No." is a common abbreviation for "Number", so the tooltip is unnecessary. Furthermore, it's contrary to WP:ACCESS. – PeeJay 16:50, 10 December 2016 (UTC)
Template-protected edit request on 10 December 2016
This edit request to Template:Infobox NFL biography has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Replace No. in header1 with No. Lizard (talk) 22:56, 10 December 2016 (UTC)
- Done I've reverted my previous edit until consensus develops for it, although I really don't get the controversy here. Providing a long-form version of an abbreviation seemed/seems uncontroversial to me. ~ Rob13Talk 23:22, 10 December 2016 (UTC)
Template breaking
This edit request to Template:Infobox NFL biography has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Something's breaking with this template to include a visible "</noinclude>" after the "Weight" field. What's wrong here? Seattle (talk) 09:10, 23 December 2016 (UTC)
- Already done Resolved elsewhere, see Special:Diff/756348970 — JJMC89 (T·C) 17:09, 23 December 2016 (UTC)
- @JJMC89: thanks for fixing that! I took a look and couldn't figure out where it was coming from. --Zackmann08 (Talk to me/What I been doing) 17:19, 23 December 2016 (UTC)
Parameter broke
The Canadian Football HOF parameters all go to "Page not found". Looks like the website restructured their links. WikiOriginal-9 (talk) 16:23, 13 January 2017 (UTC)
Draft team parameter?
I'm curious as to why there is not a draftteam parameter. Seems to me it would be appropriate, but maybe I'm missing something? Thanks Jb45424 (talk) 05:41, 25 January 2017 (UTC)
- There was at one time I think. I know there was a debuteteam, debutyear and finalteam, finalyear parameters but they were removed. I think there isn't a draftteam parameter because drafting and trading players isn't nearly as common as it is in the NBA with teams drafting a player with one pick, to trade to another team literally minutes later, ala Kobe Bryant or Scottie Pippen. The only time I know of that happening is with Eli Manning and Phillip Rivers. (talk page stalker) CrashUnderride 05:55, 25 January 2017 (UTC)
- I think it might not be there as well because of space. The first team listed in the pastteams parameter is 99% of the time the same team that drafted them. WikiOriginal-9 (talk) 16:54, 25 January 2017 (UTC)
- Thanks for the clarifications, that makes sense. Much appreciated. Jb45424 (talk) 04:27, 26 January 2017 (UTC)
- @Jb45424: glad to help, now don't ask something so stupid again! lmfao Just kidding!!! We're glad to help. (talk page stalker) CrashUnderride 05:42, 26 January 2017 (UTC)
- @Crash Underride:There are no stupid questions, only stupid people who ask questions. :) Jb45424 (talk) 23:54, 27 January 2017 (UTC)
- I think a player going to a team he wasn't drafted by happens a lot more often than you'd think. But we recently eliminated all the leftover parameters from when we had a "drafted by" field, so we might as well stick to what we've got now. Lizard (talk) 23:58, 27 January 2017 (UTC)
- It happened a ton in the 1960s when players were drafted by NFL teams and instead went to the AFL. Then there's guys like John Henry Johnson, who was drafted by the Steelers and went to the CFL. Lizard (talk) 00:04, 28 January 2017 (UTC)
- @Crash Underride:There are no stupid questions, only stupid people who ask questions. :) Jb45424 (talk) 23:54, 27 January 2017 (UTC)
- @Jb45424: glad to help, now don't ask something so stupid again! lmfao Just kidding!!! We're glad to help. (talk page stalker) CrashUnderride 05:42, 26 January 2017 (UTC)
- Thanks for the clarifications, that makes sense. Much appreciated. Jb45424 (talk) 04:27, 26 January 2017 (UTC)
Pro Football Reference (PFR)
I think the location should be changed in the table. Currently, when filled out, it appeared alongside ArenaFan.com, not NFL.com. It should show up alongside NFL.com because they don't list AFL stats. (talk page stalker) CrashUnderride 19:30, 8 February 2017 (UTC)
- If NFL stats are present, the PFR link should be moved up with the NFL.com link. I don't know how to do it though. WikiOriginal-9 (talk) 20:08, 14 February 2017 (UTC)
- I used to. I created an AFL infobox years ago, but it's since been merged with this one. Literally all the AFL fields in the NFL box now come from the one I created. lol (talk page stalker) CrashUnderride 20:38, 14 February 2017 (UTC)
- Impressive lol. WikiOriginal-9 (talk) 20:40, 14 February 2017 (UTC)
- I used to. I created an AFL infobox years ago, but it's since been merged with this one. Literally all the AFL fields in the NFL box now come from the one I created. lol (talk page stalker) CrashUnderride 20:38, 14 February 2017 (UTC)
Template-protected edit request on 1 April 2017
This edit request to Template:Infobox NFL biography has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Could someone add statlabel7, statvalue7, statlabel8, and statvalue8 to the parameters? Of course, these would be used very sparingly since six fields are usually more than sufficient. But some older players were proficient in several stat categories and so extra fields are warranted. Sammy Baugh is the best example of this. Lizard (talk) 16:29, 1 April 2017 (UTC)
- Done Cabayi (talk) 18:18, 1 April 2017 (UTC)
- statlabel7, statvalue7, statlabel8, and statvalue8 need to be added to the "Check for unknown parameters" section. Ahwiv (talk) 19:30, 20 April 2017 (UTC)
- @Ahwiv: Done --Ahecht (TALK
PAGE) 23:44, 20 April 2017 (UTC) - @Ahecht: Thanks! Ahwiv (talk) 00:38, 21 April 2017 (UTC)
- @Ahwiv: Done --Ahecht (TALK
- statlabel7, statvalue7, statlabel8, and statvalue8 need to be added to the "Check for unknown parameters" section. Ahwiv (talk) 19:30, 20 April 2017 (UTC)
Proposal: Change PFR player stats link to use HTTPS and a string replacement function
The template generates a link to a player stats page on Pro-Football-Reference.com (PFR) if a value is specified for the pfr
parameter. Though this link currently uses HTTP, it appears that the PFR site supports HTTPS. However, there appears to be an issue wherein the PFR site generates a number of redirects, including an HTTPS -> HTTP redirect, if the pfr
parameter value does not begin with the first letter of the player's last name followed by a slash. For example, https://www.pro-football-reference.com/players/AvenJo20.htm generates a 301 Moved Permanently redirect to http://www.pro-football-reference.com/players/A/AvenJo20.htm?redir which then generates another 301 redirect to the actual page at https://www.pro-football-reference.com/players/A/AvenJo20.htm?redir. On the other hand, https://www.pro-football-reference.com/players/A/AvenJo20.htm generates a successful HTTP 200 result. (As a side note, https://www.pro-football-reference.com/players//A/AvenJo20.htm also generates an HTTP 200 result.)
In this sandbox revision, there is an implementation of the template incorporating a string replace function wherein the pfr
parameter value is adjusted, if necessary, so that the URL always contains the first letter of the player's last name followed by a slash and then the rest of the player's name. With this implementation, the pfr
parameter values of AvenJo20
and A/AvenJo20
(for example) both cause the template to generate the link https://www.pro-football-reference.com/players/A/AvenJo20.htm. Would it be useful to copy this sandbox implementation into the actual template? --Elegie (talk) 13:40, 18 September 2017 (UTC)
- As long as all the links still work, then feel free. WikiOriginal-9 (talk) 15:17, 18 September 2017 (UTC)
Wikidata
Hello there. The IDs stored on Wikidata have all been shortened to the numerical part of the former IDs. This template should probably be updated accordingly. Thierry Caro (talk) 10:47, 1 November 2017 (UTC)
- Thierry Caro, how do you form the URL with only the numeric part of the ID? for example, the URL for Zay Jones, includes his name and the ID. Frietjes (talk) 14:56, 1 November 2017 (UTC)
- Using
http://www.nfl.com/player/n/$1/profile
for instance.$1
being the numerical ID. Thierry Caro (talk) 14:59, 1 November 2017 (UTC)
- Using
- The "nflnew" parameter only accepts the "zayjones/2557863" version. The "nfl" parameter only seems to accept the numerical ID ("2557863"). WikiOriginal-9 (talk) 16:09, 1 November 2017 (UTC)
- so
http://www.nfl.com/players/profile?id=2557863
,http://www.nfl.com/player/n/2557863/profile
, andhttp://www.nfl.com/player/zayjones/2557863/profile
all basically give the same result? unless, of course, nfl.com changes the redirection, it seems like we can just use|nfl=
instead of|nflnew=
and do the translation internally? Frietjes (talk) 17:07, 1 November 2017 (UTC)
- so
- If you think that's best, go ahead and do it. As long all the links still work. Would we have to use a bot to get rid of all the
|nflnew=
instances? WikiOriginal-9 (talk) 17:14, 1 November 2017 (UTC)- if we needed to get the pure numeric id for some reason, we could strip off the non-numeric part internally with
{{#invoke:string|replace|{{{nflnew}}}|^[^0-9]*||plain=false}}
(e.g.,{{#invoke:string|replace|zayjones/2557863|^[^0-9]*||plain=false}}
= 2557863). since the links aren't broken, I don't see any urgency to do anything. but we could change the|nfl=
url to usehttp://www.nfl.com/player/n/2557863/profile
instead ofhttp://www.nfl.com/players/profile?id=2557863
if the redirect is not wanted (and we could update the documentation to encourage using the|nfl=
instead of the|nflnew=
). but, again, nothing appears to be fundamentally broken here. Frietjes (talk) 17:34, 1 November 2017 (UTC)
- if we needed to get the pure numeric id for some reason, we could strip off the non-numeric part internally with
- If you think that's best, go ahead and do it. As long all the links still work. Would we have to use a bot to get rid of all the
Template-protected edit request on 4 May 2018
This edit request to Template:Infobox NFL biography has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Change
| data19 = {{#if:{{{cfldraftyear|}}}|[[{{{cfldraftyear}}} CFL draft|{{{cfldraftyear}}}]] / Round: {{{cfldraftround}}}{{#if:{{{cfldraftpick|}}}| / Pick: {{{cfldraftpick}}}}}}}
to
| data19 = {{#if:{{{cfldraftyear|}}}|[[{{{cfldraftyear}}} CFL Draft|{{{cfldraftyear}}}]] / Round: {{{cfldraftround}}}{{#if:{{{cfldraftpick|}}}| / Pick: {{{cfldraftpick}}}}}}}
to avoid auto-linking to CFL Draft pages that don't exist due to capitalization GreenRunner0 01:54, 4 May 2018 (UTC)
Template-protected edit request on 25 August 2018
This edit request to Template:Infobox NFL biography has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Kyle Shanahan 50.1.86.74 (talk) 18:51, 25 August 2018 (UTC)
- Not done: If you want an edit to be done at Kyle_Shanahan please do an edit request there Galobtter (pingó mió) 18:52, 25 August 2018 (UTC)
CollegeHOF = address change
Every "College Football Hall of Fame" links run bug, because it gave new address https://footballfoundation.org/hof_search.aspx?id={{{CollegeHOF}}}
this link address is http://www.footballfoundation.org/Programs/CollegeFootballHallofFame/SearchDetail.aspx?id={{{CollegeHOF}}}
. I think it have to change. Sczipo (talk) 14:17, 17 September 2018 (UTC)
- should be fixed now. Frietjes (talk) 14:10, 16 November 2018 (UTC)
Template-protected edit request on 24 October 2018
This edit request to Template:Infobox NFL biography has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Please fix the link for the College HOF (| CollegeHOF =
) parameter since it is broken. The link in the parameter should be changed to https://footballfoundation.org/hof.aspx?hof={{{CollegeHOF}}}
. – Sabbatino (talk) 09:14, 24 October 2018 (UTC)
- Done — JJMC89 (T·C) 06:07, 28 October 2018 (UTC)
- and the IDs changed. I have started the process of trapping and fixing all of them. Frietjes (talk) 14:11, 16 November 2018 (UTC)
Template-protected edit request on 3 December 2018
This edit request to Template:Infobox NFL biography has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Move the Player stats at NFL.com to the bottom section of the infobox where other citations are. – XYZt (talk | contribs) – 02:56, 3 December 2018 (UTC)
- Not done. Please establish a consensus for this change. It seems to me that it might be better, for example, to move the CFL stats link to the CFL section and the ArenaFan link to the Arena section. – Jonesey95 (talk) 11:49, 3 December 2018 (UTC)
Template-protected edit request on 21 January 2019
This edit request to Template:Infobox NFL biography has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
The Expansion draft year value (|expansiondraftyear=
) needs to be edited such that (|expansiondraftyear=1995
) generates the value "1995 NFL expansion draft". It currently would generate the value "1995 NFL Expansion draft" (note the difference in capitalization on "expansion") which results in a red link. GreenRunner0
- fixed. Frietjes (talk) 16:05, 21 January 2019 (UTC)
Headings
For the headings in the boxes such as career information, personal information, and career history shouldn’t the whole title be capitalized instead of just the first word? Bmorrow151 (talk) 19:07, 11 March 2019 (UTC)
Article titles in Italics
@Frietjes: for some reason this infobox is making article titles appear in italics. See for example O. J. Simpson. --- Coffeeandcrumbs 13:01, 13 July 2019 (UTC)
- Coffeeandcrumbs, the article title doesn't appear in italics for me. Frietjes (talk) 13:10, 13 July 2019 (UTC)
- @Frietjes: Never mind. The issue was from a module. See [2]. --- Coffeeandcrumbs 13:12, 13 July 2019 (UTC)
Parameter merging suggestion
Can the stats parameters (mostly pfr and nflnew) be merged in the infobox, copying the style from the footballstats template? ~ Dissident93 (talk) 01:00, 23 January 2020 (UTC)
- It's weird also how currently the links are even in separate sections. Where do you suggest they would be if they are merged? And what about the CFL and Arena football links?—Bagumba (talk) 05:25, 23 January 2020 (UTC)
- The same place at the bottom, just bulleted like the stats template. CFL and Arena parameters would also be included. ~ Dissident93 (talk) 18:22, 23 January 2020 (UTC)
Grammar suggestion
Shouldn't the "as player", "as coach" and "as executive" subheaders be either "as a player" or simply "player"? The way it currently is just seems awkward. ~ Dissident93 (talk) 23:51, 27 January 2020 (UTC)
Death date doesn't show
The date of death doesn't show on Mario Henderson. It contained an empty entry on the bottom. Ignore this post. KittenKlub (talk) 16:53, 21 October 2020 (UTC)
Infobox bodystyle
This infobox is unusually large, both in horizontal width and text sizing. In the sandbox, I tried removing the "bodystyle" parameter that creates this styling, and judging by the testcases, in most cases there is surprisingly little effect on the vertical height of the infobox. Should this change (or parts of it) be implemented? — Goszei (talk) 04:32, 1 February 2021 (UTC)
- (Same comment was made at Template_talk:Infobox_basketball_biography) What is you basis for judging it is "unusually large"? Your proposed changes cause wrapping to occur in the test cases.—Bagumba (talk) 11:51, 1 February 2021 (UTC)
- I think this may conflict with MOS:SMALL. Eagles 24/7 (C) 22:33, 1 February 2021 (UTC)
- Removing the text-sizing here sets the scaling to the default in Module:Navbar/styles.css, which is 88% of the normal size. MOS:SMALL is only violated when text is below 85% of the normal size.— Goszei (talk) 06:02, 11 February 2021 (UTC)
"Weight" info: make source and/or date clear for former players?
I was reviewing the page of Chad Clifton a former NFL player, released by the Packers seven years ago. Under "Personal information", his weight is listed as 320 pounds. My first thought was "That must no longer be correct; he's surely (or hopefully) lost weight since he played."
In the spec for this template, both "Height" and "Weight" are from the player's NFL.com profile, so the values are correct as per the spec. However, I would suggest that for former players this is misleading; there's no indication that this is historical rather than current information. The section caption of "Personal information", in conjunction with showing such absolute information as birth and death dates, suggests that this is info that is independent of his career, and generally true, rather than "true as of a specific date." Height isn't likely to change all that much, but weight (especially for players who were paid to be massive) certainly can.
Is there a way that, for former players, weight (and probably height) could be clarified as from when they were last playing? -- Dan Griscom (talk) 11:40, 14 March 2021 (UTC)
- Dtgriscom, I thought it would already be assumed by the majority of readers to have been their playing weight. But if not, perhaps the parameter name could be dynamically changed to "Playing weight/height" based on a free agent/blank string in the team parameter? ~ Dissident93 (talk) 21:57, 14 March 2021 (UTC)
Highlights section
Hello all. I could have sworn at one point either this page or WP:NFLINFOBOXNOT clearly stated single game awards were not worthy of highlights. These would include Thanksgiving MVP awards, SNF's weekly Horse Trailer Award, or Nickelodeon's NVP Award. Should these be excluded from the highlights section like Pro Bowl MVP, or is it left up to discretion of other editors? -- StarScream1007 ►Talk 00:06, 25 June 2021 (UTC)
- StarScream1007, wouldn't it fall under the "Monthly/weekly awards, e.g. NFC offensive rookie of the month, FedEx Ground player of the week" example? ~ Dissident93 (talk) 19:30, 25 June 2021 (UTC)
- Thanks, Dissident93. That makes sense for the SNF award. Still a bit curious about things like the NVP or "Galloping Gobbler" (Or whatever they call the Thanksgiving MVP Award these days). These games do not occur weekly/monthly and are usually once per season. -- StarScream1007 ►Talk 23:51, 25 June 2021 (UTC)
- The list is not meant to be exhaustive. The question to ask is whether the item in question typically defines people's legacy. Per the guideline MOS:INFOBOXPURPOSE:
The less information it contains, the more effectively it serves that purpose, allowing readers to identify key facts at a glance.
—Bagumba (talk) 02:39, 26 June 2021 (UTC)
- The list is not meant to be exhaustive. The question to ask is whether the item in question typically defines people's legacy. Per the guideline MOS:INFOBOXPURPOSE:
- Thanks, Dissident93. That makes sense for the SNF award. Still a bit curious about things like the NVP or "Galloping Gobbler" (Or whatever they call the Thanksgiving MVP Award these days). These games do not occur weekly/monthly and are usually once per season. -- StarScream1007 ►Talk 23:51, 25 June 2021 (UTC)
Adding medal templates
How do I add medal templates to an infobox? (e.g. Jon Kolb and Craig Wolfley) Megacheez (talk) 16:50, 20 February 2022 (UTC)
USFL
I was wondering if we could add the USFL as a part of the statistics section and draft. Thank you :) Kellis7 13:28, 20 April 2022 (UTC)
Add AFL Draft, Notable Undrafted Players
I think there should be this function, there are several players who were not drafted by teams from the NFL, but were signed as UDFA by AFL teams, for example Willie Brown, CB from Grambling State signed with the Oilers or Emmitt Thomas, CB from Bishop signed with the Chiefs, both Hall of Famers, I think they technically do not belong to the NFL Draft but to the AFL. Sergio Skol (talk) 12:46, 15 July 2022 (UTC)
Two requests
|status=
should be suppressed when|current_team=
is empty. Currently it only is when set to "free agent".- "0" should also be suppressed as a
|statlabel=
.
Template-protected edit request on 12 October 2022
This edit request to Template:Infobox NFL biography has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Please add a space to all of the "statvalue#" fields after the colon for readability. E.g., change "Games played:[tab]37" (as in Jeff Jordan (defensive back)) to "Games played:[tab] 37".
- —DocWatson42 (talk) 04:36, 12 October 2022 (UTC) DocWatson42 (talk) 04:36, 12 October 2022 (UTC)
- @DocWatson42 There is already a space between the number and "Games played". This gap is consistant across the entire infobox. Are you requesting that the gap is increased for position, personal info, career, stats, cfl stats, arena stats & biographical infomation? Terasail[✉️] 10:51, 12 October 2022 (UTC)
- Done – Jonesey95 (talk) 14:55, 12 October 2022 (UTC)
- Thank you. I'm afraid I could not tell that there was a space in those fields—the numbers were too close to the colons. —DocWatson42 (talk) 15:05, 12 October 2022 (UTC)
- There is not actually a space character. The label and the value are in two separate table cells. For some reason, the cells were squished up against each other. Rather than figure out why, I added some padding on the left side of the value cell, eyeballing it to try to match the padding around the values for "Height:" and other items in the main part of the infobox. Somewhere there is a style sheet that could probably have fixed this, but fixing it locally appears to have worked. – Jonesey95 (talk) 16:01, 12 October 2022 (UTC)
- Thank you. I'm afraid I could not tell that there was a space in those fields—the numbers were too close to the colons. —DocWatson42 (talk) 15:05, 12 October 2022 (UTC)
Dolphins question
I'm figuring it must be for accessibility reasons but any reason why the Dolphins templates/navboxes/etc use black on aqua instead of white on aqua. White looks cleaner (and for me at least, is easier to read on the aqua) and unlike black, is one of their team colors. Any links to previous discussions on this would be helpful. Thanks Soulbust (talk) 01:43, 29 December 2022 (UTC)
- Yes, looks like white wouldn't meet AA compilance.[3] I will second your obeservation, that some combinations that are accessible are not necessarily the most pleasing for able readers. We should definitely be accessible, but just noting that using colors is complicated. —Bagumba (talk) 03:03, 29 December 2022 (UTC)
- Thank you for your response. I don't know if I'm maybe using the AA compliance/color contrast checker tool correctly, but the black on aqua shows a "no" result next to the "Are colors compliant?", whereas the white shows a "sort of..."
- I'm guessing then we're looking at the "WCAG 2 AA Compliant" box, right? And yeah, using colors is definitely complicated Soulbust (talk) 03:28, 29 December 2022 (UTC)
- It looks like the "Are colors compliant" is based on https://www.w3.org/TR/AERT/#color-contrast, which used the older WCAG 1.0. I think WCAG 2.0 is the current target. Yes, I have been looking at WCAG 2 AA Compliant.—Bagumba (talk) 03:53, 29 December 2022 (UTC)
- Incidentally, colors are ultimately set at Module:Gridiron color/data. On its talk page, there's mention of a prior discussion at Wikipedia_talk:WikiProject_National_Football_League/Archive_17#Miami_Dolphins_table_colors_to_meet_WP:CONTRAST.—Bagumba (talk) 04:05, 29 December 2022 (UTC)
- Ah alright. Thank you for the links, they were very helpful. I would've gone with option 2 or option 2 alt 2 from that discussion Soulbust (talk) 04:51, 29 December 2022 (UTC)
Proper Use of pastteamsnote
Fellow editors, I started a similar topic on the Cole Beasley talk page (https://en.wikipedia.org/wiki/Talk:Cole_Beasley#Use_of_pastteamsnote_for_Tampa_Bay_&_Buffalo_Bills) but thought it would be best to post the query here as well. Per the 2022 NFL season rules, every team can "elevate" an individual practice squad member 3 total games in order for them to play without signing them to an active roster contract (i.e. giving them a 53-man roster spot). Regarding the use of pastteamsnote ("Offseason and/or practice squad member only"), if the player is only "elevated" (they were not signed to the active roster and still practice squad members) and played in 3 games or less should the pastteamsnote be used or are users in general not using it whenever a NFL player has played in any regular season or playoff game for that team? Rather than do a game of who's right or wrong with other users, I think overall it's better to have a consensus and for there to be consistency on how that note is used for every NFL player page in Wikipedia. Appreciate the feedback and insight. Diddykong1130 (talk) 06:56, 3 January 2023 (UTC)
Putting Name Within Border
I think it would be look better to have the name of the player be within the infobox like it is with Template:Infobox baseball biography. Batgirl-Awsomeness (talk) 00:50, 29 March 2023 (UTC)
Edit request 9 May 2023
This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
I think just as there's a |statweek= label for the NFL to have the stats updated to the week, there should be a |cflstatweek= parameter to track CFL stats to the week. Currently there's only a |cflstatseason= parameter, which without a |cflstatweek= parameter could make CFL bio stats outdated during the season unless there's someone constantly updating them after every game. BeanieFan11 (talk) 19:13, 9 May 2023 (UTC)
- Done Sorry for the delay in getting to this. * Pppery * it has begun... 02:25, 30 May 2023 (UTC)
Use of the "Module" parameter in this template
Is there a reason that the "module" parameter can't be implemented into this template, similar to how it is in {{infobox person}}? « Gonzo fan2007 (talk) @ 20:26, 11 May 2023 (UTC)
- Great question. I was about to ask this well.
- NFL biaographies can be embedded in other Infobox including Infobox person, but we would want to do it other way as well. Chirag (talk) 23:43, 22 May 2023 (UTC)
- Just want to echo the request for a module parameter to this template. I tried to use the person infobox on Norma Hunt and got reverted to this infobox, but this one doesn't have parameters for adding notable spouses or children and you can't module them in from another infobox. TulsaPoliticsFan (talk) 03:00, 13 June 2023 (UTC)
Player position for playing years?
For players, it's obvious to know what position they play currently (or previously) by the position attribute. But, for coaches (e.g., Dan Campbell), there's no easy way to know what position they played when they were a player (in the infobox). Would it not be a good idea to have a past-position (or something) parameter within the "Career Information" to clarify that for coaches who have the current position of "Head coach" (or some other position) in the template? --Engineerchange (talk) 15:05, 8 September 2023 (UTC)
- Makes sense. For reference, {{Infobox basketball biography}} has
|career_position=
, where coaches can have their playing position listed.—Bagumba (talk) 20:32, 8 September 2023 (UTC)
Edit request 5 November 2023
This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Description of suggested change: Currently, if this template is embedded, it adds a heading "Football career". Usually, we prefer to call the sport "American football" to disambiguate from association football; this is particularly non-ideal on articles of players who have played both types of football, such as Brandon Aubrey.
Diff:
− | | title = {{#ifeq:{{lc:{{{embed|}}}}}|yes|<hr/>''' | + | | title = {{#ifeq:{{lc:{{{embed|}}}}}|yes|<hr/>'''American football career'''|{{If empty|{{{name|}}}|<includeonly>{{PAGENAMEBASE}}</includeonly>}}}} |
IagoQnsi (talk) 02:58, 5 November 2023 (UTC)
- Okay - are the changes from < and &rt intended too? — Martin (MSGJ · talk) 08:10, 5 November 2023 (UTC)
- It seems to be a bug in the diff template that it's showing that; I didn't actually change that part if you look at the source code. Only part that needs changing is "Football" to "American football". IagoQnsi (talk) 08:59, 5 November 2023 (UTC)
- This is one reason it's often prefered to make your edits to the template sandbox rather than as code on the talk page. * Pppery * it has begun... 17:19, 5 November 2023 (UTC)
- It seems to be a bug in the diff template that it's showing that; I didn't actually change that part if you look at the source code. Only part that needs changing is "Football" to "American football". IagoQnsi (talk) 08:59, 5 November 2023 (UTC)
- Done * Pppery * it has begun... 17:19, 5 November 2023 (UTC)
- Thanks! And thanks for the heads up – I don't do much template work so I'll try to remember that for the next time. –IagoQnsi (talk) 23:21, 5 November 2023 (UTC)
Suggestion for player achievements
I see on pages for NFL players that have achievements in the CFL or other leagues, the distinction is held under a seperate header (look at the page for Warren Moon for example). However, their college achievements go on to be lumped in with their NFL ones. For players that didn't play in a league other than the NFL, there is no distinction and all the achievements are just listed together (though I understand there is an order to follow when listing them all). I am making the suggestion that for all player profiles, NFL and College achievements are listed separately with that brief header. Not only do I think it would be more visually pleasing/appropriate (I think the distinction would be important so one can compare their college career vs pro career), I think it would be especially helpful to casual fans looking up a player, as not everyone reading may understand the concepts of an All-Pro, a conference All-Team or Bowl MVP. Terminader (talk) 20:18, 14 November 2023 (UTC)
- I'd suggest brining this up at WT:NFL. Infobox talk pages are not as well watched. At Wikipedia talk:WikiProject National Football League/Archive 18 § Formatting of NFL and college awards in infobox previously, there wasn't any consensus on this topic.—Bagumba (talk) 23:17, 14 November 2023 (UTC)
Player nickname(s)?
Wondering if we can add an optional parameter "nickname". There are lots in the NFL like "Broadway Joe" and "Pinball" Clemens. See List of NFL nicknames. Facts707 (talk) 07:50, 24 November 2023 (UTC)
- Add and source the major ones in the body. As for the infobox, I think it just invites MOS:NICKCRUFT and clutter.—Bagumba (talk) 08:07, 24 November 2023 (UTC)
Edit request 18 January 2024
This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
Description of suggested change: "When specifying an image, do not wikilink the information." has been quoted to say that captions can't be wikilinked (one example). However, that is not what it means. It means not to put brackets around the file name in the image field like below: (WP:CAPTION doesn't say anything about not placing links)
| image = [[File:Joe Burrow 2021.jpg]]
Diff:
− | + | Do not place brackets around the file name. |
~WikiOriginal-9~ (talk) 14:18, 18 January 2024 (UTC)
- Done – Jonesey95 (talk) 14:39, 18 January 2024 (UTC)
- @WikiOriginal-9: FYI for future reference, template documentation typically isn't protected. You can just click on that "edit" link next to where it says "Template documentation". Regards. —Bagumba (talk) 19:14, 18 January 2024 (UTC)
- Thanks Bagumba. I actually have a fair amount of edits to that doc subpage. I just forgot about it, lol. I did remember though once I checked Jonesey95's edit. ~WikiOriginal-9~ (talk) 19:20, 18 January 2024 (UTC)
What about adding the information of a former NFL player becoming a head coach?
What about adding the information of a former NFL player becoming a head coach? For example, former linebacker Jerod Mayo played with the New England Patriots from 2008-2015. In 2024, he was selected as the new head coach for the New England Patriots, replacing Bill Belichick. Abhiramakella (talk) 17:51, 27 February 2024 (UTC)
- Perhaps you mean a coach's playing position should be listed somewhere? This seems to be a frequent request that never gains enough momentum, e.g. Template talk:Infobox NFL biography/Archive 18 § Player position for playing years? Consider discussing this at WT:NFL, where there is more participation.—Bagumba (talk) 18:41, 27 February 2024 (UTC)